Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41489/
---

(Updated Dec. 18, 2015, 1:20 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4186
https://issues.apache.org/jira/browse/MESOS-4186


Repository: mesos


Description
---

Provisioner: Implemented docker v1 parse serialization method in spec.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e69bab43d5f5359cfd8eb4cb7c5ad4a1d22c4e05 
  src/slave/containerizer/mesos/provisioner/docker/spec.hpp 
e674b6f2e705f8b3e49770560eeab4c127473f94 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
  src/tests/containerizer/provisioner_docker_tests.cpp 
3f1717b770e139c3759aab0aeda9dbcf5029b0c2 

Diff: https://reviews.apache.org/r/41489/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41489/#review111212
---

Ship it!


Ship It!

- Jie Yu


On Dec. 18, 2015, 9:20 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41489/
> ---
> 
> (Updated Dec. 18, 2015, 9:20 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4186
> https://issues.apache.org/jira/browse/MESOS-4186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provisioner: Implemented docker v1 parse serialization method in spec.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e69bab43d5f5359cfd8eb4cb7c5ad4a1d22c4e05 
>   src/slave/containerizer/mesos/provisioner/docker/spec.hpp 
> e674b6f2e705f8b3e49770560eeab4c127473f94 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 
> 
> Diff: https://reviews.apache.org/r/41489/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41489/
---

(Updated Dec. 18, 2015, 10:58 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4186
https://issues.apache.org/jira/browse/MESOS-4186


Repository: mesos


Description
---

Provisioner: Implemented docker v1 parse serialization method in spec.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e69bab43d5f5359cfd8eb4cb7c5ad4a1d22c4e05 
  src/slave/containerizer/mesos/provisioner/docker/spec.hpp 
e674b6f2e705f8b3e49770560eeab4c127473f94 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
  src/tests/containerizer/provisioner_docker_tests.cpp 
3f1717b770e139c3759aab0aeda9dbcf5029b0c2 

Diff: https://reviews.apache.org/r/41489/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41489/
---

(Updated Dec. 18, 2015, 1:31 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4186
https://issues.apache.org/jira/browse/MESOS-4186


Repository: mesos


Description
---

Provisioner: Implemented docker v1 parse serialization method in spec.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e69bab43d5f5359cfd8eb4cb7c5ad4a1d22c4e05 
  src/slave/containerizer/mesos/provisioner/docker/spec.hpp 
e674b6f2e705f8b3e49770560eeab4c127473f94 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
  src/tests/containerizer/provisioner_docker_tests.cpp 
b57ee8681e0861cf93f5dcf9368c004a57df1374 

Diff: https://reviews.apache.org/r/41489/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41489/#review111031
---

Ship it!



src/slave/containerizer/mesos/provisioner/docker/spec.hpp (line 38)


s/validateManifest/validate/

Since ImageManifest is already presented in the function arguments.



src/slave/containerizer/mesos/provisioner/docker/spec.hpp (line 50)


s/validateManifest/validate/



src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 48)


2 lines apart


- Jie Yu


On Dec. 17, 2015, 2:39 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41489/
> ---
> 
> (Updated Dec. 17, 2015, 2:39 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4186
> https://issues.apache.org/jira/browse/MESOS-4186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provisioner: Implemented docker v1 parse serialization method in spec.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e69bab43d5f5359cfd8eb4cb7c5ad4a1d22c4e05 
>   src/slave/containerizer/mesos/provisioner/docker/spec.hpp 
> e674b6f2e705f8b3e49770560eeab4c127473f94 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 
> 
> Diff: https://reviews.apache.org/r/41489/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>