Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-31 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
---

(Updated Dec. 31, 2015, 3:06 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4225
https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
---

Unified Container: Implemented passing entrypoint in runtime config.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
b2e23d82ea255e1c91d7537a58f86632763d9a56 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
  src/slave/containerizer/mesos/provisioner/store.hpp 
aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp 
bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-31 Thread Gilbert Song 


> On Dec. 30, 2015, 6:41 p.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 1614
> > 
> >
> > Why change this test?

Because we need to os::write manifest to disk and move it to store directory. 
We have to make sure `layId` is identical as "456"(originally we only need 
`layerid - path` pair for MockPuller), and two `layerPath` are redundant. We 
only use the last one.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review112369
---


On Dec. 31, 2015, 3:06 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> ---
> 
> (Updated Dec. 31, 2015, 3:06 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
> https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> b2e23d82ea255e1c91d7537a58f86632763d9a56 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-28 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
---

(Updated Dec. 28, 2015, 3:49 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4225
https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
---

Unified Container: Implemented passing entrypoint in runtime config.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
  src/slave/containerizer/mesos/provisioner/store.hpp 
aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp 
bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
---

(Updated Dec. 18, 2015, 1:21 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-2980
https://issues.apache.org/jira/browse/MESOS-2980


Repository: mesos


Description
---

Unified Container: Implemented passing entrypoint in runtime config.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
  src/slave/containerizer/mesos/provisioner/store.hpp 
8d1493856420dee3210af79b628c8c770c5c8550 
  src/tests/containerizer/provisioner_docker_tests.cpp 
3f1717b770e139c3759aab0aeda9dbcf5029b0c2 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review83
---


Bad patch!

Reviews applied: [41011, 41125, 41194, 41406, 41407]

Failed command: ./support/apply-review.sh -n -r 41407

Error:
 2015-12-18 13:43:23 URL:https://reviews.apache.org/r/41407/diff/raw/ 
[4297/4297] -> "41407.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/provisioner/docker/puller.cpp:142
error: src/slave/containerizer/mesos/provisioner/docker/puller.cpp: patch does 
not apply

- Mesos ReviewBot


On Dec. 18, 2015, 9:21 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> ---
> 
> (Updated Dec. 18, 2015, 9:21 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2980
> https://issues.apache.org/jira/browse/MESOS-2980
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 8d1493856420dee3210af79b628c8c770c5c8550 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review111321
---


Patch looks great!

Reviews applied: [41011, 41125, 41194, 41406, 41407, 41487, 41488, 41489, 
41490, 41491]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 18, 2015, 9:31 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> ---
> 
> (Updated Dec. 18, 2015, 9:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2980
> https://issues.apache.org/jira/browse/MESOS-2980
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 8d1493856420dee3210af79b628c8c770c5c8550 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> b57ee8681e0861cf93f5dcf9368c004a57df1374 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
---

(Updated Dec. 18, 2015, 1:31 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-2980
https://issues.apache.org/jira/browse/MESOS-2980


Repository: mesos


Description
---

Unified Container: Implemented passing entrypoint in runtime config.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
  src/slave/containerizer/mesos/provisioner/store.hpp 
8d1493856420dee3210af79b628c8c770c5c8550 
  src/tests/containerizer/provisioner_docker_tests.cpp 
b57ee8681e0861cf93f5dcf9368c004a57df1374 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review110880
---


Bad patch!

Reviews applied: [41011, 41125, 41194, 41406, 41407]

Failed command: ./support/apply-review.sh -n -r 41407

Error:
 2015-12-17 03:22:59 URL:https://reviews.apache.org/r/41407/diff/raw/ 
[3922/3922] -> "41407.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/provisioner/docker/puller.cpp:180
error: src/slave/containerizer/mesos/provisioner/docker/puller.cpp: patch does 
not apply

- Mesos ReviewBot


On Dec. 17, 2015, 2:39 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> ---
> 
> (Updated Dec. 17, 2015, 2:39 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2980
> https://issues.apache.org/jira/browse/MESOS-2980
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified Container: Implemented passing entrypoint in runtime config.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 8d1493856420dee3210af79b628c8c770c5c8550 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 
> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>