Re: Review Request 41961: Added an HTTP decode response method.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/#review115076
---

Ship it!


Ship It!

- Timothy Chen


On Jan. 17, 2016, 9:50 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41961/
> ---
> 
> (Updated Jan. 17, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an HTTP decode response method.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 1fe549e9c3c64b310048388d90ab04e5641e08a1 
>   3rdparty/libprocess/src/http.cpp 40fd87c4aa1417d4746a5e4268c30c0e55d0ec0e 
> 
> Diff: https://reviews.apache.org/r/41961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41961: Added an HTTP decode response method.

[Jie Yu]

> On Jan. 8, 2016, 9:31 p.m., Timothy Chen wrote:
> > 3rdparty/libprocess/src/http.cpp, line 707
> > 
> >
> > Why don't we return the failure message?

This is a limitation of the decoder currently.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/#review113540
---


On Jan. 13, 2016, 6:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41961/
> ---
> 
> (Updated Jan. 13, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an HTTP decode response method. This will be used to decode the 
> response returned from curl.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ed708fe4b0006782a19f9c61603f152e32a02e8e 
>   3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 
> 
> Diff: https://reviews.apache.org/r/41961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41961: Added an HTTP decode response method.

[Jie Yu]

> On Jan. 8, 2016, 9:30 p.m., Timothy Chen wrote:
> > 3rdparty/libprocess/src/http.cpp, line 714
> > 
> >
> > Should we also comment that we only return the first response even if 
> > there are multiples?

Changed the interfaces to return a vector instead. I think we might need to 
decode a few responses from a string in some case.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/#review113539
---


On Jan. 13, 2016, 6:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41961/
> ---
> 
> (Updated Jan. 13, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an HTTP decode response method. This will be used to decode the 
> response returned from curl.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ed708fe4b0006782a19f9c61603f152e32a02e8e 
>   3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 
> 
> Diff: https://reviews.apache.org/r/41961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41961: Added an HTTP decode response method.

[Jie Yu]

> On Jan. 8, 2016, 9:30 p.m., Timothy Chen wrote:
> > 3rdparty/libprocess/include/process/http.hpp, line 718
> > 
> >
> > bmahler might have different say on this, as he was proposing that the 
> > comment style should stay the same with in the file for now. I don't know 
> > if that changed?

See Connection in this file. It's aleady using the new comments style.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/#review113539
---


On Jan. 13, 2016, 6:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41961/
> ---
> 
> (Updated Jan. 13, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an HTTP decode response method. This will be used to decode the 
> response returned from curl.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ed708fe4b0006782a19f9c61603f152e32a02e8e 
>   3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 
> 
> Diff: https://reviews.apache.org/r/41961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41961: Added an HTTP decode response method.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/
---

(Updated Jan. 17, 2016, 9:50 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

Review comments.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description (updated)
---

Added an HTTP decode response method.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
1fe549e9c3c64b310048388d90ab04e5641e08a1 
  3rdparty/libprocess/src/http.cpp 40fd87c4aa1417d4746a5e4268c30c0e55d0ec0e 

Diff: https://reviews.apache.org/r/41961/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 41961: Added an HTTP decode response method.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/
---

(Updated Jan. 13, 2016, 6:36 a.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
---

Added an HTTP decode response method. This will be used to decode the response 
returned from curl.


Diffs
-

  3rdparty/libprocess/include/process/http.hpp 
ed708fe4b0006782a19f9c61603f152e32a02e8e 
  3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 

Diff: https://reviews.apache.org/r/41961/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 41961: Added an HTTP decode response method.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/#review113539
---



3rdparty/libprocess/include/process/http.hpp (line 718)


bmahler might have different say on this, as he was proposing that the 
comment style should stay the same with in the file for now. I don't know if 
that changed?



3rdparty/libprocess/src/http.cpp (line 714)


Should we also comment that we only return the first response even if there 
are multiples?


- Timothy Chen


On Jan. 6, 2016, 1:44 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41961/
> ---
> 
> (Updated Jan. 6, 2016, 1:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an HTTP decode response method. This will be used to decode the 
> response returned from curl.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ed708fe4b0006782a19f9c61603f152e32a02e8e 
>   3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 
> 
> Diff: https://reviews.apache.org/r/41961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41961: Added an HTTP decode response method.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/#review113540
---



3rdparty/libprocess/src/http.cpp (line 707)


Why don't we return the failure message?


- Timothy Chen


On Jan. 6, 2016, 1:44 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41961/
> ---
> 
> (Updated Jan. 6, 2016, 1:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an HTTP decode response method. This will be used to decode the 
> response returned from curl.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ed708fe4b0006782a19f9c61603f152e32a02e8e 
>   3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 
> 
> Diff: https://reviews.apache.org/r/41961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41961: Added an HTTP decode response method.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/#review113009
---


Patch looks great!

Reviews applied: [41956, 41957, 41960, 41961]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 1:44 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41961/
> ---
> 
> (Updated Jan. 6, 2016, 1:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an HTTP decode response method. This will be used to decode the 
> response returned from curl.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ed708fe4b0006782a19f9c61603f152e32a02e8e 
>   3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 
> 
> Diff: https://reviews.apache.org/r/41961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>