Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/#review115547
---


Patch looks great!

Reviews applied: [42235, 41961, 42236, 42237, 42275, 42238, 42442, 42443, 
42444, 42239]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 21, 2016, 12:41 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42239/
> ---
> 
> (Updated Jan. 21, 2016, 12:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for the Docker URI fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 
> 
> Diff: https://reviews.apache.org/r/42239/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/#review115586
---

Ship it!


Ship It!

- Timothy Chen


On Jan. 21, 2016, 12:41 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42239/
> ---
> 
> (Updated Jan. 21, 2016, 12:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for the Docker URI fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 
> 
> Diff: https://reviews.apache.org/r/42239/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/#review115446
---

Ship it!


Ship It!

- Gilbert Song


On Jan. 18, 2016, 12:14 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42239/
> ---
> 
> (Updated Jan. 18, 2016, 12:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for the Docker URI fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 
> 
> Diff: https://reviews.apache.org/r/42239/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Jie Yu 


> On Jan. 18, 2016, 11:02 p.m., Timothy Chen wrote:
> > src/tests/uri_fetcher_tests.cpp, line 216
> > 
> >
> > Should we create a constant for docker registry server url? We're 
> > referring to it in multiple places and I think we could then update it if 
> > Docker decides to change it.

Created a constant, and added a TODO to expose it.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/#review115074
---


On Jan. 21, 2016, 12:41 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42239/
> ---
> 
> (Updated Jan. 21, 2016, 12:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for the Docker URI fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 
> 
> Diff: https://reviews.apache.org/r/42239/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/
---

(Updated Jan. 21, 2016, 12:41 a.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy 
Chen.


Changes
---

Review comments.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
---

Added tests for the Docker URI fetcher plugin.


Diffs (updated)
-

  src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 

Diff: https://reviews.apache.org/r/42239/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/
---

(Updated Jan. 18, 2016, 8:14 a.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy 
Chen.


Changes
---

Rebased.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
---

Added tests for the Docker URI fetcher plugin.


Diffs (updated)
-

  src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 

Diff: https://reviews.apache.org/r/42239/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/#review114974
---


Patch looks great!

Reviews applied: [42235, 41961, 42236, 42237, 42275, 42238, 42442, 42443, 
42444, 42239]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 18, 2016, 8:14 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42239/
> ---
> 
> (Updated Jan. 18, 2016, 8:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for the Docker URI fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 
> 
> Diff: https://reviews.apache.org/r/42239/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-18 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/#review115074
---



src/tests/uri_fetcher_tests.cpp (line 216)


Should we create a constant for docker registry server url? We're referring 
to it in multiple places and I think we could then update it if Docker decides 
to change it.



src/tests/uri_fetcher_tests.cpp (line 231)


should we check that the manifest is referring to busybox:latest?



src/tests/uri_fetcher_tests.cpp (line 275)


We should check for the blob too right?


- Timothy Chen


On Jan. 18, 2016, 8:14 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42239/
> ---
> 
> (Updated Jan. 18, 2016, 8:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for the Docker URI fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 
> 
> Diff: https://reviews.apache.org/r/42239/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-17 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/
---

(Updated Jan. 18, 2016, 6:54 a.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy 
Chen.


Changes
---

Rebased.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
---

Added tests for the Docker URI fetcher plugin.


Diffs (updated)
-

  src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 

Diff: https://reviews.apache.org/r/42239/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-17 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/
---

(Updated Jan. 17, 2016, 9:53 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy 
Chen.


Changes
---

Used internet filter.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description (updated)
---

Added tests for the Docker URI fetcher plugin.


Diffs (updated)
-

  src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 

Diff: https://reviews.apache.org/r/42239/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-13 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/
---

(Updated Jan. 13, 2016, 11:29 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy 
Chen.


Changes
---

Rebased.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
---

Added tests for the Docker URI fetcher plugin.

I left a TODO here because those tests depend on internet access. We should try 
to make the tests locally testable.


Diffs (updated)
-

  src/tests/uri_fetcher_tests.cpp ca1710cc852ebfd14dd180a245da67e6c98f148f 

Diff: https://reviews.apache.org/r/42239/diff/


Testing
---

make check


Thanks,

Jie Yu