Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-03-11 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/#review123089
---


Ship it!




- Joris Van Remoortere


On March 11, 2016, 9:24 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43709/
> ---
> 
> (Updated March 11, 2016, 9:24 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review was originally at #40582, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake 
> 40482e6c604d7a1f20d896b08f530c66910979a9 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> c10c6d9d7c68a2d5b27d68736a49d212e70dcd05 
>   3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
> 3d074a5296b4435b29792201cb9a1b021673fd97 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp 
> eb52beb2bcdfbdb71e1456f3286e087e7bbf524e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
> 8698e997965add14e0a8a268b0ebcf1a5ab4d49d 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 03e09fb33bf038930a2be0370883511e93f94753 
> 
> Diff: https://reviews.apache.org/r/43709/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-03-11 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/
---

(Updated March 11, 2016, 9:24 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4704
https://issues.apache.org/jira/browse/MESOS-4704


Repository: mesos


Description
---

This review was originally at #40582, put up by Dario Bazan. Dario went
on paternity leave, so I've dusted it off, rebased it against the state
of the art, and gotten it ready for submission. It remains mostly
unchanged, with only minor alterations from the original.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake 
40482e6c604d7a1f20d896b08f530c66910979a9 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
c10c6d9d7c68a2d5b27d68736a49d212e70dcd05 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
3d074a5296b4435b29792201cb9a1b021673fd97 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp 
eb52beb2bcdfbdb71e1456f3286e087e7bbf524e 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
8698e997965add14e0a8a268b0ebcf1a5ab4d49d 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
03e09fb33bf038930a2be0370883511e93f94753 

Diff: https://reviews.apache.org/r/43709/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-03-10 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/#review123087
---




3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt (lines 48 - 49)


Can we please alpabetize?


- Joris Van Remoortere


On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43709/
> ---
> 
> (Updated Feb. 18, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review was originally at #40582, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
> 3d074a5296b4435b29792201cb9a1b021673fd97 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp 
> eb52beb2bcdfbdb71e1456f3286e087e7bbf524e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
> 8698e997965add14e0a8a268b0ebcf1a5ab4d49d 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
> 
> Diff: https://reviews.apache.org/r/43709/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-03-10 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/#review122998
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43709/
> ---
> 
> (Updated Feb. 18, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review was originally at #40582, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
> 3d074a5296b4435b29792201cb9a1b021673fd97 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp 
> eb52beb2bcdfbdb71e1456f3286e087e7bbf524e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
> 8698e997965add14e0a8a268b0ebcf1a5ab4d49d 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
> 
> Diff: https://reviews.apache.org/r/43709/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-02-27 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/#review121106
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43709/
> ---
> 
> (Updated Feb. 18, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review was originally at #40582, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
> 3d074a5296b4435b29792201cb9a1b021673fd97 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp 
> eb52beb2bcdfbdb71e1456f3286e087e7bbf524e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
> 8698e997965add14e0a8a268b0ebcf1a5ab4d49d 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
> 
> Diff: https://reviews.apache.org/r/43709/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>