Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/
---

(Updated April 4, 2016, 4:32 p.m.)


Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till Toenshoff, 
and Timothy Chen.


Changes
---

Address @gyliu's comments.


Bugs: MESOS-5085
https://issues.apache.org/jira/browse/MESOS-5085


Repository: mesos


Description
---

Update `Slave::_recoverContainerizer` to use `ContainerState`.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 

Diff: https://reviews.apache.org/r/44798/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

> On April 3, 2016, 2:08 p.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 4694
> > 
> >
> > I know that those code are copied from 
> > `MesosContainerizerProcess::recover`, but it is better update the comments 
> > a bit.
> > 
> > s/run states/run-time status

Should be `runtime` instead of `run-time`?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/#review126726
---


On April 3, 2016, 2:09 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44798/
> ---
> 
> (Updated April 3, 2016, 2:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till 
> Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-5085
> https://issues.apache.org/jira/browse/MESOS-5085
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update `Slave::_recoverContainerizer` to use `ContainerState`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.hpp 
> ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
> 
> Diff: https://reviews.apache.org/r/44798/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

> On April 3, 2016, 2:25 p.m., Guangya Liu wrote:
> > It is always suggested to use past tone for the summary and ditto for the 
> > patch chain.

Got it. I would update in next round.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/#review126729
---


On April 3, 2016, 2:09 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44798/
> ---
> 
> (Updated April 3, 2016, 2:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till 
> Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-5085
> https://issues.apache.org/jira/browse/MESOS-5085
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update `Slave::_recoverContainerizer` to use `ContainerState`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.hpp 
> ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
> 
> Diff: https://reviews.apache.org/r/44798/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

> On April 3, 2016, 2:08 p.m., Guangya Liu wrote:
> > src/slave/containerizer/containerizer.hpp, line 29
> > 
> >
> > what is the use of this include for this patch?

Thanks for your view. `ContainerState` is defined in `isolator.proto`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/#review126726
---


On April 3, 2016, 2:09 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44798/
> ---
> 
> (Updated April 3, 2016, 2:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till 
> Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-5085
> https://issues.apache.org/jira/browse/MESOS-5085
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update `Slave::_recoverContainerizer` to use `ContainerState`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.hpp 
> ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
> 
> Diff: https://reviews.apache.org/r/44798/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/#review126729
---



It is always suggested to use past tone for the summary and ditto for the patch 
chain.

- Guangya Liu


On 四月 3, 2016, 2:09 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44798/
> ---
> 
> (Updated 四月 3, 2016, 2:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till 
> Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-5085
> https://issues.apache.org/jira/browse/MESOS-5085
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update `Slave::_recoverContainerizer` to use `ContainerState`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.hpp 
> ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
> 
> Diff: https://reviews.apache.org/r/44798/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/
---

(Updated April 3, 2016, 2:09 p.m.)


Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till Toenshoff, 
and Timothy Chen.


Bugs: MESOS-5085
https://issues.apache.org/jira/browse/MESOS-5085


Repository: mesos


Description
---

Update `Slave::_recoverContainerizer` to use `ContainerState`.


Diffs
-

  src/slave/containerizer/containerizer.hpp 
ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 

Diff: https://reviews.apache.org/r/44798/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/#review126726
---




src/slave/containerizer/containerizer.hpp (line 29)


what is the use of this include for this patch?



src/slave/slave.cpp (line 4694)


I know that those code are copied from 
`MesosContainerizerProcess::recover`, but it is better update the comments a 
bit.

s/run states/run-time status


- Guangya Liu


On 四月 3, 2016, 1:06 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44798/
> ---
> 
> (Updated 四月 3, 2016, 1:06 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-3709
> https://issues.apache.org/jira/browse/MESOS-3709
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update `Slave::_recoverContainerizer` to use `ContainerState`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.hpp 
> ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
> 
> Diff: https://reviews.apache.org/r/44798/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/
---

(Updated April 3, 2016, 1:06 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3709
https://issues.apache.org/jira/browse/MESOS-3709


Repository: mesos


Description
---

Update `Slave::_recoverContainerizer` to use `ContainerState`.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 

Diff: https://reviews.apache.org/r/44798/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/
---

(Updated March 16, 2016, 5:56 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3709
https://issues.apache.org/jira/browse/MESOS-3709


Repository: mesos


Description
---

Update `Slave::_recoverContainerizer` to use `ContainerState`.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/44798/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/
---

(Updated March 16, 2016, 11:21 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3709
https://issues.apache.org/jira/browse/MESOS-3709


Repository: mesos


Description
---

Update `Slave::_recoverContainerizer` to use `ContainerState`.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/44798/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/
---

(Updated March 15, 2016, 2:02 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase


Summary (updated)
-

Update `Slave::_recoverContainerizer` to use `ContainerState`.


Bugs: MESOS-3709
https://issues.apache.org/jira/browse/MESOS-3709


Repository: mesos


Description (updated)
---

Update `Slave::_recoverContainerizer` to use `ContainerState`.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/44798/diff/


Testing
---


Thanks,

haosdent huang