Re: Review Request 45861: Windows: Fixed non-blocking connect.

2016-04-09 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/
---

(Updated April 9, 2016, 11:51 p.m.)


Review request for mesos, Alex Clemmer and switched to 'mcypark'.


Repository: mesos


Description
---

Windows: Fixed non-blocking connect.


Diffs
-

  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/45861/diff/


Testing
---

OSX: make check -j8


Thanks,

Daniel Pravat



Re: Review Request 45861: Windows: Fixed non-blocking connect.

2016-04-08 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/
---

(Updated April 9, 2016, 12:32 a.m.)


Review request for mesos, Alex Clemmer and switched to 'mcypark'.


Repository: mesos


Description
---

Windows: Fixed non-blocking connect.


Diffs (updated)
-

  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/45861/diff/


Testing
---

OSX: make check -j8


Thanks,

Daniel Pravat



Re: Review Request 45861: Windows: Fixed non-blocking connect.

2016-04-08 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/#review127899
---


Ship it!




Ship It!

- Michael Park


On April 8, 2016, 9:47 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45861/
> ---
> 
> (Updated April 8, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and switched to 'mcypark'.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Fixed non-blocking connect.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> cb2878565a112017b190b4ff83dc65a876ea45f9 
> 
> Diff: https://reviews.apache.org/r/45861/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check -j8
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>



Re: Review Request 45861: Windows: Fixed non-blocking connect.

2016-04-08 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/
---

(Updated April 8, 2016, 9:47 p.m.)


Review request for mesos, Alex Clemmer and switched to 'mcypark'.


Repository: mesos


Description
---

Windows: Fixed non-blocking connect.


Diffs (updated)
-

  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/45861/diff/


Testing
---

OSX: make check -j8


Thanks,

Daniel Pravat



Re: Review Request 45861: Windows: Fixed non-blocking connect.

2016-04-07 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/#review127575
---



Patch looks great!

Reviews applied: [45861]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 7, 2016, 8:08 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45861/
> ---
> 
> (Updated April 7, 2016, 8:08 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and switched to 'mcypark'.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Fixed non-blocking connect.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> cb2878565a112017b190b4ff83dc65a876ea45f9 
> 
> Diff: https://reviews.apache.org/r/45861/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check -j8
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>