Re: Review Request 47126: Changed the submodular scheduler to constrained maximization.

2017-03-01 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47126/#review167312
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On May 11, 2016, 3:43 p.m., Chris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47126/
> ---
> 
> (Updated May 11, 2016, 3:43 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The algorithm is maximizing when it may need have a constrained maximization.
> 
> 
> Diffs
> -
> 
>   
> src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.cpp
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/47126/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chris
> 
>



Re: Review Request 47126: Changed the submodular scheduler to constrained maximization.

2016-05-11 Thread Chris

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47126/
---

(Updated May 11, 2016, 3:43 p.m.)


Review request for mesos.


Repository: mesos


Description (updated)
---

The algorithm is maximizing when it may need have a constrained maximization.


Diffs
-

  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.cpp
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47126/diff/


Testing
---


Thanks,

Chris



Re: Review Request 47126: Changed the submodular scheduler to constrained maximization.

2016-05-11 Thread Chris

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47126/
---

(Updated May 11, 2016, 3:42 p.m.)


Review request for mesos.


Summary (updated)
-

Changed the submodular scheduler to constrained maximization.


Repository: mesos


Description (updated)
---

Forgot the algorithm is maximizing when it needs to minimize.


Diffs (updated)
-

  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.cpp
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47126/diff/


Testing
---


Thanks,

Chris