Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/
---

(Updated June 13, 2016, 9:45 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated CHANGELOG for libprocess HTTP authorization.


Diffs (updated)
-

  CHANGELOG 0513c1594098c8afdb7085ecab5edf07f93f7d0e 

Diff: https://reviews.apache.org/r/48380/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-12 Thread Joerg Schad 


> On June 8, 2016, 1:10 p.m., Joerg Schad wrote:
> > Should we add this as well to upgrades.md?
> 
> Greg Mann wrote:
> Yes! Thanks for thinking of this, Joerg!
> 
> Joerg Schad wrote:
> I will take care of that in another patch.

https://reviews.apache.org/r/48598/


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/#review136634
---


On June 10, 2016, 4:04 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48380/
> ---
> 
> (Updated June 10, 2016, 4:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for libprocess HTTP authorization.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0513c1594098c8afdb7085ecab5edf07f93f7d0e 
> 
> Diff: https://reviews.apache.org/r/48380/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-10 Thread Greg Mann 


> On June 8, 2016, 8:34 p.m., Vinod Kone wrote:
> > CHANGELOG, line 154
> > 
> >
> > Is there an example in the user doc on what changes are specifically 
> > needed that can be linked here?

There isn't such an example yet, but I'll try to test and verify the relevant 
ACLs and post another patch for those user docs, so I can link them here.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/#review136696
---


On June 10, 2016, 4:04 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48380/
> ---
> 
> (Updated June 10, 2016, 4:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for libprocess HTTP authorization.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0513c1594098c8afdb7085ecab5edf07f93f7d0e 
> 
> Diff: https://reviews.apache.org/r/48380/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-10 Thread Greg Mann 


> On June 8, 2016, 3:01 p.m., Joerg Schad wrote:
> > CHANGELOG, line 149
> > 
> >
> > Could you doublecheck that we added all newly authorized endpoints?

I updated this with references to the other endpoints we authorized that don't 
use authorization-based filtering, since MESOS-4931 appears in this list as 
well, which covers the filtered endpoints. What do you think?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/#review136651
---


On June 10, 2016, 4:04 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48380/
> ---
> 
> (Updated June 10, 2016, 4:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for libprocess HTTP authorization.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0513c1594098c8afdb7085ecab5edf07f93f7d0e 
> 
> Diff: https://reviews.apache.org/r/48380/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-10 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/
---

(Updated June 10, 2016, 4:04 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Included more authorized endpoints in the changelog.


Repository: mesos


Description
---

Updated CHANGELOG for libprocess HTTP authorization.


Diffs (updated)
-

  CHANGELOG 0513c1594098c8afdb7085ecab5edf07f93f7d0e 

Diff: https://reviews.apache.org/r/48380/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/
---

(Updated June 9, 2016, 6:33 p.m.)


Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Updated CHANGELOG for libprocess HTTP authorization.


Diffs (updated)
-

  CHANGELOG 0513c1594098c8afdb7085ecab5edf07f93f7d0e 

Diff: https://reviews.apache.org/r/48380/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/
---

(Updated June 9, 2016, 6:32 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Addressed comments.


Repository: mesos


Description
---

Updated CHANGELOG for libprocess HTTP authorization.


Diffs (updated)
-

  CHANGELOG 0513c1594098c8afdb7085ecab5edf07f93f7d0e 

Diff: https://reviews.apache.org/r/48380/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-08 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/#review136696
---




CHANGELOG (line 153)


s/authorized/authorization enabled/



CHANGELOG (line 154)


Is there an example in the user doc on what changes are specifically needed 
that can be linked here?



CHANGELOG 


keep this.


- Vinod Kone


On June 7, 2016, 11:19 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48380/
> ---
> 
> (Updated June 7, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for libprocess HTTP authorization.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 3f018a58b05c3110c72eab06928dc2d373c141fc 
> 
> Diff: https://reviews.apache.org/r/48380/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-08 Thread Joerg Schad 


> On June 8, 2016, 1:10 p.m., Joerg Schad wrote:
> > Should we add this as well to upgrades.md?
> 
> Greg Mann wrote:
> Yes! Thanks for thinking of this, Joerg!

I will take care of that in another patch.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/#review136634
---


On June 7, 2016, 11:19 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48380/
> ---
> 
> (Updated June 7, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for libprocess HTTP authorization.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 3f018a58b05c3110c72eab06928dc2d373c141fc 
> 
> Diff: https://reviews.apache.org/r/48380/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-08 Thread Greg Mann 


> On June 8, 2016, 1:10 p.m., Joerg Schad wrote:
> > Should we add this as well to upgrades.md?

Yes! Thanks for thinking of this, Joerg!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/#review136634
---


On June 7, 2016, 11:19 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48380/
> ---
> 
> (Updated June 7, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for libprocess HTTP authorization.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 3f018a58b05c3110c72eab06928dc2d373c141fc 
> 
> Diff: https://reviews.apache.org/r/48380/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-08 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48380/#review136651
---


Fix it, then Ship it!





CHANGELOG (line 149)


Could you doublecheck that we added all newly authorized endpoints?



CHANGELOG (line 152)


the `...` endpoint


- Joerg Schad


On June 7, 2016, 11:19 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48380/
> ---
> 
> (Updated June 7, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for libprocess HTTP authorization.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 3f018a58b05c3110c72eab06928dc2d373c141fc 
> 
> Diff: https://reviews.apache.org/r/48380/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>