Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/#review141890 --- Patch looks great! Reviews applied: [49381] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 12, 2016, 6:57 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49381/ > --- > > (Updated July 12, 2016, 6:57 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Michael Park. > > > Bugs: MESOS-5700 > https://issues.apache.org/jira/browse/MESOS-5700 > > > Repository: mesos > > > Description > --- > > Benchmark for Resources class (cpu, mem & port). > > > Diffs > - > > src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e > > Diff: https://reviews.apache.org/r/49381/diff/ > > > Testing > --- > > make > MESOS_BENCHMARK=1 GTEST_FILTER="*Resources_BENCHMARK_Test.Operator*" make > check > > [--] Global test environment set-up. > [--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/0 > Took 5429us to `AddAndAssign` "cpus:1" 1 times. > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/0 (6 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/1 > Took 9317us to `AddAndAssign` "cpus:1;mem:2" 1 times. > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/1 (10 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/2 > **Took 5.271509secs to `AddAndAssign` "cpus(r0):1;cpus(r1):1; ... > cpus(r99):1" 1 times.** > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/2 (5271 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/3 > **Took 13.017557secs to `AddAndAssign` "cpus(r0):1;mem(r0):100; ... > cpus(r99):1;mem(r99):100" 1 times.** > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/3 (13018 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/4 > **Took 3.357184secs to `AddAndAssign` "[1-2, 4-5, ... , 298-299]" 1 > times.** > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/4 (3358 ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/0 > Took 20977us to `Add` "cpus:1" 1 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/0 (21 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/1 > Took 26069us to `Add` "cpus:1;mem:2" 1 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/1 (26 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/2 > **Took 5.891177secs to `Add` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 1 > times.** > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/2 (5891 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/3 > **Took 14.894299secs to `Add` "cpus(r0):1;mem(r0):100; ... > cpus(r99):1;mem(r99):100" 1 times.** > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/3 > (14895 ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/4 > **Took 2.321527secs to `Add` "[1-2, 4-5, ... , 298-299]" 1 times.** > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/4 (2321 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/0 > Took 26362us to `Sub` "cpus:1" 1 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/0 (27 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/1 > Took 30828us to `Sub` "cpus:1;mem:2" 1 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/1 (31 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/2 > Took 431531us to `Sub` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 1 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/2 (431 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/3 > Took 837827us to `Sub` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" > 1 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/3 (838 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/4 > **Took 2.173558secs to `Sub` "[1-2, 4-5, ... , 298-299]" 1
Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/ --- (Updated July 12, 2016, 2:57 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, and Michael Park. Changes --- Update test data for 100 ports. Bugs: MESOS-5700 https://issues.apache.org/jira/browse/MESOS-5700 Repository: mesos Description (updated) --- Benchmark for Resources class (cpu, mem & port). Diffs (updated) - src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e Diff: https://reviews.apache.org/r/49381/diff/ Testing (updated) --- make MESOS_BENCHMARK=1 GTEST_FILTER="*Resources_BENCHMARK_Test.Operator*" make check [--] Global test environment set-up. [--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/0 Took 5429us to `AddAndAssign` "cpus:1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/0 (6 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/1 Took 9317us to `AddAndAssign` "cpus:1;mem:2" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/1 (10 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/2 **Took 5.271509secs to `AddAndAssign` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 1 times.** [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/2 (5271 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/3 **Took 13.017557secs to `AddAndAssign` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" 1 times.** [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/3 (13018 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/4 **Took 3.357184secs to `AddAndAssign` "[1-2, 4-5, ... , 298-299]" 1 times.** [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/4 (3358 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/0 Took 20977us to `Add` "cpus:1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/0 (21 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/1 Took 26069us to `Add` "cpus:1;mem:2" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/1 (26 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/2 **Took 5.891177secs to `Add` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 1 times.** [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/2 (5891 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/3 **Took 14.894299secs to `Add` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" 1 times.** [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/3 (14895 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/4 **Took 2.321527secs to `Add` "[1-2, 4-5, ... , 298-299]" 1 times.** [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/4 (2321 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/0 Took 26362us to `Sub` "cpus:1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/0 (27 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/1 Took 30828us to `Sub` "cpus:1;mem:2" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/1 (31 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/2 Took 431531us to `Sub` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/2 (431 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/3 Took 837827us to `Sub` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/3 (838 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/4 **Took 2.173558secs to `Sub` "[1-2, 4-5, ... , 298-299]" 1 times.** [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/4 (2174 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/0 Took 3536us to `SubAndAssign` "cpus:1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/0 (4 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/1 Took 6091us to `SubAndAssign` "cpus:1;mem:2" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/1 (6 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/2 Took 399855us to `SubAndAssign` "cpus(r0):1;cpus(r1):1;
Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/ --- (Updated July 12, 2016, 12:11 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, and Michael Park. Changes --- Add test results. Bugs: MESOS-5700 https://issues.apache.org/jira/browse/MESOS-5700 Repository: mesos Description --- Benchmark for Resources class (cpu, mem & port) Diffs - src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e Diff: https://reviews.apache.org/r/49381/diff/ Testing (updated) --- make MESOS_BENCHMARK=1 GTEST_FILTER="*Resources_BENCHMARK_Test.Operator*" make check [--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/0 Took 4550us to `AddAndAssign` "cpus:1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/0 (5 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/1 Took 9469us to `AddAndAssign` "cpus:1;mem:2" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/1 (10 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/2 Took 5.568495secs to `AddAndAssign` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/2 (5568 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/3 Took 14.068508secs to `AddAndAssign` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/3 (14069 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/4 Took 16679us to `AddAndAssign` "[1-2, 3-4, ... , 199-200]" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/4 (17 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/0 Took 23720us to `Add` "cpus:1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/0 (24 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/1 Took 27599us to `Add` "cpus:1;mem:2" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/1 (27 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/2 Took 6.361708secs to `Add` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/2 (6362 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/3 Took 15.174096secs to `Add` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/3 (15175 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/4 Took 34929us to `Add` "[1-2, 3-4, ... , 199-200]" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/4 (35 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/0 Took 30136us to `Sub` "cpus:1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/0 (30 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/1 Took 36232us to `Sub` "cpus:1;mem:2" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/1 (36 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/2 Took 431213us to `Sub` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/2 (432 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/3 Took 870109us to `Sub` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/3 (870 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/4 Took 22045us to `Sub` "[1-2, 3-4, ... , 199-200]" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/4 (22 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/0 Took 3338us to `SubAndAssign` "cpus:1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/0 (4 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/1 Took 6255us to `SubAndAssign` "cpus:1;mem:2" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/1 (6 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/2 Took 400747us to `SubAndAssign` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/2 (401 ms) [ RUN
Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/ --- (Updated July 12, 2016, 12:08 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, and Michael Park. Changes --- Update code diff. Summary (updated) - Benchmark for Resources class (cpu, mem & port) Bugs: MESOS-5700 https://issues.apache.org/jira/browse/MESOS-5700 Repository: mesos Description (updated) --- Benchmark for Resources class (cpu, mem & port) Diffs (updated) - src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e Diff: https://reviews.apache.org/r/49381/diff/ Testing --- Thanks, Klaus Ma
