Re: Review Request 50771: Added coverity build to build_docker.sh.

2016-08-09 Thread Joerg Schad 


> On Aug. 9, 2016, 9:58 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 134
> > 
> >
> > can the email be d...@mesos.apache.org?

Done


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/#review145273
---


On Aug. 10, 2016, 12:58 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50771/
> ---
> 
> (Updated Aug. 10, 2016, 12:58 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5984
> https://issues.apache.org/jira/browse/MESOS-5984
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review adds an coverity build option
> to build_docker.sh in order to enable
> regular coverity builds on the ASF infrastructure.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 
> 
> Diff: https://reviews.apache.org/r/50771/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without COVERITY_TOKEN.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 50771: Added coverity build to build_docker.sh.

2016-08-09 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/
---

(Updated Aug. 10, 2016, 12:58 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-5984
https://issues.apache.org/jira/browse/MESOS-5984


Repository: mesos


Description
---

This review adds an coverity build option
to build_docker.sh in order to enable
regular coverity builds on the ASF infrastructure.


Diffs (updated)
-

  support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 

Diff: https://reviews.apache.org/r/50771/diff/


Testing
---

ran build with and without COVERITY_TOKEN.


Thanks,

Joerg Schad

Re: Review Request 50771: Added coverity build to build_docker.sh.

2016-08-09 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/#review145273
---


Fix it, then Ship it!





support/docker_build.sh (line 125)


space after #



support/docker_build.sh (line 128)


space after #



support/docker_build.sh (line 134)


can the email be d...@mesos.apache.org?


- Vinod Kone


On Aug. 3, 2016, 9:24 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50771/
> ---
> 
> (Updated Aug. 3, 2016, 9:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5984
> https://issues.apache.org/jira/browse/MESOS-5984
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review adds an coverity build option
> to build_docker.sh in order to enable
> regular coverity builds on the ASF infrastructure.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 
> 
> Diff: https://reviews.apache.org/r/50771/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without COVERITY_TOKEN.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 50771: Added coverity build to build_docker.sh.

2016-08-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/#review144716
---



Patch looks great!

Reviews applied: [50771]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 9:24 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50771/
> ---
> 
> (Updated Aug. 3, 2016, 9:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5984
> https://issues.apache.org/jira/browse/MESOS-5984
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review adds an coverity build option
> to build_docker.sh in order to enable
> regular coverity builds on the ASF infrastructure.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 
> 
> Diff: https://reviews.apache.org/r/50771/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without COVERITY_TOKEN.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>