Re: Review Request 51150: Cleaned up usage of namespace-qualified identifiers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51150/ --- (Updated Sept. 13, 2016, 10:21 a.m.) Review request for mesos and Michael Park. Changes --- Rebase, change review order. Repository: mesos Description --- If a file contains "using foo::bar", the remainder of the file should generally use "bar", rather than "foo::bar" (or worse, a mix of "foo::bar" and "bar"). Diffs (updated) - src/common/http.cpp 65e73235a95c1129a7e51a64077eb6ed2aee4a4b src/docker/executor.cpp f5981b080c0b81ef7025527ab26b36d7a01f009b src/linux/fs.cpp 14ae5a9089916549f691363bc2269e13c5260a14 src/local/local.cpp 1e1d246790a0d44d1baf802b903dc4f2bde1ac63 src/master/allocator/mesos/hierarchical.cpp 992031a6fbc89727725071841bd3ab827737d8bd src/master/allocator/sorter/drf/metrics.cpp c793f3216287fd40998a1d4aab016d55aa1ac151 src/master/http.cpp d8a03bfdc68157488a5cdc17d52c48c5db8be67b src/master/weights_handler.cpp 9a901e71ba2fbf2ca1c02f658a72d44cfaa5ec62 src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp dcbc499a7ac60a7be28cd889abc73155a6c1ac83 src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp ed3aa1d4c7213acfde2f63ee719edab553c9bd79 src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 822f11eab5b00c014563322a8c3b2c14cb440e0b src/slave/containerizer/mesos/isolators/xfs/disk.cpp 74ffcf5d9899c00b59958897fc9475347fd91160 src/slave/containerizer/mesos/isolators/xfs/utils.cpp e7ee466f7b5aedb08cc7b8c72f091892721ae239 src/slave/containerizer/mesos/launch.cpp b8ad27e987c7bdce800a42140be3125c594e29e8 src/slave/containerizer/mesos/provisioner/appc/cache.cpp e075e488c03d20c7b78e1969ea76e95b89fb7cfa src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c src/tests/containerizer/xfs_quota_tests.cpp d0f5032a40686af45320eeb66ea6a6a95d5b3ff6 src/tests/dynamic_weights_tests.cpp 88565d19146c9f8fc26808a62e4a67ced1b2a5f3 src/tests/files_tests.cpp 78719da5938ff0de722f8411174817f708fd41f2 src/tests/log_tests.cpp 146a2dc8d54c06fa0a885a4760c45d5a10492128 src/tests/mesos.cpp 539634eef8575a4e0091842343c29439f6d4d94c src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb src/tests/slave_recovery_tests.cpp 3c69e569d2adeab6058dde2b86d41edaa342e7b7 Diff: https://reviews.apache.org/r/51150/diff/ Testing --- make check Thanks, Neil Conway
Re: Review Request 51150: Cleaned up usage of namespace-qualified identifiers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51150/ --- (Updated Sept. 12, 2016, 2:39 p.m.) Review request for mesos and Michael Park. Changes --- Rebase. Repository: mesos Description --- If a file contains "using foo::bar", the remainder of the file should generally use "bar", rather than "foo::bar" (or worse, a mix of "foo::bar" and "bar"). Diffs (updated) - src/common/http.cpp 65e73235a95c1129a7e51a64077eb6ed2aee4a4b src/docker/executor.cpp f5981b080c0b81ef7025527ab26b36d7a01f009b src/linux/fs.cpp 14ae5a9089916549f691363bc2269e13c5260a14 src/local/local.cpp 1e1d246790a0d44d1baf802b903dc4f2bde1ac63 src/master/allocator/mesos/hierarchical.cpp 992031a6fbc89727725071841bd3ab827737d8bd src/master/allocator/sorter/drf/metrics.cpp c793f3216287fd40998a1d4aab016d55aa1ac151 src/master/http.cpp d8a03bfdc68157488a5cdc17d52c48c5db8be67b src/master/weights_handler.cpp 9a901e71ba2fbf2ca1c02f658a72d44cfaa5ec62 src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp dcbc499a7ac60a7be28cd889abc73155a6c1ac83 src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp ed3aa1d4c7213acfde2f63ee719edab553c9bd79 src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 822f11eab5b00c014563322a8c3b2c14cb440e0b src/slave/containerizer/mesos/isolators/xfs/disk.cpp 74ffcf5d9899c00b59958897fc9475347fd91160 src/slave/containerizer/mesos/isolators/xfs/utils.cpp e7ee466f7b5aedb08cc7b8c72f091892721ae239 src/slave/containerizer/mesos/launch.cpp b8ad27e987c7bdce800a42140be3125c594e29e8 src/slave/containerizer/mesos/provisioner/appc/cache.cpp e075e488c03d20c7b78e1969ea76e95b89fb7cfa src/slave/slave.cpp 2da5a2986c427250664b2bf3456039f86e5c6079 src/tests/containerizer/xfs_quota_tests.cpp d0f5032a40686af45320eeb66ea6a6a95d5b3ff6 src/tests/dynamic_weights_tests.cpp 88565d19146c9f8fc26808a62e4a67ced1b2a5f3 src/tests/files_tests.cpp 78719da5938ff0de722f8411174817f708fd41f2 src/tests/log_tests.cpp 146a2dc8d54c06fa0a885a4760c45d5a10492128 src/tests/mesos.cpp f5034f9f8de7040182e10f51be125a87b29fdd24 src/tests/mock_slave.cpp PRE-CREATION src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb src/tests/slave_recovery_tests.cpp 3c69e569d2adeab6058dde2b86d41edaa342e7b7 Diff: https://reviews.apache.org/r/51150/diff/ Testing --- make check Thanks, Neil Conway
Re: Review Request 51150: Cleaned up usage of namespace-qualified identifiers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51150/#review148490 --- Ship it! Ship It! - Michael Park On Aug. 16, 2016, 9:04 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51150/ > --- > > (Updated Aug. 16, 2016, 9:04 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > --- > > If a file contains "using foo::bar", the remainder of the file > should generally use "bar", rather than "foo::bar" (or worse, a mix > of "foo::bar" and "bar"). > > > Diffs > - > > src/common/http.cpp 65e73235a95c1129a7e51a64077eb6ed2aee4a4b > src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac > src/linux/fs.cpp 0d025d31a2947920517f9c8abfc14dd4af0c73d0 > src/local/local.cpp 1e1d246790a0d44d1baf802b903dc4f2bde1ac63 > src/master/allocator/mesos/hierarchical.cpp > 234ef98529964a0b6d3f132426a6c8ccbb1263ee > src/master/allocator/sorter/drf/metrics.cpp > c793f3216287fd40998a1d4aab016d55aa1ac151 > src/master/http.cpp 52dd80b856cf2317c0b73ba54bf501696786088d > src/master/weights_handler.cpp 9a901e71ba2fbf2ca1c02f658a72d44cfaa5ec62 > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > bebefbba7153d4b0e9a8d7179cfb642e6e802bea > src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp > 842f2b5d4037e076cac4fd9c2eeb8f69786cffa7 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 760d32bf3dc09f3b715b378f5ded41556f15fe41 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 60e849322ff755e00eced1b80adadb47bf964cbf > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > e7ee466f7b5aedb08cc7b8c72f091892721ae239 > src/slave/containerizer/mesos/launch.cpp > 2db8db5ac2f4614d406b950a1b4e8098a0d90e7b > src/slave/containerizer/mesos/provisioner/appc/cache.cpp > e075e488c03d20c7b78e1969ea76e95b89fb7cfa > src/slave/slave.cpp 0feb5c5b6498fe2627a9239b2c1aea78f1c57e49 > src/tests/containerizer/xfs_quota_tests.cpp > 243ef33686059f3ef46f0c29cc59fa2a79d4ba5b > src/tests/dynamic_weights_tests.cpp > 88565d19146c9f8fc26808a62e4a67ced1b2a5f3 > src/tests/files_tests.cpp 78719da5938ff0de722f8411174817f708fd41f2 > src/tests/log_tests.cpp 146a2dc8d54c06fa0a885a4760c45d5a10492128 > src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04 > src/tests/mock_slave.cpp PRE-CREATION > src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 > src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b > src/tests/slave_recovery_tests.cpp b6d4ae54e327ece18263e11cb7ca01fb832a5da4 > > Diff: https://reviews.apache.org/r/51150/diff/ > > > Testing > --- > > make check > > > Thanks, > > Neil Conway > >
