Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-09-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/#review148156
---



Patch looks great!

Reviews applied: [51475, 51476, 51477, 51709, 51710, 51478, 51479, 51480]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 8, 2016, 5:52 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51480/
> ---
> 
> (Updated Sept. 8, 2016, 5:52 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
> https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds tests for testing the `runTaskGroup()` handler
> on the agent.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51480/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-09-07 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/
---

(Updated Sept. 8, 2016, 5:52 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Trying to make Reviewbot happy again.


Bugs: MESOS-6076
https://issues.apache.org/jira/browse/MESOS-6076


Repository: mesos


Description (updated)
---

This change adds tests for testing the `runTaskGroup()` handler
on the agent.


Diffs (updated)
-

  src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 

Diff: https://reviews.apache.org/r/51480/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-09-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/#review148126
---



Bad patch!

Reviews applied: [51480, 51479, 51478, 51710, 51709, 51477, 51476, 51475]

Failed command: ./support/apply-review.sh -n -r 51477

Error:
2016-09-08 01:33:57 URL:https://reviews.apache.org/r/51477/diff/raw/ 
[49111/49111] -> "51477.patch" [1]
error: patch failed: src/slave/slave.cpp:2132
error: src/slave/slave.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15153/console

- Mesos ReviewBot


On Sept. 7, 2016, 10:12 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51480/
> ---
> 
> (Updated Sept. 7, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
> https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds tests for testing the `runTaskGroup()` handler
> on the agent.
> 
> Review: https://reviews.apache.org/r/51480/
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51480/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-09-07 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/
---

(Updated Sept. 7, 2016, 10:12 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-6076
https://issues.apache.org/jira/browse/MESOS-6076


Repository: mesos


Description
---

This change adds tests for testing the `runTaskGroup()` handler
on the agent.

Review: https://reviews.apache.org/r/51480/


Diffs (updated)
-

  src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 

Diff: https://reviews.apache.org/r/51480/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-09-07 Thread Anand Mazumdar 


> On Sept. 7, 2016, 5:37 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp, lines 4621-4622
> > 
> >
> > why did you need to explicitly do this here but not in the above test?

In the previous test we did not use the `MockSlave` directly but just used the 
`StartSlave()` helper. Hence, it was not needed.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/#review148037
---


On Sept. 6, 2016, 9:36 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51480/
> ---
> 
> (Updated Sept. 6, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
> https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds tests for testing the `runTaskGroup()` handler
> on the agent.
> 
> Review: https://reviews.apache.org/r/51480/
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51480/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-09-07 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/#review148037
---


Ship it!





src/tests/slave_tests.cpp (lines 4621 - 4622)


why did you need to explicitly do this here but not in the above test?


- Vinod Kone


On Sept. 6, 2016, 9:36 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51480/
> ---
> 
> (Updated Sept. 6, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
> https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds tests for testing the `runTaskGroup()` handler
> on the agent.
> 
> Review: https://reviews.apache.org/r/51480/
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51480/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-09-07 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/#review147986
---




src/tests/slave_tests.cpp (lines 4534 - 4536)


```
// Skip what `Slave::_run()` normally does, save its arguments for
// later, till reaching the critical moment when to kill the task
// in the future.
```



src/tests/slave_tests.cpp (line 4600)


s/taskgroup/task group



src/tests/slave_tests.cpp (line 4608)


4 spaces


- Guangya Liu


On 九月 6, 2016, 9:36 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51480/
> ---
> 
> (Updated 九月 6, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
> https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds tests for testing the `runTaskGroup()` handler
> on the agent.
> 
> Review: https://reviews.apache.org/r/51480/
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51480/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-09-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/#review147965
---



Patch looks great!

Reviews applied: [51475, 51476, 51477, 51478, 51479, 51480]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 6, 2016, 9:36 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51480/
> ---
> 
> (Updated Sept. 6, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
> https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds tests for testing the `runTaskGroup()` handler
> on the agent.
> 
> Review: https://reviews.apache.org/r/51480/
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51480/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-09-06 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/
---

(Updated Sept. 6, 2016, 9:36 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-6076
https://issues.apache.org/jira/browse/MESOS-6076


Repository: mesos


Description (updated)
---

This change adds tests for testing the `runTaskGroup()` handler
on the agent.

Review: https://reviews.apache.org/r/51480/


Diffs (updated)
-

  src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 

Diff: https://reviews.apache.org/r/51480/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 51480: Added tests for launching task groups on the agent.

2016-08-27 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/#review147083
---



Patch looks great!

Reviews applied: [51475, 51476, 51477, 51478, 51479, 51480]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 27, 2016, 3:45 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51480/
> ---
> 
> (Updated Aug. 27, 2016, 3:45 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
> https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds tests for testing the `runTaskGroup()` handler
> on the agent.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51480/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>