Re: Review Request 51740: Added the 'name' and 'args' field to the 'delegate' plugin's CNI config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51740/#review152343 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2016, 7:29 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51740/ > --- > > (Updated Sept. 28, 2016, 7:29 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > --- > > When the port-mapper plugin invokes the 'delegate' plugin, the CNI > config of the 'delegate' plugin needs to have the 'name' and the > 'args' fields set. We are therefore updating the config during > creation of the `PortMapper` object, and will use this config when > the 'delegate' plugin is invoked. > > > Diffs > - > > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > 0ecf64f2de5fc27f208e9dd0e3608b9a6750e9a6 > > Diff: https://reviews.apache.org/r/51740/diff/ > > > Testing > --- > > make > > > Thanks, > > Avinash sridharan > >
Re: Review Request 51740: Added the 'name' and 'args' field to the 'delegate' plugin's CNI config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51740/ --- (Updated Sept. 28, 2016, 7:29 p.m.) Review request for mesos, Jie Yu and Qian Zhang. Changes --- Rebased. Bugs: MESOS-6023 https://issues.apache.org/jira/browse/MESOS-6023 Repository: mesos Description --- When the port-mapper plugin invokes the 'delegate' plugin, the CNI config of the 'delegate' plugin needs to have the 'name' and the 'args' fields set. We are therefore updating the config during creation of the `PortMapper` object, and will use this config when the 'delegate' plugin is invoked. Diffs (updated) - src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp 0ecf64f2de5fc27f208e9dd0e3608b9a6750e9a6 Diff: https://reviews.apache.org/r/51740/diff/ Testing --- make Thanks, Avinash sridharan
Re: Review Request 51740: Added the 'name' and 'args' field to the 'delegate' plugin's CNI config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51740/ --- (Updated Sept. 12, 2016, 7:28 p.m.) Review request for mesos, Jie Yu and Qian Zhang. Changes --- Rebased. Bugs: MESOS-6023 https://issues.apache.org/jira/browse/MESOS-6023 Repository: mesos Description --- When the port-mapper plugin invokes the 'delegate' plugin, the CNI config of the 'delegate' plugin needs to have the 'name' and the 'args' fields set. We are therefore updating the config during creation of the `PortMapper` object, and will use this config when the 'delegate' plugin is invoked. Diffs (updated) - src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp 0ecf64f2de5fc27f208e9dd0e3608b9a6750e9a6 Diff: https://reviews.apache.org/r/51740/diff/ Testing --- make Thanks, Avinash sridharan
