Re: Review Request 52064: Support for multiple versions of docs.

[Benjamin Mahler]

> On Feb. 24, 2018, 12:50 a.m., Benjamin Mahler wrote:
> > Vinod and I went over this, a couple of issues:
> > 
> > * The [endpoint 
> > documentation](http://mesos.apache.org/documentation/latest/endpoints/) is 
> > only being generated for latest (see 
> > https://github.com/apache/mesos/blob/master/support/mesos-website/build.sh),
> >  this needs to be generated for each version.
> > * The C++ and Java API documentation is only being generated for latest 
> > (not sure how easy this is to fix, maybe if you also tackle this do so in a 
> > seperate patch). Also note that home.md linked directly to 
> > "/api/latest/c++" and "/api/latest/java" which means that the old versions 
> > would send users to latest c++ and java docs.
> > * We had a hard time figuring why some of the code changes were needed or 
> > what they were doing (e.g. some of the new regexes, or why the version 
> > selector drop-down has an empty value for the first entry), some comments 
> > would be helpful for the reader.
> > 
> > We were thinking the following approach would be good alternative:
> > 
> > * In order to ensure that we generate the HTTP help endpoint documentation 
> > correctly for each version, the 
> > [build.sh](https://github.com/apache/mesos/blob/master/support/mesos-website/build.sh)
> >  script would loop over each 1.x.y tag (excluding -rc#'s) and checkout the 
> > tag into a sub-directory. Within this sub-directory, we would build mesos 
> > and generate the help endpoints documentation. This sub-directory would 
> > probably be named directly as the version (e.g. "1.0.0", "1.4.1", etc).
> > * Note that for efficiency reasons (it's very expensive to build mesos for 
> > so many tags), the build.sh script would skip a tag if it finds that the 
> > publish directory already exists for the version in the mesos-site 
> > repository.
> > * The Rakefile would be updated to look at each version checkout 
> > subdirectory, and would generate the docs using the documentation folder 
> > within that specific version subdirectory.
> > * Not sure if the releases YAML still needs the docs tag, it seems so since 
> > it's used in the javascript. This would at least need to be updated so that 
> > everything before 1.0.0 is "false".
> > * Is it possible to put the version selector on the right side of the blue 
> > banner?
> 
> Tim Anderegg wrote:
> Sounds good.  I had initially avoided the C++ and Java API documentation 
> since it would take a very long time to generate, as you mention, but I'm 
> happy to tackle that as well. Limiting to 1.0.0+ will alleviate that a bit.
> 
> For the regex, the first change was just a simplification since the two 
> lines were redundant once I updated the code to use "{{ version }}" instead 
> of "latest" (I will verify that however, in case I am remembering 
> incorrectly). The second change was to account for older versions of the 
> Mesos code where "latest" was hardcoded into the HTML templates themselves, 
> which would mess up the links.  That one is already commented, but I will go 
> through and add comments wherever there may be ambiguity.  Since we are now 
> doing only 1.0.0+, this work around can probably be removed.
> 
> For the version selector, happy to move it and remove the empty option, 
> since the value should always be the currently displayed version of the 
> documentation.  I'm also not sure why I did that, it was a while ago...
> 
> For the docs tag, we could either keep it or if we want the logic to just 
> be "all versions from 1.0.0 onwards", that can be hard coded into the 
> build.sh and the HTML template, and we could remove the docs tag.  Let me 
> know what you prefer.
> 
> For the updated approach, just to make sure I'm clear:
> 
> 1) In build.sh, iterate over all tags and checkout the code into a folder 
> with the tag name, (perhaps in $WORKSPACE/mesos/_build/x.y.z/) if the primary 
> $WORKSPACE/mesos/site/publish/documentation/x.y.z folder doesn't already 
> exist.
> 2) Then the Rakefile (from $WORKSPACE/mesos, i.e. the HEAD version) is 
> used to build the docs for each version folder into the primary 
> $WORKSPACE/mesos/site/publish/documentation/x.y.z folder, as before, but only 
> if it doesn't already exist.
> 
> A few questions:
> 
> 1) I'm assuming that this build occurs in a Jenkins job that retains its 
> workspace between runs, which is why we are checking whether or not the 
> folder exists?  Or is the mesos-website publish folder the only thing that 
> persists between runs?  Just want to make sure my conception of the build 
> environment is correct, if the later is true question 2 can be ignored.
> 2) Should the script remove the checked-out code after the build runs for 
> each version that needed it?  Otherwise over time many copies of the Mesos 
> code would persist (one for each tagged version), which would be GB's in size.
> 
> Thanks!  I should be able to 

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Feb. 24, 2018, 12:50 a.m., Benjamin Mahler wrote:
> > Vinod and I went over this, a couple of issues:
> > 
> > * The [endpoint 
> > documentation](http://mesos.apache.org/documentation/latest/endpoints/) is 
> > only being generated for latest (see 
> > https://github.com/apache/mesos/blob/master/support/mesos-website/build.sh),
> >  this needs to be generated for each version.
> > * The C++ and Java API documentation is only being generated for latest 
> > (not sure how easy this is to fix, maybe if you also tackle this do so in a 
> > seperate patch). Also note that home.md linked directly to 
> > "/api/latest/c++" and "/api/latest/java" which means that the old versions 
> > would send users to latest c++ and java docs.
> > * We had a hard time figuring why some of the code changes were needed or 
> > what they were doing (e.g. some of the new regexes, or why the version 
> > selector drop-down has an empty value for the first entry), some comments 
> > would be helpful for the reader.
> > 
> > We were thinking the following approach would be good alternative:
> > 
> > * In order to ensure that we generate the HTTP help endpoint documentation 
> > correctly for each version, the 
> > [build.sh](https://github.com/apache/mesos/blob/master/support/mesos-website/build.sh)
> >  script would loop over each 1.x.y tag (excluding -rc#'s) and checkout the 
> > tag into a sub-directory. Within this sub-directory, we would build mesos 
> > and generate the help endpoints documentation. This sub-directory would 
> > probably be named directly as the version (e.g. "1.0.0", "1.4.1", etc).
> > * Note that for efficiency reasons (it's very expensive to build mesos for 
> > so many tags), the build.sh script would skip a tag if it finds that the 
> > publish directory already exists for the version in the mesos-site 
> > repository.
> > * The Rakefile would be updated to look at each version checkout 
> > subdirectory, and would generate the docs using the documentation folder 
> > within that specific version subdirectory.
> > * Not sure if the releases YAML still needs the docs tag, it seems so since 
> > it's used in the javascript. This would at least need to be updated so that 
> > everything before 1.0.0 is "false".
> > * Is it possible to put the version selector on the right side of the blue 
> > banner?

Sounds good.  I had initially avoided the C++ and Java API documentation since 
it would take a very long time to generate, as you mention, but I'm happy to 
tackle that as well. Limiting to 1.0.0+ will alleviate that a bit.

For the regex, the first change was just a simplification since the two lines 
were redundant once I updated the code to use "{{ version }}" instead of 
"latest" (I will verify that however, in case I am remembering incorrectly). 
The second change was to account for older versions of the Mesos code where 
"latest" was hardcoded into the HTML templates themselves, which would mess up 
the links.  That one is already commented, but I will go through and add 
comments wherever there may be ambiguity.  Since we are now doing only 1.0.0+, 
this work around can probably be removed.

For the version selector, happy to move it and remove the empty option, since 
the value should always be the currently displayed version of the 
documentation.  I'm also not sure why I did that, it was a while ago...

For the docs tag, we could either keep it or if we want the logic to just be 
"all versions from 1.0.0 onwards", that can be hard coded into the build.sh and 
the HTML template, and we could remove the docs tag.  Let me know what you 
prefer.

For the updated approach, just to make sure I'm clear:

1) In build.sh, iterate over all tags and checkout the code into a folder with 
the tag name, (perhaps in $WORKSPACE/mesos/_build/x.y.z/) if the primary 
$WORKSPACE/mesos/site/publish/documentation/x.y.z folder doesn't already exist.
2) Then the Rakefile (from $WORKSPACE/mesos, i.e. the HEAD version) is used to 
build the docs for each version folder into the primary 
$WORKSPACE/mesos/site/publish/documentation/x.y.z folder, as before, but only 
if it doesn't already exist.

A few questions:

1) I'm assuming that this build occurs in a Jenkins job that retains its 
workspace between runs, which is why we are checking whether or not the folder 
exists?  Or is the mesos-website publish folder the only thing that persists 
between runs?  Just want to make sure my conception of the build environment is 
correct, if the later is true question 2 can be ignored.
2) Should the script remove the checked-out code after the build runs for each 
version that needed it?  Otherwise over time many copies of the Mesos code 
would persist (one for each tagged version), which would be GB's in size.

Thanks!  I should be able to find time to do this over the next week or so.

Tim


- Tim


---
This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52064: Support for multiple versions of docs.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review198236
---



Vinod and I went over this, a couple of issues:

* The [endpoint 
documentation](http://mesos.apache.org/documentation/latest/endpoints/) is only 
being generated for latest (see 
https://github.com/apache/mesos/blob/master/support/mesos-website/build.sh), 
this needs to be generated for each version.
* The C++ and Java API documentation is only being generated for latest (not 
sure how easy this is to fix, maybe if you also tackle this do so in a seperate 
patch). Also note that home.md linked directly to "/api/latest/c++" and 
"/api/latest/java" which means that the old versions would send users to latest 
c++ and java docs.
* We had a hard time figuring why some of the code changes were needed or what 
they were doing (e.g. some of the new regexes, or why the version selector 
drop-down has an empty value for the first entry), some comments would be 
helpful for the reader.

We were thinking the following approach would be good alternative:

* In order to ensure that we generate the HTTP help endpoint documentation 
correctly for each version, the 
[build.sh](https://github.com/apache/mesos/blob/master/support/mesos-website/build.sh)
 script would loop over each 1.x.y tag (excluding -rc#'s) and checkout the tag 
into a sub-directory. Within this sub-directory, we would build mesos and 
generate the help endpoints documentation. This sub-directory would probably be 
named directly as the version (e.g. "1.0.0", "1.4.1", etc).
* Note that for efficiency reasons (it's very expensive to build mesos for so 
many tags), the build.sh script would skip a tag if it finds that the publish 
directory already exists for the version in the mesos-site repository.
* The Rakefile would be updated to look at each version checkout subdirectory, 
and would generate the docs using the documentation folder within that specific 
version subdirectory.
* Not sure if the releases YAML still needs the docs tag, it seems so since 
it's used in the javascript. This would at least need to be updated so that 
everything before 1.0.0 is "false".
* Is it possible to put the version selector on the right side of the blue 
banner?

- Benjamin Mahler


On Feb. 13, 2018, 3:44 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 13, 2018, 3:44 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the website build process to allow for documentation to be 
> generated for all versions of Mesos, based on the existing Git tags.  
> Additionally, the website is updated with a dropdown list of the available 
> versions of documentation.  If a user changes versions and the old version 
> does not have the current page, a notice will be displayed and the user 
> redirected to the home page for the desired version.
> 
> This is a temporary measure to "catchup" the documentation for the website by 
> generating docs for all previous versions.  Going forward, as each new 
> version of Mesos is released the documentation will be generated for that 
> version only.
> 
> ![Dropdown list of versions.](https://i.imgur.com/xvukEBGl.png)
> Screenshot of the dropdown list of versions.
> 
> ![404 Message](https://i.imgur.com/kqXNsxvl.png)
> Screenshot of the message displayed if a page does not exist for the selected 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml 56fd0fc7f5e34873c9b088778d77f9a6718a5933 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/7/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197432
---



Patch looks great!

Reviews applied: [52064]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 13, 2018, 3:44 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 13, 2018, 3:44 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the website build process to allow for documentation to be 
> generated for all versions of Mesos, based on the existing Git tags.  
> Additionally, the website is updated with a dropdown list of the available 
> versions of documentation.  If a user changes versions and the old version 
> does not have the current page, a notice will be displayed and the user 
> redirected to the home page for the desired version.
> 
> This is a temporary measure to "catchup" the documentation for the website by 
> generating docs for all previous versions.  Going forward, as each new 
> version of Mesos is released the documentation will be generated for that 
> version only.
> 
> ![Dropdown list of versions.](https://i.imgur.com/xvukEBGl.png)
> Screenshot of the dropdown list of versions.
> 
> ![404 Message](https://i.imgur.com/kqXNsxvl.png)
> Screenshot of the message displayed if a page does not exist for the selected 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml 56fd0fc7f5e34873c9b088778d77f9a6718a5933 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/7/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197418
---



PASS: Mesos patch 52064 was successfully built and tested.

Reviews applied: `['52064']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/52064

- Mesos Reviewbot Windows


On Feb. 13, 2018, 7:44 a.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 13, 2018, 7:44 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the website build process to allow for documentation to be 
> generated for all versions of Mesos, based on the existing Git tags.  
> Additionally, the website is updated with a dropdown list of the available 
> versions of documentation.  If a user changes versions and the old version 
> does not have the current page, a notice will be displayed and the user 
> redirected to the home page for the desired version.
> 
> This is a temporary measure to "catchup" the documentation for the website by 
> generating docs for all previous versions.  Going forward, as each new 
> version of Mesos is released the documentation will be generated for that 
> version only.
> 
> ![Dropdown list of versions.](https://i.imgur.com/xvukEBGl.png)
> Screenshot of the dropdown list of versions.
> 
> ![404 Message](https://i.imgur.com/kqXNsxvl.png)
> Screenshot of the message displayed if a page does not exist for the selected 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml 56fd0fc7f5e34873c9b088778d77f9a6718a5933 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/7/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated Feb. 13, 2018, 3:44 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Rebased and added more detailed description with screenshots.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description (updated)
---

This patch updates the website build process to allow for documentation to be 
generated for all versions of Mesos, based on the existing Git tags.  
Additionally, the website is updated with a dropdown list of the available 
versions of documentation.  If a user changes versions and the old version does 
not have the current page, a notice will be displayed and the user redirected 
to the home page for the desired version.

This is a temporary measure to "catchup" the documentation for the website by 
generating docs for all previous versions.  Going forward, as each new version 
of Mesos is released the documentation will be generated for that version only.

![Dropdown list of versions.](https://i.imgur.com/xvukEBGl.png)
Screenshot of the dropdown list of versions.

![404 Message](https://i.imgur.com/kqXNsxvl.png)
Screenshot of the message displayed if a page does not exist for the selected 
version.


Diffs (updated)
-

  site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
  site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
  site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
  site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
  site/data/releases.yml 56fd0fc7f5e34873c9b088778d77f9a6718a5933 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 


Diff: https://reviews.apache.org/r/52064/diff/7/

Changes: https://reviews.apache.org/r/52064/diff/6-7/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Benjamin Mahler]

> On Feb. 9, 2018, 6:02 p.m., Benjamin Bannier wrote:
> > I am wondering whether it wouldn't be simpler to have the site setup just 
> > generate output for the currently checked-out version and dump that into 
> > some version-specific output folder. We could then have some CI setup 
> > execute this for the different tags or branches we care about. This 
> > wouldn't only simplify the site setup, but probably also deal better with 
> > e.g., changed requirements to the base system (e.g., needed to build 
> > binaries generating the endpoint documentation) which are currently not 
> > managed in the rake file.
> > 
> > One difficulty with that approach would be to determine under what branch 
> > we are actually working on. My guess is that we wouldn't want to update to 
> > documentation of 1.3.0 until we have tagged a 1.3.0 version, so we'd likely 
> > build documentation for the n-latest tags. The `HEAD` of `master` is more 
> > tricky as it would change more frequently and not directly have a release 
> > tag as parent (these live on release branches) making it harder to work 
> > with say `git-describe`. Maybe we could parse this from source, e.g., 
> > `MESOS_VERSION` in `include/mesos/version.hpp`.
> > 
> > The other difficulty might be that we might move a lot of site-generation 
> > setup out of the repo into e.g., Jenkins config. There are probably ways to 
> > work around that, but I haven't thought that through.
> 
> Tim Anderegg wrote:
> I'm not familiar with how Jenkins is configured and used here, but your 
> approach could be simpler depending on how complex the CI build setup is.  
> This patch would remain mostly the same, except lines 68-89 of the Rakefile 
> could be removed and the git dependency would no longer be necessary.  The 
> version could then be fed in by Jenkins, which would probably be 
> easier/simpler than trying to programmatically determine the version.  Right 
> now "master" just translates to "latest" in the patch as-is.
> 
> I saw putting everything in the Rakefile as the most straightforward 
> approach, since it allows the correct versions to generate docs for to be 
> determined programmatically, avoiding the difficulty you mentioned above. 
> However, it does require generating all documentation for all versions on 
> each build, and significant changes to the build process or documentation 
> process down the road might make it difficult to maintain a 
> backwards-compatible approach (e.g. I currently disable doc generation for 
> the oldest dozen tags or so which don't have the same documentation setup, or 
> any documentation at all).

I tend to prefer the approach Benjamin's suggested above since the 
documentation generation will be versioned alongside the documentation, so that 
we don't have to deal with backwards compatibility of documentation generation 
on HEAD.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197173
---


On Feb. 9, 2018, 1:46 a.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 9, 2018, 1:46 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml e3edc308a5429585b3fc3f05564d695ba3217035 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/6/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Feb. 9, 2018, 6:02 p.m., Benjamin Bannier wrote:
> > I am wondering whether it wouldn't be simpler to have the site setup just 
> > generate output for the currently checked-out version and dump that into 
> > some version-specific output folder. We could then have some CI setup 
> > execute this for the different tags or branches we care about. This 
> > wouldn't only simplify the site setup, but probably also deal better with 
> > e.g., changed requirements to the base system (e.g., needed to build 
> > binaries generating the endpoint documentation) which are currently not 
> > managed in the rake file.
> > 
> > One difficulty with that approach would be to determine under what branch 
> > we are actually working on. My guess is that we wouldn't want to update to 
> > documentation of 1.3.0 until we have tagged a 1.3.0 version, so we'd likely 
> > build documentation for the n-latest tags. The `HEAD` of `master` is more 
> > tricky as it would change more frequently and not directly have a release 
> > tag as parent (these live on release branches) making it harder to work 
> > with say `git-describe`. Maybe we could parse this from source, e.g., 
> > `MESOS_VERSION` in `include/mesos/version.hpp`.
> > 
> > The other difficulty might be that we might move a lot of site-generation 
> > setup out of the repo into e.g., Jenkins config. There are probably ways to 
> > work around that, but I haven't thought that through.

I'm not familiar with how Jenkins is configured and used here, but your 
approach could be simpler depending on how complex the CI build setup is.  This 
patch would remain mostly the same, except lines 68-89 of the Rakefile could be 
removed and the git dependency would no longer be necessary.  The version could 
then be fed in by Jenkins, which would probably be easier/simpler than trying 
to programmatically determine the version.  Right now "master" just translates 
to "latest" in the patch as-is.

I saw putting everything in the Rakefile as the most straightforward approach, 
since it allows the correct versions to generate docs for to be determined 
programmatically, avoiding the difficulty you mentioned above. However, it does 
require generating all documentation for all versions on each build, and 
significant changes to the build process or documentation process down the road 
might make it difficult to maintain a backwards-compatible approach (e.g. I 
currently disable doc generation for the oldest dozen tags or so which don't 
have the same documentation setup, or any documentation at all).


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197173
---


On Feb. 9, 2018, 1:46 a.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 9, 2018, 1:46 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml e3edc308a5429585b3fc3f05564d695ba3217035 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/6/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197173
---



I am wondering whether it wouldn't be simpler to have the site setup just 
generate output for the currently checked-out version and dump that into some 
version-specific output folder. We could then have some CI setup execute this 
for the different tags or branches we care about. This wouldn't only simplify 
the site setup, but probably also deal better with e.g., changed requirements 
to the base system (e.g., needed to build binaries generating the endpoint 
documentation) which are currently not managed in the rake file.

One difficulty with that approach would be to determine under what branch we 
are actually working on. My guess is that we wouldn't want to update to 
documentation of 1.3.0 until we have tagged a 1.3.0 version, so we'd likely 
build documentation for the n-latest tags. The `HEAD` of `master` is more 
tricky as it would change more frequently and not directly have a release tag 
as parent (these live on release branches) making it harder to work with say 
`git-describe`. Maybe we could parse this from source, e.g., `MESOS_VERSION` in 
`include/mesos/version.hpp`.

The other difficulty might be that we might move a lot of site-generation setup 
out of the repo into e.g., Jenkins config. There are probably ways to work 
around that, but I haven't thought that through.

- Benjamin Bannier


On Feb. 9, 2018, 2:46 a.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 9, 2018, 2:46 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml e3edc308a5429585b3fc3f05564d695ba3217035 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/6/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197165
---



Bad patch!

Reviews applied: [52064]

Failed command: python support/apply-reviews.py -n -r 52064

Error:
2018-02-09 15:06:42 URL:https://reviews.apache.org/r/52064/diff/raw/ 
[13073/13073] -> "52064.patch" [1]
error: patch failed: site/data/releases.yml:154
error: site/data/releases.yml: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/21583/console

- Mesos Reviewbot


On Feb. 9, 2018, 1:46 a.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 9, 2018, 1:46 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml e3edc308a5429585b3fc3f05564d695ba3217035 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/6/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197144
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 52064`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/52064

Relevant logs:

- 
[apply-review-52064-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/52064/logs/apply-review-52064-stdout.log):

```
error: patch failed: site/data/releases.yml:154
error: site/data/releases.yml: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 9, 2018, 1:46 a.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 9, 2018, 1:46 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml e3edc308a5429585b3fc3f05564d695ba3217035 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/6/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated Feb. 9, 2018, 1:46 a.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Rebased against latest


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
  site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
  site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
  site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
  site/data/releases.yml e3edc308a5429585b3fc3f05564d695ba3217035 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 


Diff: https://reviews.apache.org/r/52064/diff/6/

Changes: https://reviews.apache.org/r/52064/diff/5-6/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review185249
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 52064`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/52064

Relevant logs:

- 
[apply-review-52064-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/52064/logs/apply-review-52064-stdout.log):
```error: patch failed: site/Gemfile:8
error: site/Gemfile: patch does not apply
error: patch failed: site/Gemfile.lock:1
error: site/Gemfile.lock: patch does not apply
error: patch failed: site/data/releases.yml:112
error: site/data/releases.yml: patch does not apply
```

- Mesos Reviewbot Windows


On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:23 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/5/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Vinod Kone]

Great. I'll be there too!

On Tue, Sep 12, 2017 at 11:59 AM, Tim Anderegg 
wrote:

>
>
> > On May 9, 2017, 4:30 p.m., haosdent huang wrote:
> > > Hi, @tim Thanks a lot for your update. I am still reading you patch
> and have not finished. Could return my comments if it works at my side.
> Thanks a lot for your contributions.
> >
> > Tim Anderegg wrote:
> > Thanks @haosdent, please let me know if you have any questions or
> need clarification on anything!
> >
> > Vinod Kone wrote:
> > Any further updates on this? @haosdent can you commit this now?
>
> @haosdent @vinodkone This probably at least needs a rebase, but
> functionally speaking everything should be in working order.  I'll be at
> the hackathon at MesosCon tomorrow, if folks want to work on closing this
> out!
>
>
> - Tim
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/#review174335
> ---
>
>
> On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/52064/
> > ---
> >
> > (Updated May 5, 2017, 9:23 p.m.)
> >
> >
> > Review request for mesos, haosdent huang and Vinod Kone.
> >
> >
> > Bugs: MESOS-3011
> > https://issues.apache.org/jira/browse/MESOS-3011
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > ---
> >
> > Support for multiple versions of docs.
> >
> >
> > Diffs
> > -
> >
> >   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807
> >   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf
> >   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b
> >   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
> >   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac
> >   site/source/assets/js/versions.js PRE-CREATION
> >   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6
> >
> >
> > Diff: https://reviews.apache.org/r/52064/diff/5/
> >
> >
> > Testing
> > ---
> >
> > Testing was done manually to verify that the documentation was built for
> each version of Mesos that is supported (some older versions do not have
> compatible documentation).
> >
> >
> > Thanks,
> >
> > Tim Anderegg
> >
> >
>
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On May 9, 2017, 4:30 p.m., haosdent huang wrote:
> > Hi, @tim Thanks a lot for your update. I am still reading you patch and 
> > have not finished. Could return my comments if it works at my side. Thanks 
> > a lot for your contributions.
> 
> Tim Anderegg wrote:
> Thanks @haosdent, please let me know if you have any questions or need 
> clarification on anything!
> 
> Vinod Kone wrote:
> Any further updates on this? @haosdent can you commit this now?

@haosdent @vinodkone This probably at least needs a rebase, but functionally 
speaking everything should be in working order.  I'll be at the hackathon at 
MesosCon tomorrow, if folks want to work on closing this out!


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review174335
---


On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:23 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/5/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Vinod Kone]

> On May 9, 2017, 4:30 p.m., haosdent huang wrote:
> > Hi, @tim Thanks a lot for your update. I am still reading you patch and 
> > have not finished. Could return my comments if it works at my side. Thanks 
> > a lot for your contributions.
> 
> Tim Anderegg wrote:
> Thanks @haosdent, please let me know if you have any questions or need 
> clarification on anything!

Any further updates on this? @haosdent can you commit this now?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review174335
---


On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:23 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/5/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On May 9, 2017, 4:30 p.m., haosdent huang wrote:
> > Hi, @tim Thanks a lot for your update. I am still reading you patch and 
> > have not finished. Could return my comments if it works at my side. Thanks 
> > a lot for your contributions.

Thanks @haosdent, please let me know if you have any questions or need 
clarification on anything!


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review174335
---


On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:23 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/5/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review174335
---



Hi, @tim Thanks a lot for your update. I am still reading you patch and have 
not finished. Could return my comments if it works at my side. Thanks a lot for 
your contributions.

- haosdent huang


On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:23 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/5/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review174121
---



Patch looks great!

Reviews applied: [52064]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:23 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/5/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated May 5, 2017, 9:23 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Removed file that only had whitespace changes.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 


Diff: https://reviews.apache.org/r/52064/diff/5/

Changes: https://reviews.apache.org/r/52064/diff/4-5/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated May 5, 2017, 9:20 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Got rid of build.sh phantom change for real this time.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 


Diff: https://reviews.apache.org/r/52064/diff/4/

Changes: https://reviews.apache.org/r/52064/diff/3-4/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> > site/Rakefile
> > Lines 122 (patched)
> > 
> >
> > Replace all `\/latest\/` looks a bit dangerous. Do you have an example 
> > for this?
> 
> Tim Anderegg wrote:
> I ran the code across the documentation from a number of versions, and 
> determined that the only place the \/latest\/ string occurred was in URL's 
> that should be replaced, e.g. here: 
> https://raw.githubusercontent.com/apache/mesos/0.22.1/docs/home.md

Well, you were right :)  There were a few edge cases where this was too gready, 
so I updated the regex to be more restrictive.


> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> > site/data/releases.yml
> > Lines 108 (patched)
> > 
> >
> > I think we only need to keep the version `>=0.26.0`. This reduce the 
> > website generation time as well.
> 
> Tim Anderegg wrote:
> I'm happy to remove the older versions if desired.

I went with >=0.22.1, since that is the oldest tag on the apache/mesos github 
repo.  If we should just go with 0.26.0, I can do that instead.


> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> > site/source/assets/css/main.css
> > Lines 39-41 (patched)
> > 
> >
> > Could not find the differece for this css change. Is it necessary?
> 
> Tim Anderegg wrote:
> This was to better space the  tag used to select the proper 
> version that is part of the breadcrumb.  Without it, the alignement is off.

Actually, you were right this was not needed, sorry!


> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> > site/source/layouts/gettingstarted.erb
> > Lines 1 (patched)
> > 
> >
> > This layout file is unused, right?
> 
> Tim Anderegg wrote:
> It is unused in recent versions, but was used in older versions.  Since 
> the most recent "layouts" folder is used for rendering all versions of the 
> documentation after the generation process, it must contain all past layouts 
> or else the renderer will produce an error.

Now that we are only doing versions >= 0.22.1, this is no longer needed.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review160091
---


On May 5, 2017, 9:16 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:16 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/3/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated May 5, 2017, 9:16 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

OK, I believe I have addressed all issues here, I also simplified the code a 
bit to use releases.yml as the source of versions to generate docs for, rather 
than the git tags themselves, and made the "docs:" key optional in that file.  
It only needs to be present if the given version should not have documentation 
generated for it, in which case it is set as "docs: false".  This also removes 
the need for the version check within the Rakefile itself.  Please let me know 
if any additional changes are needed.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 


Diff: https://reviews.apache.org/r/52064/diff/3/

Changes: https://reviews.apache.org/r/52064/diff/2-3/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> >

Sorry for the long delay on this, I've finally carved up some time to try and 
close this out.  I've left some comments below, and am working on addressing 
the issues, I will update the review tomorrow with the final result, hopefully 
addressing all issues raised.  Thansk!


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review160091
---


On May 4, 2017, 9:26 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 4, 2017, 9:26 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/2/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated May 4, 2017, 9:26 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs
-

  site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
  site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 
  site/source/layouts/gettingstarted.erb PRE-CREATION 


Diff: https://reviews.apache.org/r/52064/diff/2/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review167537
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 12, 2016, 10:03 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Dec. 12, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/2/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review160091
---




site/Rakefile (line 23)


puts "Updating documentations from the Apache Mesos codebase"



site/Rakefile (line 28)


`git = Git.open('..')`



site/Rakefile (line 29)


`origin_branch` is a better name for what this variable used for?



site/Rakefile (line 32)


I think need to select it from releases.yml



site/Rakefile (line 44)


Move this into the function.



site/Rakefile (line 88)


`def generate_docs`



site/Rakefile (lines 88 - 129)


Since this function only used in task `task :update_docs`, let's move this 
into 

```
task :update_docs do
...
```



site/Rakefile (lines 120 - 121)


This is not match the original code.



site/Rakefile (line 122)


Replace all `\/latest\/` looks a bit dangerous. Do you have an example for 
this?



site/build.sh (line 25)


I think should not include this file?



site/config.rb (lines 47 - 50)


Hmm, could not get the point that why need to change here?

I think `"./source/documentation/latest/*.md"` have already find all files 
in `latest`? I could not find any subfolder under `latest` so far.



site/data/releases.yml (lines 104 - 105)


How about change "Some older versions do not have documentation, and 
sometimes there may be tags for versions that are not yet released."
to "This requires the associate tag exists in git repository."



site/data/releases.yml (line 108)


I think we only need to keep the version `>=0.26.0`. This reduce the 
website generation time as well.



site/source/assets/css/main.css (lines 39 - 41)


Could not find the differece for this css change. Is it necessary?



site/source/assets/js/versions.js (line 4)


we use `pathRegex` style in javascript. Please update following names.



site/source/assets/js/versions.js (line 14)


Add peroid at the end of comment.



site/source/assets/js/versions.js (line 22)


Add `;` at the end of this line.



site/source/assets/js/versions.js (line 24)


Add `;` at the end.



site/source/assets/js/versions.js (lines 27 - 37)


I think we could remove this part after we only list versions greater than 
0.26.0 .



site/source/assets/js/versions.js (line 39)


`window.location.href = path;`



site/source/layouts/documentation.erb (line 16)


Do you think `Back` is necessary here? Since we could click `<-` button in 
the browser.



site/source/layouts/gettingstarted.erb (line 1)


This layout file is unused, right?


- haosdent huang


On Dec. 12, 2016, 10:03 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Dec. 12, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review158952
---



Patch looks great!

Reviews applied: [52064]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Dec. 12, 2016, 10:03 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Dec. 12, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated Dec. 12, 2016, 10:03 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Addressed issues raised below, sorry about the delay on resolving them!  Life 
has been getting in the way recently :)


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description (updated)
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
  site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 
  site/source/layouts/gettingstarted.erb PRE-CREATION 

Diff: https://reviews.apache.org/r/52064/diff/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/source/layouts/basic.erb, line 79
> > 
> >
> > We need to make sure the style of verson selection here to match the 
> > breadcrumb above.
> > 
> > ```
> > 
> > 
> > ```
> > 
> > Another options are
> > 
> > * we put it in the left panel. Like what tensorflow document do. 
> > https://www.tensorflow.org/versions/r0.10/get_started/index.html
> > * we list all available version in a separate page. Like what spark 
> > document do. http://spark.apache.org/documentation.html
> 
> Tim Anderegg wrote:
> I originally had the version in the left panel, but it seemed a bit 
> awkwardly placed there, and it seemed to me putting it in the breadcrumbs was 
> more natural (in Tensorflow's it makes sense, as the left panel is a 
> navigation menu).  I think it's best to have the version dropdown accessible 
> on each page rather than a separate page, as that is more convenient for 
> users.  I'll try cleaning up the style to match and we can see how that looks.

I updated the style here to match the navigration pane better, I think this is 
the best approach but let me know what you think.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150674
---


On Dec. 12, 2016, 10:03 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Dec. 12, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review152043
---



what's the status of this?

- Vinod Kone


On Sept. 28, 2016, 9:22 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 28, 2016, 9:22 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[haosdent huang]

> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/source/layouts/documentation.erb, lines 15-19
> > 
> >
> > Any reason that we add a back button instead of using the back button 
> > of browser?
> 
> Tim Anderegg wrote:
> This was because I often ran into the case that, when switching doc 
> versions, I hit the browser's back button which returned me to the last 
> version I was on instead of the new version.  The "back" link is there to 
> quickly return to the main documentation page for whatever version the user 
> is currently viewing, and to discourage the use of the browser back button in 
> this case.  I could update the text to "Return to Documentation Home" or 
> something along those lines, or I could just remove it as this is probably an 
> edge case anyways.

Cool, thank you for explanation.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150674
---


On Sept. 28, 2016, 9:22 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 28, 2016, 9:22 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Sept. 28, 2016, 3:20 a.m., haosdent huang wrote:
> > Get this error during build.
> > 
> > ```
> > git  version   2>&1:sh: git: command not found
> > /mesos/site/Rakefile:4:in `'
> > (See full trace by running task with --trace)
> > rake aborted!
> > git  version   2>&1:sh: git: command not found
> > /mesos/site/Rakefile:4:in `'
> > (See full trace by running task with --trace)
> > ```
> 
> haosdent huang wrote:
> Need to update the Dockerfile to fix this problem.
> 
> ```
> diff --git a/site/Dockerfile b/site/Dockerfile
> index 8ba0be0..835e7df 100644
> --- a/site/Dockerfile
> +++ b/site/Dockerfile
> @@ -3,7 +3,7 @@ MAINTAINER "d...@mesos.apache.org"
> 
>  LABEL Description="This image is used for generating Mesos web site from 
> local sources and serving it on port 4567 (livereload on port 35729)."
> 
> -RUN yum install -y gcc-c++ make ruby ruby-devel rake doxygen 
> java-1.7.0-openjdk-devel
> +RUN yum install -y gcc-c++ git make ruby ruby-devel rake doxygen 
> java-1.7.0-openjdk-devel
>  RUN gem install bundler
> 
>  ENV LANG en_US.UTF-8
> ```

Good catch, I didn't use Docker for building so I already had git installed, 
will fix.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150673
---


On Sept. 19, 2016, 8:43 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 19, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/Rakefile, lines 67-71
> > 
> >
> > How about we only continue when tags in `["0.26.0", "0.26.."]`?

This list of versions that don't have documentation in their repos shouldn't 
ever change.  If we filtered affirmatively by the versions that do have 
documentation, it would have to be updated each time a new version is added.  
So the current approach here seems easier to maintain, but I'm certainly open 
to suggestion!


> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/build.sh, line 24
> > 
> >
> > I think we no need to change this file, right?

Not sure why this is showing up in the diff, will attempt to remove it.


> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/source/layouts/basic.erb, line 79
> > 
> >
> > We need to make sure the style of verson selection here to match the 
> > breadcrumb above.
> > 
> > ```
> > 
> > 
> > ```
> > 
> > Another options are
> > 
> > * we put it in the left panel. Like what tensorflow document do. 
> > https://www.tensorflow.org/versions/r0.10/get_started/index.html
> > * we list all available version in a separate page. Like what spark 
> > document do. http://spark.apache.org/documentation.html

I originally had the version in the left panel, but it seemed a bit awkwardly 
placed there, and it seemed to me putting it in the breadcrumbs was more 
natural (in Tensorflow's it makes sense, as the left panel is a navigation 
menu).  I think it's best to have the version dropdown accessible on each page 
rather than a separate page, as that is more convenient for users.  I'll try 
cleaning up the style to match and we can see how that looks.


> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/source/layouts/documentation.erb, lines 15-19
> > 
> >
> > Any reason that we add a back button instead of using the back button 
> > of browser?

This was because I often ran into the case that, when switching doc versions, I 
hit the browser's back button which returned me to the last version I was on 
instead of the new version.  The "back" link is there to quickly return to the 
main documentation page for whatever version the user is currently viewing, and 
to discourage the use of the browser back button in this case.  I could update 
the text to "Return to Documentation Home" or something along those lines, or I 
could just remove it as this is probably an edge case anyways.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150674
---


On Sept. 19, 2016, 8:43 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 19, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the 

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150702
---



Patch looks great!

Reviews applied: [52064]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 19, 2016, 8:43 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 19, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[haosdent huang]

> On Sept. 28, 2016, 3:20 a.m., haosdent huang wrote:
> > Get this error during build.
> > 
> > ```
> > git  version   2>&1:sh: git: command not found
> > /mesos/site/Rakefile:4:in `'
> > (See full trace by running task with --trace)
> > rake aborted!
> > git  version   2>&1:sh: git: command not found
> > /mesos/site/Rakefile:4:in `'
> > (See full trace by running task with --trace)
> > ```

Need to update the Dockerfile to fix this problem.

```
diff --git a/site/Dockerfile b/site/Dockerfile
index 8ba0be0..835e7df 100644
--- a/site/Dockerfile
+++ b/site/Dockerfile
@@ -3,7 +3,7 @@ MAINTAINER "d...@mesos.apache.org"

 LABEL Description="This image is used for generating Mesos web site from local 
sources and serving it on port 4567 (livereload on port 35729)."

-RUN yum install -y gcc-c++ make ruby ruby-devel rake doxygen 
java-1.7.0-openjdk-devel
+RUN yum install -y gcc-c++ git make ruby ruby-devel rake doxygen 
java-1.7.0-openjdk-devel
 RUN gem install bundler

 ENV LANG en_US.UTF-8
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150673
---


On Sept. 19, 2016, 8:43 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 19, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150674
---




site/Rakefile (lines 35 - 39)


How about we only continue when tags in `["0.26.0", "0.26.."]`?



site/Rakefile (line 93)


indent incorrect here.



site/build.sh (line 24)


I think we no need to change this file, right?



site/source/layouts/basic.erb (line 79)


We need to make sure the style of verson selection here to match the 
breadcrumb above.

```


```

Another options are

* we put it in the left panel. Like what tensorflow document do. 
https://www.tensorflow.org/versions/r0.10/get_started/index.html
* we list all available version in a separate page. Like what spark 
document do. http://spark.apache.org/documentation.html



site/source/layouts/documentation.erb (lines 15 - 19)


Any reason that we add a back button instead of using the back button of 
browser?


- haosdent huang


On Sept. 19, 2016, 8:43 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 19, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150673
---



Get this error during build.

```
git  version   2>&1:sh: git: command not found
/mesos/site/Rakefile:4:in `'
(See full trace by running task with --trace)
rake aborted!
git  version   2>&1:sh: git: command not found
/mesos/site/Rakefile:4:in `'
(See full trace by running task with --trace)
```

- haosdent huang


On Sept. 19, 2016, 8:43 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 19, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated Sept. 19, 2016, 8:43 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description (updated)
---

Support for multiple versions of docs.  The approach I took was to use the 
"git" ruby library to iterate over each tagged version of Mesos, and generate 
the documentation.  This uses the "releases.yml" file to determine which 
versions should build documentation.  The same is done for images, since they 
may change between versions.  A select box was added to the website's 
breadcrumbs bar that allows the user to easily switch between documentation 
versions.  If a page is reached that doesn't exist in an older version of the 
documentation, the user is notified and redirect to the main page for that 
version.


Diffs
-

  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 
  site/source/layouts/gettingstarted.erb PRE-CREATION 

Diff: https://reviews.apache.org/r/52064/diff/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg