Re: Review Request 52462: Ported ReviewBot script to Windows.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52462/
---

(Updated Oct. 4, 2016, 1:29 p.m.)


Review request for mesos, Benjamin Hindman, Daniel Pravat, Artem Harutyunyan, 
Alex Clemmer, and Vinod Kone.


Repository: mesos


Description
---

Changes which script ReviewBot uses to apply reviews and 
what script ReviewBot runs if on Windows.


Diffs
-

  support/verify_reviews.py f14951b753ffbc1a939d1991d7bb901741efe388 

Diff: https://reviews.apache.org/r/52462/diff/


Testing (updated)
---

On Windows:
python support/verify_reviews.py a b 1
// ^ Fake username and password, so as to not post any reviews.

Tested successful build and unsuccessful build (introduced a syntax error in 
libprocess).

---

TODO:
Wait for this: https://issues.apache.org/jira/browse/INFRA-12681
Then test run: https://builds.apache.org/job/Mesos-Windows-Reviewbot/


Thanks,

Joseph Wu

Re: Review Request 52462: Ported ReviewBot script to Windows.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52462/#review151252
---


Fix it, then Ship it!





support/verify_reviews.py (line 178)


s/print the error/print the output/


- Vinod Kone


On Oct. 1, 2016, 12:34 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52462/
> ---
> 
> (Updated Oct. 1, 2016, 12:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Daniel Pravat, Artem Harutyunyan, 
> Alex Clemmer, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes which script ReviewBot uses to apply reviews and 
> what script ReviewBot runs if on Windows.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py f14951b753ffbc1a939d1991d7bb901741efe388 
> 
> Diff: https://reviews.apache.org/r/52462/diff/
> 
> 
> Testing
> ---
> 
> On Windows:
> python support/verify_reviews.py a b 1
> // ^ Fake username and password, so as to not post any reviews.
> 
> Tested successful build and unsuccessful build (introduced a syntax error in 
> libprocess).
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 52462: Ported ReviewBot script to Windows.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52462/#review15
---



Bad patch!

Reviews applied: [52462, 52461]

Failed command: ./support/apply-review.sh -n -r 52462

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 331, in 
reviewboard()
  File "support/apply-reviews.py", line 310, in reviewboard
apply_review()
  File "support/apply-reviews.py", line 121, in apply_review
fetch_patch()
  File "support/apply-reviews.py", line 128, in fetch_patch
ctx = ssl.create_default_context()
AttributeError: 'module' object has no attribute 'create_default_context'
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
  File "support/apply-reviews.py", line 119, in 
atexit.register(lambda: os.remove('%s.patch' % patch_id()))
OSError: [Errno 2] No such file or directory: '52462.patch'
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
  File "support/apply-reviews.py", line 119, in 
atexit.register(lambda: os.remove('%s.patch' % patch_id()))
OSError: [Errno 2] No such file or directory: '52462.patch'

Full log: https://builds.apache.org/job/mesos-reviewbot/15476/console

- Mesos ReviewBot


On Oct. 1, 2016, 12:34 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52462/
> ---
> 
> (Updated Oct. 1, 2016, 12:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Daniel Pravat, Artem Harutyunyan, 
> Alex Clemmer, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes which script ReviewBot uses to apply reviews and 
> what script ReviewBot runs if on Windows.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py f14951b753ffbc1a939d1991d7bb901741efe388 
> 
> Diff: https://reviews.apache.org/r/52462/diff/
> 
> 
> Testing
> ---
> 
> On Windows:
> python support/verify_reviews.py a b 1
> // ^ Fake username and password, so as to not post any reviews.
> 
> Tested successful build and unsuccessful build (introduced a syntax error in 
> libprocess).
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>