Re: Review Request 52624: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder.

2016-10-18 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52624/#review153052
---



Bad patch!

Reviews applied: [52624, 52625, 52972, 52544, 52364, 52210, 52192]

Failed command: ./support/apply-review.sh -n -r 52624

Error:
2016-10-18 08:08:06 URL:https://reviews.apache.org/r/52624/diff/raw/ 
[6801/6801] -> "52624.patch" [1]
error: patch failed: cmake/CompilationConfigure.cmake:97
error: cmake/CompilationConfigure.cmake: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15712/console

- Mesos ReviewBot


On Oct. 18, 2016, 2:46 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52624/
> ---
> 
> (Updated Oct. 18, 2016, 2:46 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On POSIX this should have no effect.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 
>   src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 
>   src/health-check/health_checker.cpp 
> 96ae1a733ff3d211b84d0893b4603873af1c89f0 
>   src/slave/containerizer/fetcher.cpp 
> 11104d66e6dd05d8eb1d37a2e3250aca19278110 
>   src/slave/containerizer/mesos/containerizer.cpp 
> eac70d955e08142a2d054039d610a3d516b1b57e 
>   src/slave/containerizer/mesos/launch.hpp 
> f8bac0650965a49562b9910bf6140ded8dbb69ac 
>   src/slave/containerizer/mesos/launch.cpp 
> 8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 
>   src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 
>   src/slave/status_update_manager.cpp 
> 056a684b52756d5c6309e7e2167a1532c4e60957 
> 
> Diff: https://reviews.apache.org/r/52624/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>



Re: Review Request 52624: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder.

2016-10-17 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52624/
---

(Updated Oct. 18, 2016, 2:46 a.m.)


Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael 
Park.


Repository: mesos


Description
---

On POSIX this should have no effect.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 
  src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 
  src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0 
  src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 
  src/slave/containerizer/mesos/containerizer.cpp 
eac70d955e08142a2d054039d610a3d516b1b57e 
  src/slave/containerizer/mesos/launch.hpp 
f8bac0650965a49562b9910bf6140ded8dbb69ac 
  src/slave/containerizer/mesos/launch.cpp 
8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 
  src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 
  src/slave/status_update_manager.cpp 056a684b52756d5c6309e7e2167a1532c4e60957 

Diff: https://reviews.apache.org/r/52624/diff/


Testing
---


Thanks,

Daniel Pravat