Re: Review Request 54013: Added user doc for nested container and task group.

2017-01-03 Thread Gilbert Song 


> On Dec. 4, 2016, 11:44 a.m., Vinod Kone wrote:
> > docs/nested-container-and-task-group.md, line 209
> > 
> >
> > mention that only 2 levels of nesting is supported as of 1.1?
> 
> Gilbert Song wrote:
> We already support arbitrary nested levels. There is a unit test 
> (`ROOT_CGROUPS_LaunchNestedThreeLevels`) for that support.
> 
> Adam B wrote:
> And yet 
> https://github.com/apache/mesos/blob/1.1.0/src/slave/http.cpp#L1929 says
> "We do not yet support launching containers that are nested two levels 
> beneath the executor's container."
> and errors if you try to launch a nested container with a grandparent.

Fixed on a followup patch.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157928
---


On Dec. 6, 2016, 8:28 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Dec. 6, 2016, 8:28 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, 
> Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-07 Thread Adam B 


> On Dec. 4, 2016, 11:44 a.m., Vinod Kone wrote:
> > docs/nested-container-and-task-group.md, line 209
> > 
> >
> > mention that only 2 levels of nesting is supported as of 1.1?
> 
> Gilbert Song wrote:
> We already support arbitrary nested levels. There is a unit test 
> (`ROOT_CGROUPS_LaunchNestedThreeLevels`) for that support.

And yet https://github.com/apache/mesos/blob/1.1.0/src/slave/http.cpp#L1929 says
"We do not yet support launching containers that are nested two levels beneath 
the executor's container."
and errors if you try to launch a nested container with a grandparent.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157928
---


On Dec. 6, 2016, 8:28 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Dec. 6, 2016, 8:28 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, 
> Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-07 Thread Gilbert Song 


> On Dec. 6, 2016, 6:06 p.m., Neil Conway wrote:
> > This should be linked from elsewhere in the docs. e.g., `home.md`.

Ah, I will fix it in the followup patch. Thanks, Neil!


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review158288
---


On Dec. 6, 2016, 8:28 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Dec. 6, 2016, 8:28 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, 
> Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-06 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review158288
---



This should be linked from elsewhere in the docs. e.g., `home.md`.

- Neil Conway


On Dec. 6, 2016, 4:28 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Dec. 6, 2016, 4:28 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, 
> Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-06 Thread Gilbert Song 


> On Dec. 6, 2016, 9:23 a.m., Jie Yu wrote:
> > docs/nested-container-and-task-group.md, line 125
> > 
> >
> > Can you follow up to update mesos-containerizer.md to include this 
> > isolator and provide a link here?

yes, I can do that.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review158186
---


On Dec. 6, 2016, 8:28 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Dec. 6, 2016, 8:28 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, 
> Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-06 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review158186
---


Fix it, then Ship it!





docs/nested-container-and-task-group.md (line 125)


Can you follow up to update mesos-containerizer.md to include this isolator 
and provide a link here?


- Jie Yu


On Dec. 6, 2016, 4:28 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Dec. 6, 2016, 4:28 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, 
> Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-06 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/
---

(Updated Dec. 6, 2016, 8:28 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, 
Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.


Bugs: MESOS-6335
https://issues.apache.org/jira/browse/MESOS-6335


Repository: mesos


Description
---

Added user doc for nested container and task group.


Diffs (updated)
-

  docs/nested-container-and-task-group.md PRE-CREATION 

Diff: https://reviews.apache.org/r/54013/diff/


Testing
---

Tested by gist view. Here is the link:

https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md


Thanks,

Gilbert Song

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-06 Thread Gilbert Song 


> On Dec. 4, 2016, 11:44 a.m., Vinod Kone wrote:
> > docs/nested-container-and-task-group.md, line 209
> > 
> >
> > mention that only 2 levels of nesting is supported as of 1.1?

We already support arbitrary nested levels. There is a unit test 
(`ROOT_CGROUPS_LaunchNestedThreeLevels`) for that support.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157928
---


On Nov. 30, 2016, 11:11 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Nov. 30, 2016, 11:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian 
> Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-06 Thread Gilbert Song 


> On Dec. 4, 2016, 10:11 a.m., Anand Mazumdar wrote:
> > Gilbert, can you add [~neilc] as a reviewer too?

Thanks, Anand!


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157927
---


On Nov. 30, 2016, 11:11 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Nov. 30, 2016, 11:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian 
> Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-04 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157928
---


Fix it, then Ship it!




LGTM.


docs/nested-container-and-task-group.md (line 28)


this does not sound like they have the same life cycle?



docs/nested-container-and-task-group.md (line 41)


abstractions



docs/nested-container-and-task-group.md (line 70)


Both authorized operators and executors...



docs/nested-container-and-task-group.md (line 105)


Maybe link to 
https://github.com/apache/mesos/blob/master/docs/app-framework-development-guide.md
 for details about default executor?



docs/nested-container-and-task-group.md (line 209)


mention that only 2 levels of nesting is supported as of 1.1?


- Vinod Kone


On Nov. 30, 2016, 7:11 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Nov. 30, 2016, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian 
> Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-04 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157927
---



Gilbert, can you add [~neilc] as a reviewer too?

- Anand Mazumdar


On Nov. 30, 2016, 7:11 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Nov. 30, 2016, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian 
> Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-12-04 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157926
---




docs/nested-container-and-task-group.md (line 303)


Why we refer aurora document here? Since could not find anything associated 
with POD in this link.


- haosdent huang


On Nov. 30, 2016, 7:11 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Nov. 30, 2016, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian 
> Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-11-30 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/
---

(Updated Nov. 30, 2016, 11:11 a.m.)


Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian 
Zhang, and Vinod Kone.


Changes
---

Rebase to master head.


Bugs: MESOS-6335
https://issues.apache.org/jira/browse/MESOS-6335


Repository: mesos


Description
---

Added user doc for nested container and task group.


Diffs (updated)
-

  docs/nested-container-and-task-group.md PRE-CREATION 

Diff: https://reviews.apache.org/r/54013/diff/


Testing
---

Tested by gist view. Here is the link:

https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md


Thanks,

Gilbert Song

Re: Review Request 54013: Added user doc for nested container and task group.

2016-11-25 Thread Qian Zhang 


> On Nov. 24, 2016, 2:41 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md, line 209
> > 
> >
> > Currently we only support a single level of container nesting, right? 
> > If so, then I think we may need to mention this limitation here, and also 
> > mention we will support multiple level of container netsting in the section 
> > of `Future Work`.
> 
> Gilbert Song wrote:
> We already supported the multi-level nested container. We have a simple 
> unit test `ROOT_CGROUPS_LaunchNestedThreeLevels` for three-level nested. 
> Technically, arbitrary level nested up to 32 should work.

Thanks Gilbert for the clarification! I think the following code confused me:
https://github.com/apache/mesos/blob/1.1.0/src/slave/http.cpp#L1933:L1934

Now I understand we do support multi-level nested container, but the nested 
container can only be created level by level rather than across levels.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review156819
---


On Nov. 25, 2016, 4:36 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Nov. 25, 2016, 4:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian 
> Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-11-25 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/
---

(Updated Nov. 25, 2016, 12:36 a.m.)


Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian 
Zhang, and Vinod Kone.


Bugs: MESOS-6335
https://issues.apache.org/jira/browse/MESOS-6335


Repository: mesos


Description
---

Added user doc for nested container and task group.


Diffs (updated)
-

  docs/nested-container-and-task-group.md PRE-CREATION 

Diff: https://reviews.apache.org/r/54013/diff/


Testing
---

Tested by gist view. Here is the link:

https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md


Thanks,

Gilbert Song

Re: Review Request 54013: Added user doc for nested container and task group.

2016-11-25 Thread Gilbert Song 


> On Nov. 23, 2016, 10:41 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md, line 166
> > 
> >
> > Indent, it seems a space is missed here.

Good catch, Qian.


> On Nov. 23, 2016, 10:41 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md, line 209
> > 
> >
> > Currently we only support a single level of container nesting, right? 
> > If so, then I think we may need to mention this limitation here, and also 
> > mention we will support multiple level of container netsting in the section 
> > of `Future Work`.

We already supported the multi-level nested container. We have a simple unit 
test `ROOT_CGROUPS_LaunchNestedThreeLevels` for three-level nested. 
Technically, arbitrary level nested up to 32 should work.


> On Nov. 23, 2016, 10:41 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md, line 297
> > 
> >
> > Does this refer to multiple level of container nesting or something 
> > else?

The task group api is different from the nested container api. We may want to 
support launching multiple task groups using `LaunchGroup` api in the future.


> On Nov. 23, 2016, 10:41 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md, line 213
> > 
> >
> > I see here you have illustrated `NESTED_CONTAINER_LAUNCH` and 
> > `NESTED_CONTAINER_WAIT`, do you want to illustrate  `NESTED_CONTAINER_KILL` 
> > too?

Thought about it before, but it depends on users whether or not to call 
`NESTED_CONTAINER_KILL ` from the executor. We already document 
`NESTED_CONTAINER_KILL` in previous section. This workflow just simply shows a 
common case of a nested container's life cycle using the new agent api.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review156819
---


On Nov. 22, 2016, 8:23 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Nov. 22, 2016, 8:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-11-23 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review156819
---


Fix it, then Ship it!





docs/nested-container-and-task-group.md (line 126)


s/contaienr/container/



docs/nested-container-and-task-group.md (line 147)


s/guarantee/guarantees/



docs/nested-container-and-task-group.md (line 166)


Indent, it seems a space is missed here.



docs/nested-container-and-task-group.md (line 209)


Currently we only support a single level of container nesting, right? If 
so, then I think we may need to mention this limitation here, and also mention 
we will support multiple level of container netsting in the section of `Future 
Work`.



docs/nested-container-and-task-group.md (line 213)


I see here you have illustrated `NESTED_CONTAINER_LAUNCH` and 
`NESTED_CONTAINER_WAIT`, do you want to illustrate  `NESTED_CONTAINER_KILL` too?



docs/nested-container-and-task-group.md (line 297)


Does this refer to multiple level of container nesting or something else?


- Qian Zhang


On Nov. 23, 2016, 12:23 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Nov. 23, 2016, 12:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 54013: Added user doc for nested container and task group.

2016-11-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review156742
---



Patch looks great!

Reviews applied: [54013]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2016, 4:23 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> ---
> 
> (Updated Nov. 23, 2016, 4:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> ---
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>