Re: Review Request 54035: Extended test coverage of posix/rlimits isolator.

2016-12-20 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54035/#review159658
---


Fix it, then Ship it!





src/tests/containerizer/posix_rlimits_isolator_tests.cpp (line 282)


i'll stick to slave for now given all the rest of the funciton names uses 
Slave (and 'slave') still.


- Jie Yu


On Dec. 19, 2016, 11:07 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54035/
> ---
> 
> (Updated Dec. 19, 2016, 11:07 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Till Toenshoff.
> 
> 
> Bugs: MESOS-6402
> https://issues.apache.org/jira/browse/MESOS-6402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds additional tests of the posix/rlimits isolator.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 
> 24b19d9eb1cc3e19f8325fbd76182837a5690581 
> 
> Diff: https://reviews.apache.org/r/54035/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OS X, clang trunk w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 54035: Extended test coverage of posix/rlimits isolator.

2016-12-19 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54035/
---

(Updated Dec. 19, 2016, 12:07 p.m.)


Review request for mesos, Jie Yu and Till Toenshoff.


Changes
---

Inline fixture into each test.


Bugs: MESOS-6402
https://issues.apache.org/jira/browse/MESOS-6402


Repository: mesos


Description (updated)
---

This change adds additional tests of the posix/rlimits isolator.


Diffs (updated)
-

  src/tests/containerizer/posix_rlimits_isolator_tests.cpp 
24b19d9eb1cc3e19f8325fbd76182837a5690581 

Diff: https://reviews.apache.org/r/54035/diff/


Testing
---

`make check` (OS X, clang trunk w/o optimizations)


Thanks,

Benjamin Bannier

Re: Review Request 54035: Extended test coverage of posix/rlimits isolator.

2016-11-30 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54035/#review157420
---



Patch looks great!

Reviews applied: [54034, 54035]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 30, 2016, 3:16 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54035/
> ---
> 
> (Updated Nov. 30, 2016, 3:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6402
> https://issues.apache.org/jira/browse/MESOS-6402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Extended test coverage of posix/rlimits isolator.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 
> 24b19d9eb1cc3e19f8325fbd76182837a5690581 
> 
> Diff: https://reviews.apache.org/r/54035/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OS X, clang trunk w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 54035: Extended test coverage of posix/rlimits isolator.

2016-11-30 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54035/
---

(Updated Nov. 30, 2016, 4:16 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Addressed tillt's comments.


Bugs: MESOS-6402
https://issues.apache.org/jira/browse/MESOS-6402


Repository: mesos


Description
---

Extended test coverage of posix/rlimits isolator.


Diffs (updated)
-

  src/tests/containerizer/posix_rlimits_isolator_tests.cpp 
24b19d9eb1cc3e19f8325fbd76182837a5690581 

Diff: https://reviews.apache.org/r/54035/diff/


Testing
---

`make check` (OS X, clang trunk w/o optimizations)


Thanks,

Benjamin Bannier

Re: Review Request 54035: Extended test coverage of posix/rlimits isolator.

2016-11-30 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54035/#review157402
---


Fix it, then Ship it!





src/tests/containerizer/posix_rlimits_isolator_tests.cpp (line 134)


Can we check the failure reason as well?



src/tests/containerizer/posix_rlimits_isolator_tests.cpp (line 144)


Are we *sure* this is always `unlimited` and not `unbegrenzt` or alike :)



src/tests/containerizer/posix_rlimits_isolator_tests.cpp (line 202)


See above on failure-reason.


- Till Toenshoff


On Nov. 23, 2016, 4:35 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54035/
> ---
> 
> (Updated Nov. 23, 2016, 4:35 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6402
> https://issues.apache.org/jira/browse/MESOS-6402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Extended test coverage of posix/rlimits isolator.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 
> 24b19d9eb1cc3e19f8325fbd76182837a5690581 
> 
> Diff: https://reviews.apache.org/r/54035/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OS X, clang trunk w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>