Re: Review Request 54085: Made internal Mesos headers more standalone.

2017-03-01 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54085/#review167524
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 14, 2016, 9:03 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54085/
> ---
> 
> (Updated Dec. 14, 2016, 9:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Missing includes were found by attempting to parse the header files
> standalone with
> 
> $ clang++ -fsyntax-only -I  HEADER_FILE.hpp
> 
> By fixing failures we can make sure that all required symbols are
> defined.
> 
> Note this change does not address the issue of transitive includes.
> 
> 
> Diffs
> -
> 
>   src/common/build.hpp 80e071fea7e2ca98772ccd85930a538a8dbca0a6 
>   src/credentials/credentials.hpp c790793c7ea5ed384bdb397bfc1592b8fd1ff327 
>   src/master/allocator/mesos/metrics.hpp 
> 753f90acc52ada84883cbbe3350e61d1e1eaff48 
>   src/master/machine.hpp 22b87770f0811bcef25bb79d678e0a3e78d3f7ac 
>   src/slave/container_loggers/logrotate.hpp 
> 96dbd2db9495925cb618bd7fe6271023c74fd9fe 
>   src/slave/containerizer/composing.hpp 
> 292374aefbc70e4b9d8c81740656864dbada8e32 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
> 8d225878ddbd04e4297b84c9ff782a994986aa4e 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
> 642dd53a8028d26b0a8c7429a502d33db26838b7 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 2cc8e764ff18c95c29598df75cdb370ccf120662 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> b8fc755a8dd4757d904f7e97a71d3cf7f29d2033 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> 7678a7c81c3cdb27410c1f066021eb34bd02a83f 
>   src/slave/containerizer/mesos/provisioner/appc/cache.hpp 
> 1e10dc604b29e418beacad6475910dcf7f8899c0 
>   src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f 
>   src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d 
>   src/tests/containerizer/mock_containerizer.hpp 
> ca0ae053b1eed01d6c04f581cd08485beec0c5fb 
>   src/usage/usage.hpp 6576b9001f93cb33c8c4ae83b32ee22ea0354fc7 
> 
> 
> Diff: https://reviews.apache.org/r/54085/diff/2/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang trunk w/o optimizations, SSL)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 54085: Made internal Mesos headers more standalone.

2016-12-14 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54085/#review159155
---



Patch looks great!

Reviews applied: [54083, 54085]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Dec. 14, 2016, 9:03 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54085/
> ---
> 
> (Updated Dec. 14, 2016, 9:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Missing includes were found by attempting to parse the header files
> standalone with
> 
> $ clang++ -fsyntax-only -I  HEADER_FILE.hpp
> 
> By fixing failures we can make sure that all required symbols are
> defined.
> 
> Note this change does not address the issue of transitive includes.
> 
> 
> Diffs
> -
> 
>   src/common/build.hpp 80e071fea7e2ca98772ccd85930a538a8dbca0a6 
>   src/credentials/credentials.hpp c790793c7ea5ed384bdb397bfc1592b8fd1ff327 
>   src/master/allocator/mesos/metrics.hpp 
> 753f90acc52ada84883cbbe3350e61d1e1eaff48 
>   src/master/machine.hpp 22b87770f0811bcef25bb79d678e0a3e78d3f7ac 
>   src/slave/container_loggers/logrotate.hpp 
> 96dbd2db9495925cb618bd7fe6271023c74fd9fe 
>   src/slave/containerizer/composing.hpp 
> 292374aefbc70e4b9d8c81740656864dbada8e32 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
> 8d225878ddbd04e4297b84c9ff782a994986aa4e 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
> 642dd53a8028d26b0a8c7429a502d33db26838b7 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 2cc8e764ff18c95c29598df75cdb370ccf120662 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> b8fc755a8dd4757d904f7e97a71d3cf7f29d2033 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> 7678a7c81c3cdb27410c1f066021eb34bd02a83f 
>   src/slave/containerizer/mesos/provisioner/appc/cache.hpp 
> 1e10dc604b29e418beacad6475910dcf7f8899c0 
>   src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f 
>   src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d 
>   src/tests/containerizer/mock_containerizer.hpp 
> ca0ae053b1eed01d6c04f581cd08485beec0c5fb 
>   src/usage/usage.hpp 6576b9001f93cb33c8c4ae83b32ee22ea0354fc7 
> 
> Diff: https://reviews.apache.org/r/54085/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang trunk w/o optimizations, SSL)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 54085: Made internal Mesos headers more standalone.

2016-12-14 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54085/
---

(Updated Dec. 14, 2016, 10:03 a.m.)


Review request for mesos, Alexander Rojas and Jiang Yan Xu.


Changes
---

Rebased.


Repository: mesos


Description (updated)
---

Missing includes were found by attempting to parse the header files
standalone with

$ clang++ -fsyntax-only -I  HEADER_FILE.hpp

By fixing failures we can make sure that all required symbols are
defined.

Note this change does not address the issue of transitive includes.


Diffs (updated)
-

  src/common/build.hpp 80e071fea7e2ca98772ccd85930a538a8dbca0a6 
  src/credentials/credentials.hpp c790793c7ea5ed384bdb397bfc1592b8fd1ff327 
  src/master/allocator/mesos/metrics.hpp 
753f90acc52ada84883cbbe3350e61d1e1eaff48 
  src/master/machine.hpp 22b87770f0811bcef25bb79d678e0a3e78d3f7ac 
  src/slave/container_loggers/logrotate.hpp 
96dbd2db9495925cb618bd7fe6271023c74fd9fe 
  src/slave/containerizer/composing.hpp 
292374aefbc70e4b9d8c81740656864dbada8e32 
  src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
8d225878ddbd04e4297b84c9ff782a994986aa4e 
  src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
642dd53a8028d26b0a8c7429a502d33db26838b7 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
2cc8e764ff18c95c29598df75cdb370ccf120662 
  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
b8fc755a8dd4757d904f7e97a71d3cf7f29d2033 
  src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
7678a7c81c3cdb27410c1f066021eb34bd02a83f 
  src/slave/containerizer/mesos/provisioner/appc/cache.hpp 
1e10dc604b29e418beacad6475910dcf7f8899c0 
  src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f 
  src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d 
  src/tests/containerizer/mock_containerizer.hpp 
ca0ae053b1eed01d6c04f581cd08485beec0c5fb 
  src/usage/usage.hpp 6576b9001f93cb33c8c4ae83b32ee22ea0354fc7 

Diff: https://reviews.apache.org/r/54085/diff/


Testing
---

make check (OS X, clang trunk w/o optimizations, SSL)


Thanks,

Benjamin Bannier



Re: Review Request 54085: Made internal Mesos headers more standalone.

2016-11-28 Thread Gastón Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54085/#review157017
---


Ship it!




Ship It!

- Gastón Kleiman


On Nov. 25, 2016, 4:53 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54085/
> ---
> 
> (Updated Nov. 25, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Missing includes were found by attempting to parse the headeer files
> standalone with
> 
> $ clang++ -fsyntax-only -I  HEADER_FILE.hpp
> 
> By fixing failures we can make sure that all required symbols are
> defined.
> 
> Note this change does not address the issue of transitive includes.
> 
> 
> Diffs
> -
> 
>   src/common/build.hpp 80e071fea7e2ca98772ccd85930a538a8dbca0a6 
>   src/credentials/credentials.hpp c790793c7ea5ed384bdb397bfc1592b8fd1ff327 
>   src/master/allocator/mesos/metrics.hpp 
> 753f90acc52ada84883cbbe3350e61d1e1eaff48 
>   src/master/machine.hpp 22b87770f0811bcef25bb79d678e0a3e78d3f7ac 
>   src/slave/container_loggers/logrotate.hpp 
> 96dbd2db9495925cb618bd7fe6271023c74fd9fe 
>   src/slave/containerizer/composing.hpp 
> 292374aefbc70e4b9d8c81740656864dbada8e32 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
> 8d225878ddbd04e4297b84c9ff782a994986aa4e 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
> 642dd53a8028d26b0a8c7429a502d33db26838b7 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 2cc8e764ff18c95c29598df75cdb370ccf120662 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.hpp 
> cd79033b24cd54e1b7e1c18beeb1629fc0f18537 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> b8fc755a8dd4757d904f7e97a71d3cf7f29d2033 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> 7678a7c81c3cdb27410c1f066021eb34bd02a83f 
>   src/slave/containerizer/mesos/provisioner/appc/cache.hpp 
> 1e10dc604b29e418beacad6475910dcf7f8899c0 
>   src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f 
>   src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d 
>   src/tests/containerizer/mock_containerizer.hpp 
> 7a30b8307b93b7bf549efb52d72367f652d0d95a 
>   src/usage/usage.hpp 6576b9001f93cb33c8c4ae83b32ee22ea0354fc7 
> 
> Diff: https://reviews.apache.org/r/54085/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang trunk w/o optimizations, SSL)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 54085: Made internal Mesos headers more standalone.

2016-11-28 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54085/#review157008
---


Ship it!




Ship It!

- Alexander Rojas


On Nov. 25, 2016, 5:53 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54085/
> ---
> 
> (Updated Nov. 25, 2016, 5:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Missing includes were found by attempting to parse the headeer files
> standalone with
> 
> $ clang++ -fsyntax-only -I  HEADER_FILE.hpp
> 
> By fixing failures we can make sure that all required symbols are
> defined.
> 
> Note this change does not address the issue of transitive includes.
> 
> 
> Diffs
> -
> 
>   src/common/build.hpp 80e071fea7e2ca98772ccd85930a538a8dbca0a6 
>   src/credentials/credentials.hpp c790793c7ea5ed384bdb397bfc1592b8fd1ff327 
>   src/master/allocator/mesos/metrics.hpp 
> 753f90acc52ada84883cbbe3350e61d1e1eaff48 
>   src/master/machine.hpp 22b87770f0811bcef25bb79d678e0a3e78d3f7ac 
>   src/slave/container_loggers/logrotate.hpp 
> 96dbd2db9495925cb618bd7fe6271023c74fd9fe 
>   src/slave/containerizer/composing.hpp 
> 292374aefbc70e4b9d8c81740656864dbada8e32 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
> 8d225878ddbd04e4297b84c9ff782a994986aa4e 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
> 642dd53a8028d26b0a8c7429a502d33db26838b7 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 2cc8e764ff18c95c29598df75cdb370ccf120662 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.hpp 
> cd79033b24cd54e1b7e1c18beeb1629fc0f18537 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> b8fc755a8dd4757d904f7e97a71d3cf7f29d2033 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> 7678a7c81c3cdb27410c1f066021eb34bd02a83f 
>   src/slave/containerizer/mesos/provisioner/appc/cache.hpp 
> 1e10dc604b29e418beacad6475910dcf7f8899c0 
>   src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f 
>   src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d 
>   src/tests/containerizer/mock_containerizer.hpp 
> 7a30b8307b93b7bf549efb52d72367f652d0d95a 
>   src/usage/usage.hpp 6576b9001f93cb33c8c4ae83b32ee22ea0354fc7 
> 
> Diff: https://reviews.apache.org/r/54085/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang trunk w/o optimizations, SSL)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 54085: Made internal Mesos headers more standalone.

2016-11-25 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54085/#review156940
---



Patch looks great!

Reviews applied: [54085]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 25, 2016, 4:53 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54085/
> ---
> 
> (Updated Nov. 25, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Missing includes were found by attempting to parse the headeer files
> standalone with
> 
> $ clang++ -fsyntax-only -I  HEADER_FILE.hpp
> 
> By fixing failures we can make sure that all required symbols are
> defined.
> 
> Note this change does not address the issue of transitive includes.
> 
> 
> Diffs
> -
> 
>   src/common/build.hpp 80e071fea7e2ca98772ccd85930a538a8dbca0a6 
>   src/credentials/credentials.hpp c790793c7ea5ed384bdb397bfc1592b8fd1ff327 
>   src/master/allocator/mesos/metrics.hpp 
> 753f90acc52ada84883cbbe3350e61d1e1eaff48 
>   src/master/machine.hpp 22b87770f0811bcef25bb79d678e0a3e78d3f7ac 
>   src/slave/container_loggers/logrotate.hpp 
> 96dbd2db9495925cb618bd7fe6271023c74fd9fe 
>   src/slave/containerizer/composing.hpp 
> 292374aefbc70e4b9d8c81740656864dbada8e32 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
> 8d225878ddbd04e4297b84c9ff782a994986aa4e 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
> 642dd53a8028d26b0a8c7429a502d33db26838b7 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 2cc8e764ff18c95c29598df75cdb370ccf120662 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.hpp 
> cd79033b24cd54e1b7e1c18beeb1629fc0f18537 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> b8fc755a8dd4757d904f7e97a71d3cf7f29d2033 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> 7678a7c81c3cdb27410c1f066021eb34bd02a83f 
>   src/slave/containerizer/mesos/provisioner/appc/cache.hpp 
> 1e10dc604b29e418beacad6475910dcf7f8899c0 
>   src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f 
>   src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d 
>   src/tests/containerizer/mock_containerizer.hpp 
> 7a30b8307b93b7bf549efb52d72367f652d0d95a 
>   src/usage/usage.hpp 6576b9001f93cb33c8c4ae83b32ee22ea0354fc7 
> 
> Diff: https://reviews.apache.org/r/54085/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang trunk w/o optimizations, SSL)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>