Re: Review Request 54349: Added os::dup2 to stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/ --- (Updated Dec. 5, 2016, 5:36 a.m.) Review request for mesos, Benjamin Hindman and Kevin Klues. Changes --- Rebased. Bugs: MESOS-6470 https://issues.apache.org/jira/browse/MESOS-6470 Repository: mesos Description --- Added os::dup2 to stout. Diffs (updated) - 3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 Diff: https://reviews.apache.org/r/54349/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 54349: Added os::dup2 to stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/#review157949 --- Ship it! Ship It! - Benjamin Hindman On Dec. 4, 2016, 9:17 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54349/ > --- > > (Updated Dec. 4, 2016, 9:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Kevin Klues. > > > Bugs: MESOS-6470 > https://issues.apache.org/jira/browse/MESOS-6470 > > > Repository: mesos > > > Description > --- > > Added os::dup2 to stout. > > > Diffs > - > > 3rdparty/stout/include/stout/posix/os.hpp > c37e64db662ba3cee83d2f55de0f9d71ad72c038 > > Diff: https://reviews.apache.org/r/54349/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 54349: Added os::dup2 to stout.
> On Dec. 5, 2016, 1:02 a.m., Kevin Klues wrote: > > Should we add an equivalent function for windows? I assume we will need one > > to make any child hooks we add to `Subprocess` cross platform. dup is posix specific. i think we will have posix specific hooks anyway (e.g., supervised and setsid are all posix only hooks). Will try to make them not available to windows in a followup - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/#review157934 --- On Dec. 4, 2016, 9:17 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54349/ > --- > > (Updated Dec. 4, 2016, 9:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Kevin Klues. > > > Bugs: MESOS-6470 > https://issues.apache.org/jira/browse/MESOS-6470 > > > Repository: mesos > > > Description > --- > > Added os::dup2 to stout. > > > Diffs > - > > 3rdparty/stout/include/stout/posix/os.hpp > c37e64db662ba3cee83d2f55de0f9d71ad72c038 > > Diff: https://reviews.apache.org/r/54349/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 54349: Added os::dup2 to stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/#review157934 --- Ship it! Should we add an equivalent function for windows? I assume we will need one to make any child hooks we add to `Subprocess` cross platform. - Kevin Klues On Dec. 4, 2016, 9:17 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54349/ > --- > > (Updated Dec. 4, 2016, 9:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Kevin Klues. > > > Bugs: MESOS-6470 > https://issues.apache.org/jira/browse/MESOS-6470 > > > Repository: mesos > > > Description > --- > > Added os::dup2 to stout. > > > Diffs > - > > 3rdparty/stout/include/stout/posix/os.hpp > c37e64db662ba3cee83d2f55de0f9d71ad72c038 > > Diff: https://reviews.apache.org/r/54349/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
