Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54408/
---

(Updated Jan. 17, 2017, 5:24 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6719
https://issues.apache.org/jira/browse/MESOS-6719


Repository: mesos


Description
---

That is, the master previously tracked two separate things about a
framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and
whether the framework is considered active. It is simpler to represent
the latter value as just another state: a framework can now be ACTIVE,
INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it
is either ACTIVE or INACTIVE. This rules out a few combinations that
never made sense, such as "state = DISCONNECTED and active = TRUE".


Diffs (updated)
-

  src/master/http.cpp a44621f39cb059e654a56f57f75b38947f3a4230 
  src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004 
  src/master/master.cpp b863ff6e93931c3d1ee056248084c7f44caf2fd9 
  src/master/quota_handler.cpp 6e6e7375219d34e6e8d011a025b5f5d70b87383b 

Diff: https://reviews.apache.org/r/54408/diff/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54408/
---

(Updated Jan. 13, 2017, 1:38 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6719
https://issues.apache.org/jira/browse/MESOS-6719


Repository: mesos


Description
---

That is, the master previously tracked two separate things about a
framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and
whether the framework is considered active. It is simpler to represent
the latter value as just another state: a framework can now be ACTIVE,
INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it
is either ACTIVE or INACTIVE. This rules out a few combinations that
never made sense, such as "state = DISCONNECTED and active = TRUE".


Diffs (updated)
-

  src/master/http.cpp 75dcd6199dbfcca6260baed49b838a45312bb667 
  src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317 
  src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 
  src/master/quota_handler.cpp 6e6e7375219d34e6e8d011a025b5f5d70b87383b 

Diff: https://reviews.apache.org/r/54408/diff/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54408/
---

(Updated Jan. 13, 2017, 12:08 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address review comments.


Bugs: MESOS-6719
https://issues.apache.org/jira/browse/MESOS-6719


Repository: mesos


Description
---

That is, the master previously tracked two separate things about a
framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and
whether the framework is considered active. It is simpler to represent
the latter value as just another state: a framework can now be ACTIVE,
INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it
is either ACTIVE or INACTIVE. This rules out a few combinations that
never made sense, such as "state = DISCONNECTED and active = TRUE".


Diffs (updated)
-

  src/master/http.cpp 75dcd6199dbfcca6260baed49b838a45312bb667 
  src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317 
  src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 
  src/master/quota_handler.cpp 6e6e7375219d34e6e8d011a025b5f5d70b87383b 

Diff: https://reviews.apache.org/r/54408/diff/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54408/#review161163
---


Fix it, then Ship it!




Thanks for following through.


src/master/master.hpp (lines 2224 - 2239)


can you reorder these as so ?

RECOVERED,
DISCONNECTED,
INACTIVE,
ACTIVE

it's a bit more chronological but not really.



src/master/master.cpp (line 2914)


s/not connected/disconnected/


- Vinod Kone


On Dec. 7, 2016, 8:08 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54408/
> ---
> 
> (Updated Dec. 7, 2016, 8:08 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6719
> https://issues.apache.org/jira/browse/MESOS-6719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> That is, the master previously tracked two separate things about a
> framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and
> whether the framework is considered active. It is simpler to represent
> the latter value as just another state: a framework can now be ACTIVE,
> INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it
> is either ACTIVE or INACTIVE. This rules out a few combinations that
> never made sense, such as "state = DISCONNECTED and active = TRUE".
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f 
>   src/master/master.hpp b444b2352360fb4f7179acd97dffc0cd81cc7afa 
>   src/master/master.cpp 67f32229470da4cf7953881d1c5dcb99393002de 
>   src/master/quota_handler.cpp 5578663f26d9b737499dc4f5a286c34c37645442 
> 
> Diff: https://reviews.apache.org/r/54408/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54408/#review158495
---



Patch looks great!

Reviews applied: [54495, 53895, 53896, 53897, 54467, 54468, 54380, 54387, 
54177, 54178, 54179, 54180, 54181, 54182, 54183, 54232, 54312, 54407, 54408]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Dec. 7, 2016, 8:08 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54408/
> ---
> 
> (Updated Dec. 7, 2016, 8:08 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6719
> https://issues.apache.org/jira/browse/MESOS-6719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> That is, the master previously tracked two separate things about a
> framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and
> whether the framework is considered active. It is simpler to represent
> the latter value as just another state: a framework can now be ACTIVE,
> INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it
> is either ACTIVE or INACTIVE. This rules out a few combinations that
> never made sense, such as "state = DISCONNECTED and active = TRUE".
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f 
>   src/master/master.hpp b444b2352360fb4f7179acd97dffc0cd81cc7afa 
>   src/master/master.cpp 67f32229470da4cf7953881d1c5dcb99393002de 
>   src/master/quota_handler.cpp 5578663f26d9b737499dc4f5a286c34c37645442 
> 
> Diff: https://reviews.apache.org/r/54408/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54408/
---

(Updated Dec. 7, 2016, 8:08 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6719
https://issues.apache.org/jira/browse/MESOS-6719


Repository: mesos


Description
---

That is, the master previously tracked two separate things about a
framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and
whether the framework is considered active. It is simpler to represent
the latter value as just another state: a framework can now be ACTIVE,
INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it
is either ACTIVE or INACTIVE. This rules out a few combinations that
never made sense, such as "state = DISCONNECTED and active = TRUE".


Diffs (updated)
-

  src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f 
  src/master/master.hpp b444b2352360fb4f7179acd97dffc0cd81cc7afa 
  src/master/master.cpp 67f32229470da4cf7953881d1c5dcb99393002de 
  src/master/quota_handler.cpp 5578663f26d9b737499dc4f5a286c34c37645442 

Diff: https://reviews.apache.org/r/54408/diff/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54408/#review158316
---



Patch looks great!

Reviews applied: [53885, 53886, 53887, 53888, 53889, 53890, 53891, 53892, 
53893, 53894, 53895, 53896, 53897, 54467, 54468, 54380, 54387, 54177, 54178, 
54179, 54180, 54181, 54182, 54183, 54232, 54312, 54407, 54408]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Dec. 7, 2016, 4:20 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54408/
> ---
> 
> (Updated Dec. 7, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6719
> https://issues.apache.org/jira/browse/MESOS-6719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> That is, the master previously tracked two separate things about a
> framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and
> whether the framework is considered active. It is simpler to represent
> the latter value as just another state: a framework can now be ACTIVE,
> INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it
> is either ACTIVE or INACTIVE. This rules out a few combinations that
> never made sense, such as "state = DISCONNECTED and active = TRUE".
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f 
>   src/master/master.hpp b444b2352360fb4f7179acd97dffc0cd81cc7afa 
>   src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 
>   src/master/quota_handler.cpp 5578663f26d9b737499dc4f5a286c34c37645442 
> 
> Diff: https://reviews.apache.org/r/54408/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54408/
---

(Updated Dec. 7, 2016, 4:20 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Tweak commit message.


Summary (updated)
-

Replaced `Master::Framework::active` with a new `state` enum value.


Bugs: MESOS-6719
https://issues.apache.org/jira/browse/MESOS-6719


Repository: mesos


Description
---

That is, the master previously tracked two separate things about a
framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and
whether the framework is considered active. It is simpler to represent
the latter value as just another state: a framework can now be ACTIVE,
INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it
is either ACTIVE or INACTIVE. This rules out a few combinations that
never made sense, such as "state = DISCONNECTED and active = TRUE".


Diffs (updated)
-

  src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f 
  src/master/master.hpp b444b2352360fb4f7179acd97dffc0cd81cc7afa 
  src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 
  src/master/quota_handler.cpp 5578663f26d9b737499dc4f5a286c34c37645442 

Diff: https://reviews.apache.org/r/54408/diff/


Testing
---

`make check`


Thanks,

Neil Conway