Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57386/#review168447
---



In summary and description, change /auth/authz/. Using just auth doesn't 
clarify if you mean authorization or authentication (the best is to use the 
whole word).

Also, I don't think it is a good practice to use the same text in the summary 
as in the description, there was even a public discussion discouraging us about 
it.

- Alexander Rojas


On March 9, 2017, 2:54 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57386/
> ---
> 
> (Updated March 9, 2017, 2:54 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie 
> Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
> https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced changes to the auth protos needed for DeleteNestedContainer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   include/mesos/authorizer/authorizer.proto 
> fdc4817ce74c45d792fc47f064f7909a83b1657d 
> 
> 
> Diff: https://reviews.apache.org/r/57386/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57386/
---

(Updated March 9, 2017, 1:54 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie Yu, 
Kevin Klues, and Vinod Kone.


Changes
---

Addressed Vinod's feedback.


Bugs: MESOS-7120
https://issues.apache.org/jira/browse/MESOS-7120


Repository: mesos


Description
---

Introduced changes to the auth protos needed for DeleteNestedContainer.


Diffs (updated)
-

  include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
  include/mesos/authorizer/authorizer.proto 
fdc4817ce74c45d792fc47f064f7909a83b1657d 


Diff: https://reviews.apache.org/r/57386/diff/3/

Changes: https://reviews.apache.org/r/57386/diff/2-3/


Testing
---


Thanks,

Gastón Kleiman

Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57386/#review168389
---


Fix it, then Ship it!




LGTM modulo picking the right name.


include/mesos/authorizer/acls.proto
Lines 448 (patched)


move this to #440.



include/mesos/authorizer/authorizer.proto
Lines 191 (patched)


move this to #173


- Vinod Kone


On March 8, 2017, 11:08 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57386/
> ---
> 
> (Updated March 8, 2017, 11:08 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie 
> Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
> https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced changes to the auth protos needed for DeleteNestedContainer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   include/mesos/authorizer/authorizer.proto 
> fdc4817ce74c45d792fc47f064f7909a83b1657d 
> 
> 
> Diff: https://reviews.apache.org/r/57386/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer.

[Gastón Kleiman]

> On March 8, 2017, 1:06 a.m., Kevin Klues wrote:
> > I do not know enough about the auth code to do a proper review of this.
> > 
> > Can you fix the summary though -- s/photos/protos/

Good catch! macOS' autocorrect isn't geeky enough, so I disabled it =).


- Gastón


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57386/#review168227
---


On March 8, 2017, 11:08 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57386/
> ---
> 
> (Updated March 8, 2017, 11:08 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie 
> Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
> https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced changes to the auth protos needed for DeleteNestedContainer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   include/mesos/authorizer/authorizer.proto 
> fdc4817ce74c45d792fc47f064f7909a83b1657d 
> 
> 
> Diff: https://reviews.apache.org/r/57386/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57386/
---

(Updated March 8, 2017, 11:08 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie Yu, 
Kevin Klues, and Vinod Kone.


Changes
---

Fixed typo in summary.


Summary (updated)
-

Introduced changes to the auth protos needed for DeleteNestedContainer.


Bugs: MESOS-7120
https://issues.apache.org/jira/browse/MESOS-7120


Repository: mesos


Description (updated)
---

Introduced changes to the auth protos needed for DeleteNestedContainer.


Diffs (updated)
-

  include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
  include/mesos/authorizer/authorizer.proto 
fdc4817ce74c45d792fc47f064f7909a83b1657d 


Diff: https://reviews.apache.org/r/57386/diff/2/

Changes: https://reviews.apache.org/r/57386/diff/1-2/


Testing
---


Thanks,

Gastón Kleiman