Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/#review173015 --- Ship it! LGTM. - Joseph Wu On April 13, 2017, 7:03 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58446/ > --- > > (Updated April 13, 2017, 7:03 p.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > Reuse the variable rather than hardcode it. > > > Diffs > - > > 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 > > > Diff: https://reviews.apache.org/r/58446/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/#review172813 --- Ship it! Ship It! - Jeff Coffler On April 14, 2017, 2:03 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58446/ > --- > > (Updated April 14, 2017, 2:03 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > Reuse the variable rather than hardcode it. > > > Diffs > - > > 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 > > > Diff: https://reviews.apache.org/r/58446/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.
> On April 18, 2017, 8:27 p.m., Jeff Coffler wrote: > > This looks okay. But again: You didn't fill out anything for testing, > > leading me to believe that no testing was done. > > > > Please clarify the testing that you completed here, so I can understand > > that. Thanks. Please see the last patch in the chain for testing. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/#review172261 --- On April 14, 2017, 2:03 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58446/ > --- > > (Updated April 14, 2017, 2:03 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > Reuse the variable rather than hardcode it. > > > Diffs > - > > 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 > > > Diff: https://reviews.apache.org/r/58446/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/#review172261 --- This looks okay. But again: You didn't fill out anything for testing, leading me to believe that no testing was done. Please clarify the testing that you completed here, so I can understand that. Thanks. - Jeff Coffler On April 14, 2017, 2:03 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58446/ > --- > > (Updated April 14, 2017, 2:03 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > --- > > Reuse the variable rather than hardcode it. > > > Diffs > - > > 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 > > > Diff: https://reviews.apache.org/r/58446/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/#review171978 --- Looking at what I ended up doing for ZooKeeper, I think it may be better to build this using the CMake defaults of ExternalProject_Add, but it's not strictly necessary. - Andrew Schwartzmeyer On April 14, 2017, 2:01 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58446/ > --- > > (Updated April 14, 2017, 2:01 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > --- > > Reuse the variable rather than hardcode it. > > > Diffs > - > > 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 > > > Diff: https://reviews.apache.org/r/58446/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
