Re: Review Request 60539: Added test for allocated resources per each role in the agent endpoint.

2017-07-17 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60539/#review180789
---


Ship it!




Note that we're not adding a test anymore, so the summary needs to be updated.

- Benjamin Mahler


On July 17, 2017, 5:47 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60539/
> ---
> 
> (Updated July 17, 2017, 5:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for allocated resources per each role in the agent endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_endpoints_tests.cpp 
> 05b505fc4c643f56c7141b6b79f334b000470780 
> 
> 
> Diff: https://reviews.apache.org/r/60539/diff/3/
> 
> 
> Testing
> ---
> 
> make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60539: Added test for allocated resources per each role in the agent endpoint.

2017-07-17 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60539/
---

(Updated July 17, 2017, 5:47 p.m.)


Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

Added test for allocated resources per each role in the agent endpoint.


Diffs
-

  src/tests/reservation_endpoints_tests.cpp 
05b505fc4c643f56c7141b6b79f334b000470780 


Diff: https://reviews.apache.org/r/60539/diff/3/


Testing
---

make check (mac os x, fedora 25)


Thanks,

Andrei Budnik

Re: Review Request 60539: Added test for allocated resources per each role in the agent endpoint.

2017-07-14 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60539/#review180518
---




src/tests/reservation_endpoints_tests.cpp
Lines 1678 (patched)


Replace constants in the comment with DEFAULT_EXECUTOR_CPUS and 
DEFAULT_EXECUTOR_MEM.


- Andrei Budnik


On June 29, 2017, 3:23 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60539/
> ---
> 
> (Updated June 29, 2017, 3:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for allocated resources per each role in the agent endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_endpoints_tests.cpp 
> f710a188a7875c1cb847e39276b4b65332703ca5 
> 
> 
> Diff: https://reviews.apache.org/r/60539/diff/2/
> 
> 
> Testing
> ---
> 
> make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>