Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review193293 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017, 6:43 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60623/ > --- > > (Updated Dec. 7, 2017, 6:43 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li > Li, and Michael Park. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > --- > > Converted "file://" URI handling to use new uri function. > > > Diffs > - > > src/tests/credentials_tests.cpp 4ecb9778159e8eae3b017b83400d6a3168fa2476 > src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 > src/tests/master_contender_detector_tests.cpp > f499136c0b981072af5bc8accf2238b7ba4bf430 > src/tests/script.cpp 9823e334896895cfea8ccf9faf44529050f0f1c3 > > > Diff: https://reviews.apache.org/r/60623/diff/7/ > > > Testing > --- > > See upstream > > > Thanks, > > Jeff Coffler > >
Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Dec. 8, 2017, 2:43 a.m.) Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li Li, and Michael Park. Bugs: MESOS-6705 https://issues.apache.org/jira/browse/MESOS-6705 Repository: mesos Description --- Converted "file://" URI handling to use new uri function. Diffs (updated) - src/tests/credentials_tests.cpp 4ecb9778159e8eae3b017b83400d6a3168fa2476 src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 src/tests/script.cpp 9823e334896895cfea8ccf9faf44529050f0f1c3 Diff: https://reviews.apache.org/r/60623/diff/7/ Changes: https://reviews.apache.org/r/60623/diff/6-7/ Testing --- See upstream Thanks, Jeff Coffler
Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review191204 --- Ship it! Ship It! - Michael Park On Nov. 6, 2017, 10:09 a.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60623/ > --- > > (Updated Nov. 6, 2017, 10:09 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li > Li, and Michael Park. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > --- > > Converted "file://" URI handling to use new uri function. > > > Diffs > - > > src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 > src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 > src/tests/master_contender_detector_tests.cpp > f499136c0b981072af5bc8accf2238b7ba4bf430 > src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd > > > Diff: https://reviews.apache.org/r/60623/diff/6/ > > > Testing > --- > > See upstream > > > Thanks, > > Jeff Coffler > >
Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li. Bugs: MESOS-6705 https://issues.apache.org/jira/browse/MESOS-6705 Repository: mesos Description --- Converted "file://" URI handling to use new uri function. Diffs (updated) - src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd Diff: https://reviews.apache.org/r/60623/diff/6/ Changes: https://reviews.apache.org/r/60623/diff/5-6/ Testing --- See upstream Thanks, Jeff Coffler
Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 19, 2017, 6:17 p.m.) Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li. Bugs: MESOS-6705 https://issues.apache.org/jira/browse/MESOS-6705 Repository: mesos Description --- Converted "file://" URI handling to use new uri function. Diffs (updated) - src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd Diff: https://reviews.apache.org/r/60623/diff/5/ Changes: https://reviews.apache.org/r/60623/diff/4-5/ Testing --- See upstream Thanks, Jeff Coffler
Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review188417 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 16, 2017, 6:18 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60623/ > --- > > (Updated Oct. 16, 2017, 6:18 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > --- > > Converted "file://" URI handling to use new uri function. > > > Diffs > - > > src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 > src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 > src/tests/master_contender_detector_tests.cpp > f499136c0b981072af5bc8accf2238b7ba4bf430 > src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd > > > Diff: https://reviews.apache.org/r/60623/diff/4/ > > > Testing > --- > > See upstream > > > Thanks, > > Jeff Coffler > >
Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 17, 2017, 1:18 a.m.) Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li. Bugs: MESOS-6705 https://issues.apache.org/jira/browse/MESOS-6705 Repository: mesos Description --- Converted "file://" URI handling to use new uri function. Diffs (updated) - src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd Diff: https://reviews.apache.org/r/60623/diff/4/ Changes: https://reviews.apache.org/r/60623/diff/3-4/ Testing --- See upstream Thanks, Jeff Coffler
Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
> On Oct. 7, 2017, 8:37 p.m., Andrew Schwartzmeyer wrote: > > Same comment for style on summary as before, also missing description. Also > > URI is inconsistently capitalized ;) This still needs to be addressed. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review187348 --- On Oct. 11, 2017, 4:31 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60623/ > --- > > (Updated Oct. 11, 2017, 4:31 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > --- > > Converted "file://" URI handling to use new uri function. > > > Diffs > - > > src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 > src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 > src/tests/master_contender_detector_tests.cpp > f499136c0b981072af5bc8accf2238b7ba4bf430 > src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd > > > Diff: https://reviews.apache.org/r/60623/diff/3/ > > > Testing > --- > > See upstream > > > Thanks, > > Jeff Coffler > >
Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
On Oct. 8, 2017, 3:37 a.m., Jeff Coffler wrote: > > These changes in spirit are fine, but I don't like how the URI conversion > > has to be done at all. It should be as simple as `uri::from_path(input)`. That's exactly what I ultimately did. - Jeff --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review187348 --- On Oct. 11, 2017, 11:31 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60623/ > --- > > (Updated Oct. 11, 2017, 11:31 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > --- > > Converted "file://" URI handling to use new uri function. > > > Diffs > - > > src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 > src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 > src/tests/master_contender_detector_tests.cpp > f499136c0b981072af5bc8accf2238b7ba4bf430 > src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd > > > Diff: https://reviews.apache.org/r/60623/diff/3/ > > > Testing > --- > > See upstream > > > Thanks, > > Jeff Coffler > >
Re: Review Request 60623: Converted "file://" URI handling to use new uri function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 11, 2017, 11:31 p.m.) Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li. Summary (updated) - Converted "file://" URI handling to use new uri function. Bugs: MESOS-6705 https://issues.apache.org/jira/browse/MESOS-6705 Repository: mesos Description (updated) --- Converted "file://" URI handling to use new uri function. Diffs (updated) - src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7 src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430 src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd Diff: https://reviews.apache.org/r/60623/diff/3/ Changes: https://reviews.apache.org/r/60623/diff/2-3/ Testing --- See upstream Thanks, Jeff Coffler
