Re: Review Request 60820: Added class definition for the IDAcceptor.

2017-07-18 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180859
---


Ship it!




Ship It!

- Greg Mann


On July 18, 2017, 6:21 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> ---
> 
> (Updated July 18, 2017, 6:21 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit contains the class definitions for IDAcceptor, which is
> used to filter IDs in the '/master/frameworks', '/master/slaves' and
> '/slave/containers' endpoints.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e 
>   src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309 
>   src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 
> 
> 
> Diff: https://reviews.apache.org/r/60820/diff/9/
> 
> 
> Testing
> ---
> 
> make check -j48
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60820: Added class definition for the IDAcceptor.

2017-07-18 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180841
---




src/common/http.hpp
Lines 197-200 (original), 197-201 (patched)


How about:

"Used to filter results for API handlers. Provides the `accept()` method to 
test whether a supplied ID is equal to a stored target ID. If no target ID is 
provided when the acceptor is constructed, it will accept all inputs."



src/common/http.hpp
Line 219 (original), 208 (patched)


Need spaces:

```
if (id.isSome()) {
```



src/common/http.hpp
Lines 217 (patched)


Spaces here as well.



src/common/http.hpp
Lines 219-220 (patched)


Newline here.


- Greg Mann


On July 18, 2017, 6:21 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> ---
> 
> (Updated July 18, 2017, 6:21 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit contains the class definitions for IDAcceptor, which is
> used to filter IDs in the '/master/frameworks', '/master/slaves',
> '/master/tasks', and '/slave/containers' endpoints.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e 
>   src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309 
>   src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 
> 
> 
> Diff: https://reviews.apache.org/r/60820/diff/8/
> 
> 
> Testing
> ---
> 
> make check -j48
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60820: Added class definition for the IDAcceptor.

2017-07-18 Thread Quinn Leng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/
---

(Updated July 18, 2017, 6:21 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description (updated)
---

This commit contains the class definitions for IDAcceptor, which is
used to filter IDs in the '/master/frameworks', '/master/slaves',
'/master/tasks', and '/slave/containers' endpoints.


Diffs
-

  src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e 
  src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309 
  src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 


Diff: https://reviews.apache.org/r/60820/diff/8/


Testing
---

make check -j48


Thanks,

Quinn Leng

Re: Review Request 60820: Added class definition for the IDAcceptor.

2017-07-18 Thread Quinn Leng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/
---

(Updated July 18, 2017, 6:19 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Summary (updated)
-

Added class definition for the IDAcceptor.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description (updated)
---

This commit contains the class definitions for IDAcceptor, which is
used to filter IDs in the '/master/frameworks', '/master/slaves' and
'/slave/containers' endpoints.


Diffs (updated)
-

  src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e 
  src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309 
  src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 


Diff: https://reviews.apache.org/r/60820/diff/8/

Changes: https://reviews.apache.org/r/60820/diff/7-8/


Testing
---

make check -j48


Thanks,

Quinn Leng