Re: Review Request 62336: Kicked in disk monitoring early during recovery.

2017-09-15 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62336/#review185496
---



Patch looks great!

Reviews applied: [62252, 62230, 62343, 62344, 62336]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 15, 2017, 2 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62336/
> ---
> 
> (Updated Sept. 15, 2017, 2 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7939
> https://issues.apache.org/jira/browse/MESOS-7939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch calls `Slave::checkDiskUsage` after `Slave::recover`
> so completed executors are scheduled for GC to clean up disk space for
> status updates of terminated executors in `Slave::_recover`.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094 
>   src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd 
> 
> 
> Diff: https://reviews.apache.org/r/62336/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 62336: Kicked in disk monitoring early during recovery.

2017-09-14 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62336/#review185469
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62252', '62230', '62343', '62344', '62336']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62336

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62336/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (230 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (248 ms)
[--] 30 tests from ContentType/SchedulerTest (25595 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (950 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 
(1096 ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2169 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (138 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (158 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (340 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (346326 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62336/logs/mesos-tests-stderr.log):

```
I0915 05:44:03.072856 16404 master.cpp:8418] Removing framework 
66b909dc-a90d-4311-8431-0d6b99a5345f- (default)
I0915 05:44:03.072856 16404 master.cpp:3267] Deactivating framework 
66b909dc-a90d-4311-8431-0d6b99a5345f- (default)
I0915 05:44:03.073856 15504 hierarchical.cpp:412] Deactivated framework 
66b909dc-a90d-4311-8431-0d6b99a5345f-
I0915 05:44:03.073856 17008 slave.cpp:3246] Shutting down framework 
66b909dc-a90d-4311-8431-0d6b99a5345f-
I0915 05:44:03.073856 16404 master.cpp:8993] Updating the state of task 
89b835d3-f611-4dc3-911f-2c4c43e4a324 of framework 
66b909dc-a90d-4311-8431-0d6b99a5345f- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0915 05:44:03.086850 17008 slave.cpp:5742] Shutting down executor 'default' of 
framework 66b909dc-a90d-4311-8431-0d6b99a5345f- (via HTTP)
I0915 05:44:03.090852 16404 master.cpp:9087] Removing task 
89b835d3-f611-4dc3-911f-2c4c43e4a324 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework 66b909dc-a90d-4311-8431-0d6b99a5345f- on agent 
66b909dc-a90d-4311-8431-0d6b99a5345f-S0 at slave(254)@10.3.1.5:60615 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0915 05:44:03.111853 16404 master.cpp:9116] Removing executor 'default' with 
resources [] of framework 66b909dc-a90d-4311-8431-0d6b99a5345f- on agent 
66b909dc-a90d-4311-8431-0d6b99a5345f-S0 at slave(254)@10.3.1.5:60615 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0915 05:44:03.114852 16312 hierarchical.cpp:355] Removed framework 
66b909dc-a90d-4311-8431-0d6b99a5345f-
E0915 05:44:03.115852 18072 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0915 05:44:03.116854 15504 scheduler.cpp:444] Re-detecting master
I0915 05:44:03.119853 17008 scheduler.cpp:470] New master detected at 
master@10.3.1.5:60615
I0915 05:44:03.138854 17804 slave.cpp:5418] Executor 'default' of framework 
66b909dc-a90d-4311-8431-0d6b99a5345f- exited with status 0
I0915 05:44:03.138854 17804 slave.cpp:5522] Cleaning up executor 'default' of 
framework 66b909dc-a90d-4311-8431-0d6b99a5345f- (via HTTP)
W0915 05:44:03.139853 16404 master.cpp:7021] Ignoring unknown exited executor 
'default' of framework

Re: Review Request 62336: Kicked in disk monitoring early during recovery.

2017-09-14 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62336/
---

(Updated Sept. 15, 2017, 2 a.m.)


Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.


Changes
---

Reworked based on Vinod's feedback.


Summary (updated)
-

Kicked in disk monitoring early during recovery.


Bugs: MESOS-7939
https://issues.apache.org/jira/browse/MESOS-7939


Repository: mesos


Description (updated)
---

This patch calls `Slave::checkDiskUsage` after `Slave::recover`
so completed executors are scheduled for GC to clean up disk space for
status updates of terminated executors in `Slave::_recover`.


Diffs (updated)
-

  src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094 
  src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd 


Diff: https://reviews.apache.org/r/62336/diff/2/

Changes: https://reviews.apache.org/r/62336/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao