Re: Review Request 62793: Added cpplint to the list of excluded files by Python linter.

2017-10-11 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/
---

(Updated Oct. 11, 2017, 9:28 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin 
Klues.


Changes
---

Precised excluded file.


Repository: mesos


Description (updated)
---

This make sure that only our Python files and
no third party libraries are being linted.


Diffs (updated)
-

  support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
  support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 


Diff: https://reviews.apache.org/r/62793/diff/4/

Changes: https://reviews.apache.org/r/62793/diff/3-4/


Testing
---

After this commit I have modified 'support/cpplint.py' and checked that it was 
not linted.


Thanks,

Armand Grillet

Re: Review Request 62793: Added cpplint to the list of excluded files by Python linter.

2017-10-10 Thread Armand Grillet 


> On Oct. 10, 2017, 2:29 p.m., Benjamin Bannier wrote:
> > support/mesos-style.py
> > Lines 346 (patched)
> > 
> >
> > Any reason we are not more explicit here, e.g., `r'cpplint.py'`?

The previous lines were only using basenames thus I have done the same. Does it 
make sense?


- Armand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/#review187534
---


On Oct. 10, 2017, 9:57 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62793/
> ---
> 
> (Updated Oct. 10, 2017, 9:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin 
> Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This make sure that no third party libraries are being linted.
> 
> 
> Diffs
> -
> 
>   support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62793/diff/3/
> 
> 
> Testing
> ---
> 
> After this commit I have modified 'support/cpplint.py' and checked that it 
> was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62793: Added cpplint to the list of excluded files by Python linter.

2017-10-10 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/#review187534
---


Fix it, then Ship it!





support/mesos-style.py
Lines 346 (patched)


Any reason we are not more explicit here, e.g., `r'cpplint.py'`?


- Benjamin Bannier


On Oct. 10, 2017, 11:57 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62793/
> ---
> 
> (Updated Oct. 10, 2017, 11:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin 
> Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This make sure that no third party libraries are being linted.
> 
> 
> Diffs
> -
> 
>   support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62793/diff/3/
> 
> 
> Testing
> ---
> 
> After this commit I have modified 'support/cpplint.py' and checked that it 
> was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62793: Added cpplint to the list of excluded files by Python linter.

2017-10-10 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/#review187517
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62793']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62793

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62793/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/0 (276 ms)
[ RUN  ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1
[   OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1 (306 ms)
[ RUN  ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2
[   OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2 (311 ms)
[ RUN  ] Endpoint/SlaveEndpointTest.NoAuthorizer/0
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/0 (337 ms)
[ RUN  ] Endpoint/SlaveEndpointTest.NoAuthorizer/1
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/1 (328 ms)
[ RUN  ] Endpoint/SlaveEndpointTest.NoAuthorizer/2
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (344 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (3222 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (140 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (162 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (351 ms 
total)

[--] Global test environment tear-down
[==] 724 tests from 73 test cases ran. (387186 ms total)
[  PASSED  ] 723 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, 
where GetParam() = "mesos"

 1 FAILED TEST
  YOU HAVE 165 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62793/logs/mesos-tests-stderr.log):

```
I1010 11:53:11.459794 43084 containerizer.cpp:648] Recovering containerizer
I1010 11:53:11.466796 42988 provisioner.cpp:416] Provisioner recovery complete
I1010 11:53:11.467794 40992 slave.cpp:6326] Finished recovery
I1010 11:53:11.493798 40992 http.cpp:1185] HTTP GET for 
/slave(271)/monitor/statistics.json from 10.3.1.7:53057
I1010 11:53:11.495141 40992 http.cpp:976] Authorizing principal 
'test-principal' to GET the '/monitor/statistics.json' endpoint
I1010 11:53:11.514801 43592 slave.cpp:869] Agent terminating
I1010 11:53:11.691256 43592 containerizer.cpp:292] Using isolation { 
windows/cpu, filesystem/windows, environment_secret }
I1010 11:53:11.702256 43592 provisioner.cpp:255] Using default backend 'copy'
I1010 11:53:11.752261 43592 cluster.cpp:448] Creating default 'local' authorizer
I1010 11:53:11.771263 42800 slave.cpp:254] Mesos agent started on 
(272)@10.3.1.7:52113
I1010 11:53:11.772264 42800 slave.cpp:255] Flags at startup: --acls="" 
--appc_simple_discovery_uri_prefix="http://; 
--appc_store_dir="C:\Users\mesos\AppData\Local\Temp\2\4lGQBp\store\appc" 
--authenticate_http_readonly="true" --authenticate_http_readwrite="true" 
--authenticatee="crammd5" --authentication_backoff_factor="1secs" 
--authorizer="local" --container_disk_watch_interval="15secs" 
--containerizers="mesos" 
--credential="C:\Users\mesos\AppData\Local\Temp\2\4lGQBp\credential" 
--default_role="*" --disk_watch_interval="1mins" --docker="docker" 
--docker_kill_orphans="true" --docker_registry="https://registry-1.docker.io; 
--docker_remove_delay="6hrs" --docker_socket="//./pipe/docker_engine" 
--docker_stop_timeout="0ns" 
--docker_store_dir="C:\Users\mesos\AppData\Local\Temp\2\4lGQBp\store\docker" 
--docker_volume_checkpoint_dir="/var/run/mesos/isolators/docker/volume" 
--enforce_container_disk_quota="false" --executor_registration_timeout="1mins" 
--executor_reregistration_timeout="2secs" -
 -executor_shutdown_grace_period="5secs" 
--fetcher_cache_dir="C:\Users\mesos\AppData\Local\Temp\2\4lGQBp\fetch" 
--fetcher_cache_size="2GB" --frameworks_home="" --gc_delay="1weeks" 
--gc_disk_headroom="0.1" --hadoop_home="" --help="false" 
--hostname_lookup="true" --http_command_executor="false" 
--http_credentials="C:\Users\mesos\AppData\Local\Temp\2\4lGQBp\http_credentials"
 --http_heartbeat_interval="30secs" --initialize_driver_logging="true" 
--isolation="windows/cpu" --launcher="windows" --launcher_dir="C:\mesos\src" 
--logbufsecs="0" --logging_level="INFO" 
--max_completed_executors_per_framework="150" 
--oversubscribed_resources_interval="15secs" --port="5051"

Re: Review Request 62793: Added cpplint to the list of excluded files by Python linter.

2017-10-10 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/
---

(Updated Oct. 10, 2017, 9:57 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin 
Klues.


Changes
---

Simplified review request.


Summary (updated)
-

Added cpplint to the list of excluded files by Python linter.


Repository: mesos


Description (updated)
---

This make sure that no third party libraries are being linted.


Diffs (updated)
-

  support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
  support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 


Diff: https://reviews.apache.org/r/62793/diff/3/

Changes: https://reviews.apache.org/r/62793/diff/2-3/


Testing
---

After this commit I have modified 'support/cpplint.py' and checked that it was 
not linted.


Thanks,

Armand Grillet