Re: Review Request 63823: Initialized and subscribed storage local resource provider.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/#review192597
---


Ship it!




Ship It!

- Jie Yu


On Dec. 1, 2017, 1:34 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63823/
> ---
> 
> (Updated Dec. 1, 2017, 1:34 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8032
> https://issues.apache.org/jira/browse/MESOS-8032
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch validates `ResourceProviderInfo` for storage local resource
> providers upon creation. During initialization, the storage local
> resource provider first tries to recover its ID of the last session
> through reading the actual path linked by
> `/meta/resource_providers///latest`,
> then subscribe to the agent's resource provider manager.
> 
> This patch is split from https://reviews.apache.org/r/63021/.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> f586afc256fbcb2f2bf2451ffb7e7ba1d59cfa78 
> 
> 
> Diff: https://reviews.apache.org/r/63823/diff/7/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/#review192440
---




src/resource_provider/storage/provider.cpp
Lines 245 (patched)


Who is going to delete `StorageLocalResourceProvider` so that we can force 
a disconnection to the RP manager?

You can workaround it by reset the driver here. But how the local rp daemon 
detect that an RP has failed?



src/resource_provider/storage/provider.cpp
Lines 260 (patched)


why not return a failure if `realpath.isError`?


- Jie Yu


On Dec. 1, 2017, 1:34 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63823/
> ---
> 
> (Updated Dec. 1, 2017, 1:34 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8032
> https://issues.apache.org/jira/browse/MESOS-8032
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch validates `ResourceProviderInfo` for storage local resource
> providers upon creation. During initialization, the storage local
> resource provider first tries to recover its ID of the last session
> through reading the actual path linked by
> `/meta/resource_providers///latest`,
> then subscribe to the agent's resource provider manager.
> 
> This patch is split from https://reviews.apache.org/r/63021/.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> f586afc256fbcb2f2bf2451ffb7e7ba1d59cfa78 
> 
> 
> Diff: https://reviews.apache.org/r/63823/diff/7/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/
---

(Updated Dec. 1, 2017, 1:34 a.m.)


Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
---

Don't fatal after `driver->send(..)` fails.


Bugs: MESOS-8032
https://issues.apache.org/jira/browse/MESOS-8032


Repository: mesos


Description
---

This patch validates `ResourceProviderInfo` for storage local resource
providers upon creation. During initialization, the storage local
resource provider first tries to recover its ID of the last session
through reading the actual path linked by
`/meta/resource_providers///latest`,
then subscribe to the agent's resource provider manager.

This patch is split from https://reviews.apache.org/r/63021/.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
f586afc256fbcb2f2bf2451ffb7e7ba1d59cfa78 


Diff: https://reviews.apache.org/r/63823/diff/7/

Changes: https://reviews.apache.org/r/63823/diff/6-7/


Testing
---

make


Thanks,

Chun-Hung Hsiao

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/
---

(Updated Nov. 29, 2017, 7:49 p.m.)


Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
---

Added a `RECOVERING` state.


Bugs: MESOS-8032
https://issues.apache.org/jira/browse/MESOS-8032


Repository: mesos


Description
---

This patch validates `ResourceProviderInfo` for storage local resource
providers upon creation. During initialization, the storage local
resource provider first tries to recover its ID of the last session
through reading the actual path linked by
`/meta/resource_providers///latest`,
then subscribe to the agent's resource provider manager.

This patch is split from https://reviews.apache.org/r/63021/.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
49c042cdb1837860aaedde2e48f318ed5ac8b1d1 


Diff: https://reviews.apache.org/r/63823/diff/6/

Changes: https://reviews.apache.org/r/63823/diff/5-6/


Testing
---

make


Thanks,

Chun-Hung Hsiao

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/
---

(Updated Nov. 28, 2017, 11:14 p.m.)


Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
---

Added a READY state to indicate that the SLRP is ready to serve.


Bugs: MESOS-8032
https://issues.apache.org/jira/browse/MESOS-8032


Repository: mesos


Description
---

This patch validates `ResourceProviderInfo` for storage local resource
providers upon creation. During initialization, the storage local
resource provider first tries to recover its ID of the last session
through reading the actual path linked by
`/meta/resource_providers///latest`,
then subscribe to the agent's resource provider manager.

This patch is split from https://reviews.apache.org/r/63021/.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
49c042cdb1837860aaedde2e48f318ed5ac8b1d1 


Diff: https://reviews.apache.org/r/63823/diff/5/

Changes: https://reviews.apache.org/r/63823/diff/4-5/


Testing
---

make


Thanks,

Chun-Hung Hsiao

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/
---

(Updated Nov. 26, 2017, 11:18 p.m.)


Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
---

Addressed jieyu's comments and rebased on r64065.


Summary (updated)
-

Initialized and subscribed storage local resource provider.


Bugs: MESOS-8032
https://issues.apache.org/jira/browse/MESOS-8032


Repository: mesos


Description (updated)
---

This patch validates `ResourceProviderInfo` for storage local resource
providers upon creation. During initialization, the storage local
resource provider first tries to recover its ID of the last session
through reading the actual path linked by
`/meta/resource_providers///latest`,
then subscribe to the agent's resource provider manager.

This patch is split from https://reviews.apache.org/r/63021/.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
49c042cdb1837860aaedde2e48f318ed5ac8b1d1 


Diff: https://reviews.apache.org/r/63823/diff/4/

Changes: https://reviews.apache.org/r/63823/diff/3-4/


Testing
---

make


Thanks,

Chun-Hung Hsiao

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/
---

(Updated Nov. 21, 2017, 10:28 p.m.)


Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
---

Rebased on r63904.


Bugs: MESOS-8032
https://issues.apache.org/jira/browse/MESOS-8032


Repository: mesos


Description
---

This patch validates `ResourceProviderInfo` for storage local resource
providers upon creation. During initialization, the storage local
resource provider first tries to recover its ID of the last session
through reading the actual path linked by
`/meta/resource_providers///latest`,
then subscribe to the agent's resource provider manager.

This patch is split from https://reviews.apache.org/r/63021/.


Diffs (updated)
-

  src/resource_provider/manager.cpp 6dfc42900a1e4249f37cec585f7fe50f5aa94e43 
  src/resource_provider/storage/provider.cpp 
46224997430ac0c568904d80014166a6f059907f 


Diff: https://reviews.apache.org/r/63823/diff/2/

Changes: https://reviews.apache.org/r/63823/diff/1-2/


Testing (updated)
---

make


Thanks,

Chun-Hung Hsiao