Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`.

2018-01-30 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65294/#review196553
---


Ship it!




Ship It!

- James Peach


On Jan. 30, 2018, 12:03 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65294/
> ---
> 
> (Updated Jan. 30, 2018, 12:03 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-8471
> https://issues.apache.org/jira/browse/MESOS-8471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add revocable resources support to mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 6e626893a64dc07ac9a5f9a5c31e680cb80938fe 
> 
> 
> Diff: https://reviews.apache.org/r/65294/diff/2/
> 
> 
> Testing
> ---
> 
> Submitted a test task with following configuration:
> ```
>  {
>"name": "Name",
>"task_id": {"value" : "1"},
>"agent_id": {"value" : ""},
>"resources": [
>  {
>"name": "cpus",
>"type": "SCALAR",
>"revocable": {},
>"scalar": {
>  "value": 0.1
>}
>  }
>],
>"command": {
>  "value": "sleep 1000"
>}
>  }
>  ```
>  
> With command `mesos-execute --master=localhost:5050 --revocable_resources 
> --task=file:///home/user/test_rev_task.json`
> 
> If the master/agent has revocable cpu, this allows the task to execute.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`.

2018-01-30 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65294/#review196550
---


Ship it!




Ship It!

- Jason Lai


On Jan. 30, 2018, 12:03 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65294/
> ---
> 
> (Updated Jan. 30, 2018, 12:03 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-8471
> https://issues.apache.org/jira/browse/MESOS-8471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add revocable resources support to mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 6e626893a64dc07ac9a5f9a5c31e680cb80938fe 
> 
> 
> Diff: https://reviews.apache.org/r/65294/diff/2/
> 
> 
> Testing
> ---
> 
> Submitted a test task with following configuration:
> ```
>  {
>"name": "Name",
>"task_id": {"value" : "1"},
>"agent_id": {"value" : ""},
>"resources": [
>  {
>"name": "cpus",
>"type": "SCALAR",
>"revocable": {},
>"scalar": {
>  "value": 0.1
>}
>  }
>],
>"command": {
>  "value": "sleep 1000"
>}
>  }
>  ```
>  
> With command `mesos-execute --master=localhost:5050 --revocable_resources 
> --task=file:///home/user/test_rev_task.json`
> 
> If the master/agent has revocable cpu, this allows the task to execute.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`.

2018-01-30 Thread Anish Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65294/#review196542
---


Ship it!




Ship It!

- Anish Gupta


On Jan. 30, 2018, 12:03 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65294/
> ---
> 
> (Updated Jan. 30, 2018, 12:03 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-8471
> https://issues.apache.org/jira/browse/MESOS-8471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add revocable resources support to mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 6e626893a64dc07ac9a5f9a5c31e680cb80938fe 
> 
> 
> Diff: https://reviews.apache.org/r/65294/diff/2/
> 
> 
> Testing
> ---
> 
> Submitted a test task with following configuration:
> ```
>  {
>"name": "Name",
>"task_id": {"value" : "1"},
>"agent_id": {"value" : ""},
>"resources": [
>  {
>"name": "cpus",
>"type": "SCALAR",
>"revocable": {},
>"scalar": {
>  "value": 0.1
>}
>  }
>],
>"command": {
>  "value": "sleep 1000"
>}
>  }
>  ```
>  
> With command `mesos-execute --master=localhost:5050 --revocable_resources 
> --task=file:///home/user/test_rev_task.json`
> 
> If the master/agent has revocable cpu, this allows the task to execute.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`.

2018-01-29 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65294/#review196491
---



PASS: Mesos patch 65294 was successfully built and tested.

Reviews applied: `['65414', '65294']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65294

- Mesos Reviewbot Windows


On Jan. 30, 2018, 12:03 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65294/
> ---
> 
> (Updated Jan. 30, 2018, 12:03 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-8471
> https://issues.apache.org/jira/browse/MESOS-8471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add revocable resources support to mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 6e626893a64dc07ac9a5f9a5c31e680cb80938fe 
> 
> 
> Diff: https://reviews.apache.org/r/65294/diff/2/
> 
> 
> Testing
> ---
> 
> Submitted a test task with following configuration:
> ```
>  {
>"name": "Name",
>"task_id": {"value" : "1"},
>"agent_id": {"value" : ""},
>"resources": [
>  {
>"name": "cpus",
>"type": "SCALAR",
>"revocable": {},
>"scalar": {
>  "value": 0.1
>}
>  }
>],
>"command": {
>  "value": "sleep 1000"
>}
>  }
>  ```
>  
> With command `mesos-execute --master=localhost:5050 --revocable_resources 
> --task=file:///home/user/test_rev_task.json`
> 
> If the master/agent has revocable cpu, this allows the task to execute.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`.

2018-01-29 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65294/
---

(Updated Jan. 30, 2018, 12:03 a.m.)


Review request for mesos, Anish Gupta, Jason Lai, and James Peach.


Changes
---

Unconditionally set `revocable_resources` capability.


Summary (updated)
-

Support `revocable_resources` capability in `mesos-execute`.


Bugs: MESOS-8471
https://issues.apache.org/jira/browse/MESOS-8471


Repository: mesos


Description (updated)
---

Add revocable resources support to mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp 6e626893a64dc07ac9a5f9a5c31e680cb80938fe 


Diff: https://reviews.apache.org/r/65294/diff/2/

Changes: https://reviews.apache.org/r/65294/diff/1-2/


Testing
---

Submitted a test task with following configuration:
```
 {
   "name": "Name",
   "task_id": {"value" : "1"},
   "agent_id": {"value" : ""},
   "resources": [
 {
   "name": "cpus",
   "type": "SCALAR",
   "revocable": {},
   "scalar": {
 "value": 0.1
   }
 }
   ],
   "command": {
 "value": "sleep 1000"
   }
 }
 ```
 
With command `mesos-execute --master=localhost:5050 --revocable_resources 
--task=file:///home/user/test_rev_task.json`

If the master/agent has revocable cpu, this allows the task to execute.


Thanks,

Zhitao Li