Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2019-02-27 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/#review213281
---


Ship it!




Ship It!

- Gilbert Song


On Feb. 25, 2019, 7:06 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68163/
> ---
> 
> (Updated Feb. 25, 2019, 7:06 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 6afc56cecbf6f06615dbc8632578332e6f7fb6ae 
> 
> 
> Diff: https://reviews.apache.org/r/68163/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2019-02-25 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/
---

(Updated Feb. 26, 2019, 11:06 a.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, 
and Jie Yu.


Changes
---

Minor change.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
6afc56cecbf6f06615dbc8632578332e6f7fb6ae 


Diff: https://reviews.apache.org/r/68163/diff/3/

Changes: https://reviews.apache.org/r/68163/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2019-02-24 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/#review213137
---


Ship it!




Ship It!

- Gilbert Song


On Dec. 10, 2018, 10:51 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68163/
> ---
> 
> (Updated Dec. 10, 2018, 10:51 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 6afc56cecbf6f06615dbc8632578332e6f7fb6ae 
> 
> 
> Diff: https://reviews.apache.org/r/68163/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-12-20 Thread Qian Zhang 


> On Dec. 13, 2018, 12:13 a.m., Andrei Budnik wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 2521 (patched)
> > 
> >
> > Do we have a check in the Mesos agent that all related paths have read 
> > permissions for `group`/`other`?

I do not remember we have such check in agent code, but usually the mode of the 
dirs created by agent is `rwxr-xr-x` which I think depends on the `umask`. The 
reason that we need to do `chmod` here for the work dir is, the work dir is 
created by `mkdtemp` which creates directory with permissions 0700.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/#review211241
---


On Dec. 11, 2018, 2:51 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68163/
> ---
> 
> (Updated Dec. 11, 2018, 2:51 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 6afc56cecbf6f06615dbc8632578332e6f7fb6ae 
> 
> 
> Diff: https://reviews.apache.org/r/68163/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-12-12 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/#review211241
---


Fix it, then Ship it!




Ship It!


src/tests/persistent_volume_tests.cpp
Lines 2521 (patched)


Do we have a check in the Mesos agent that all related paths have read 
permissions for `group`/`other`?


- Andrei Budnik


On Dec. 11, 2018, 6:51 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68163/
> ---
> 
> (Updated Dec. 11, 2018, 6:51 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 6afc56cecbf6f06615dbc8632578332e6f7fb6ae 
> 
> 
> Diff: https://reviews.apache.org/r/68163/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-12-10 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/
---

(Updated Dec. 11, 2018, 2:51 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, 
and Jie Yu.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
6afc56cecbf6f06615dbc8632578332e6f7fb6ae 


Diff: https://reviews.apache.org/r/68163/diff/2/

Changes: https://reviews.apache.org/r/68163/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-08-02 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/#review206790
---



FAIL: Failed to apply the dependent review: 66811.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 66811`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2029/mesos-review-68163

Relevant logs:

- 
[apply-review-66811-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2029/mesos-review-68163/logs/apply-review-66811-stdout.log):

```
error: patch failed: 3rdparty/stout/CMakeLists.txt:30
error: 3rdparty/stout/CMakeLists.txt: patch does not apply
```

- Mesos Reviewbot Windows


On Aug. 2, 2018, 9:34 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68163/
> ---
> 
> (Updated Aug. 2, 2018, 9:34 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 6afc56cecbf6f06615dbc8632578332e6f7fb6ae 
> 
> 
> Diff: https://reviews.apache.org/r/68163/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>