Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209298 --- Do we plan to close it when backporting to 1.4.x finished? - Gilbert Song On Oct. 4, 2018, 3:14 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68923/ > --- > > (Updated Oct. 4, 2018, 3:14 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-9283 > https://issues.apache.org/jira/browse/MESOS-9283 > > > Repository: mesos > > > Description > --- > > This patch updates the Docker library to consistently use the > overload of subprocess() which runs its binary via exec() > rather than through a shell. This makes it safe to use > os::kill() rather than os::killtree() when discarding > these commands, which this patch also accomplishes. > > > Diffs > - > > src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 > src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 > > > Diff: https://reviews.apache.org/r/68923/diff/2/ > > > Testing > --- > > `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"` > > > Thanks, > > Greg Mann > >
Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209248 --- PASS: Mesos patch 68923 was successfully built and tested. Reviews applied: `['68923']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2420/mesos-review-68923 - Mesos Reviewbot Windows On Oct. 4, 2018, 10:14 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68923/ > --- > > (Updated Oct. 4, 2018, 10:14 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-9283 > https://issues.apache.org/jira/browse/MESOS-9283 > > > Repository: mesos > > > Description > --- > > This patch updates the Docker library to consistently use the > overload of subprocess() which runs its binary via exec() > rather than through a shell. This makes it safe to use > os::kill() rather than os::killtree() when discarding > these commands, which this patch also accomplishes. > > > Diffs > - > > src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 > src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 > > > Diff: https://reviews.apache.org/r/68923/diff/2/ > > > Testing > --- > > `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"` > > > Thanks, > > Greg Mann > >
Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209247 --- Ship it! Ship It! - Jie Yu On Oct. 4, 2018, 10:14 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68923/ > --- > > (Updated Oct. 4, 2018, 10:14 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-9283 > https://issues.apache.org/jira/browse/MESOS-9283 > > > Repository: mesos > > > Description > --- > > This patch updates the Docker library to consistently use the > overload of subprocess() which runs its binary via exec() > rather than through a shell. This makes it safe to use > os::kill() rather than os::killtree() when discarding > these commands, which this patch also accomplishes. > > > Diffs > - > > src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 > src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 > > > Diff: https://reviews.apache.org/r/68923/diff/2/ > > > Testing > --- > > `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"` > > > Thanks, > > Greg Mann > >
Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209246 --- Ship it! Ship It! - Gilbert Song On Oct. 4, 2018, 3:14 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68923/ > --- > > (Updated Oct. 4, 2018, 3:14 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-9283 > https://issues.apache.org/jira/browse/MESOS-9283 > > > Repository: mesos > > > Description > --- > > This patch updates the Docker library to consistently use the > overload of subprocess() which runs its binary via exec() > rather than through a shell. This makes it safe to use > os::kill() rather than os::killtree() when discarding > these commands, which this patch also accomplishes. > > > Diffs > - > > src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 > src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 > > > Diff: https://reviews.apache.org/r/68923/diff/2/ > > > Testing > --- > > `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"` > > > Thanks, > > Greg Mann > >
Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/ --- (Updated Oct. 4, 2018, 10:14 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Summary (updated) - Updated Docker library to avoid 'os::killtree()' when discarding. Bugs: MESOS-9283 https://issues.apache.org/jira/browse/MESOS-9283 Repository: mesos Description (updated) --- This patch updates the Docker library to consistently use the overload of subprocess() which runs its binary via exec() rather than through a shell. This makes it safe to use os::kill() rather than os::killtree() when discarding these commands, which this patch also accomplishes. Diffs (updated) - src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 Diff: https://reviews.apache.org/r/68923/diff/2/ Changes: https://reviews.apache.org/r/68923/diff/1-2/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"` Thanks, Greg Mann
