Re: Review Request 69582: Added a test to verify a bug fix for the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/#review213715 --- PASS: Mesos patch 69582 was successfully built and tested. Reviews applied: `['70147', '69582']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2962/mesos-review-69582 - Mesos Reviewbot Windows On March 6, 2019, 4:11 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69582/ > --- > > (Updated March 6, 2019, 4:11 p.m.) > > > Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and > Meng Zhu. > > > Bugs: MESOS-9460 > https://issues.apache.org/jira/browse/MESOS-9460 > > > Repository: mesos > > > Description > --- > > Added a test to verify a bug fix for the master. > > > Diffs > - > > src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 > > > Diff: https://reviews.apache.org/r/69582/diff/2/ > > > Testing > --- > > Ran this test before and after the preceding fix. Before the fix, the test > fails reliably. After the fix, the test passes reliably. > > > Thanks, > > Greg Mann > >
Re: Review Request 69582: Added a test to verify a bug fix for the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/#review213705 --- PASS: Mesos patch 69582 was successfully built and tested. Reviews applied: `['70147', '69582']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2951/mesos-review-69582 - Mesos Reviewbot Windows On March 7, 2019, 12:11 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69582/ > --- > > (Updated March 7, 2019, 12:11 a.m.) > > > Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and > Meng Zhu. > > > Bugs: MESOS-9460 > https://issues.apache.org/jira/browse/MESOS-9460 > > > Repository: mesos > > > Description > --- > > Added a test to verify a bug fix for the master. > > > Diffs > - > > src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 > > > Diff: https://reviews.apache.org/r/69582/diff/2/ > > > Testing > --- > > Ran this test before and after the preceding fix. Before the fix, the test > fails reliably. After the fix, the test passes reliably. > > > Thanks, > > Greg Mann > >
Re: Review Request 69582: Added a test to verify a bug fix for the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/#review213511 --- Patch looks great! Reviews applied: [70147, 69582] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 7, 2019, 12:11 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69582/ > --- > > (Updated March 7, 2019, 12:11 a.m.) > > > Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and > Meng Zhu. > > > Bugs: MESOS-9460 > https://issues.apache.org/jira/browse/MESOS-9460 > > > Repository: mesos > > > Description > --- > > Added a test to verify a bug fix for the master. > > > Diffs > - > > src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 > > > Diff: https://reviews.apache.org/r/69582/diff/2/ > > > Testing > --- > > Ran this test before and after the preceding fix. Before the fix, the test > fails reliably. After the fix, the test passes reliably. > > > Thanks, > > Greg Mann > >
Re: Review Request 69582: Added a test to verify a bug fix for the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/ --- (Updated March 7, 2019, 12:11 a.m.) Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and Meng Zhu. Bugs: MESOS-9460 https://issues.apache.org/jira/browse/MESOS-9460 Repository: mesos Description --- Added a test to verify a bug fix for the master. Diffs (updated) - src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 Diff: https://reviews.apache.org/r/69582/diff/2/ Changes: https://reviews.apache.org/r/69582/diff/1-2/ Testing --- Ran this test before and after the preceding fix. Before the fix, the test fails reliably. After the fix, the test passes reliably. Thanks, Greg Mann
Re: Review Request 69582: Added a test to verify a bug fix for the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/#review211764 --- Ship it! Looks good to me, except that the commit message sounds exceptionally vague ;) Maybe we can add a very brief description like "a bug that resulted in a race between the allocator update and an `UpdateSlaveMessage`"? - Benno Evers On Dec. 18, 2018, 9:08 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69582/ > --- > > (Updated Dec. 18, 2018, 9:08 a.m.) > > > Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and > Meng Zhu. > > > Bugs: MESOS-9460 > https://issues.apache.org/jira/browse/MESOS-9460 > > > Repository: mesos > > > Description > --- > > Added a test to verify a bug fix for the master. > > > Diffs > - > > src/tests/master_tests.cpp 3bff7a13bb8013ef91b72c14ace23ee94bc190e9 > > > Diff: https://reviews.apache.org/r/69582/diff/1/ > > > Testing > --- > > Ran this test before and after the preceding fix. Before the fix, the test > fails reliably. After the fix, the test passes reliably. > > > Thanks, > > Greg Mann > >
Re: Review Request 69582: Added a test to verify a bug fix for the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/#review211389 --- PASS: Mesos patch 69582 was successfully built and tested. Reviews applied: `['69581', '69582']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2719/mesos-review-69582 - Mesos Reviewbot Windows On Dec. 18, 2018, 9:08 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69582/ > --- > > (Updated Dec. 18, 2018, 9:08 a.m.) > > > Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and > Meng Zhu. > > > Bugs: MESOS-9460 > https://issues.apache.org/jira/browse/MESOS-9460 > > > Repository: mesos > > > Description > --- > > Added a test to verify a bug fix for the master. > > > Diffs > - > > src/tests/master_tests.cpp 3bff7a13bb8013ef91b72c14ace23ee94bc190e9 > > > Diff: https://reviews.apache.org/r/69582/diff/1/ > > > Testing > --- > > Ran this test before and after the preceding fix. Before the fix, the test > fails reliably. After the fix, the test passes reliably. > > > Thanks, > > Greg Mann > >
