Re: Review Request 69726: Disabled MasterAPITest.AgentUpdatesUponOfferGone on Windows.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review211936
---




src/tests/api_tests.cpp
Line 4830 (original), 4830 (patched)


Could you explain what in particular is broken here (e.g., by linking a 
ticket)? Resource provider managers use in memory storage for their state which 
should be fine here (e.g., no agent restart). The message you are quoting in 
the commit message is just for user information.

Right now it is hard to get a grasp for what needs to be done for this test 
to be enabled again.


- Benjamin Bannier


On Jan. 11, 2019, 11:46 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69726/
> ---
> 
> (Updated Jan. 11, 2019, 11:46 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test was broken on Windows due to the following:
> 
> W0111 20:44:47.175993 16980 slave.cpp:8949] Persisting resource
>   provider manager state is not supported on Windows
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849 
> 
> 
> Diff: https://reviews.apache.org/r/69726/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 69726: Disabled MasterAPITest.AgentUpdatesUponOfferGone on Windows.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review211931
---



PASS: Mesos patch 69726 was successfully built and tested.

Reviews applied: `['69726']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2768/mesos-review-69726

- Mesos Reviewbot Windows


On Jan. 11, 2019, 10:46 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69726/
> ---
> 
> (Updated Jan. 11, 2019, 10:46 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test was broken on Windows due to the following:
> 
> W0111 20:44:47.175993 16980 slave.cpp:8949] Persisting resource
>   provider manager state is not supported on Windows
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849 
> 
> 
> Diff: https://reviews.apache.org/r/69726/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 69726: Disabled MasterAPITest.AgentUpdatesUponOfferGone on Windows.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/#review211916
---


Ship it!




Ship It!

- Gastón Kleiman


On Jan. 11, 2019, 2:46 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69726/
> ---
> 
> (Updated Jan. 11, 2019, 2:46 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test was broken on Windows due to the following:
> 
> W0111 20:44:47.175993 16980 slave.cpp:8949] Persisting resource
>   provider manager state is not supported on Windows
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849 
> 
> 
> Diff: https://reviews.apache.org/r/69726/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>