Re: Review Request 69986: Added a log line to isolator for simplified debugging.

2019-02-15 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69986/#review212882
---




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 884-886 (patched)


Hey Alex, IIUC this log will only be printed out if there are more than one 
executors sharing the same persistent volume. We can keep this log though, it 
may not be too meaningful once we have the GidManager (merge next week).

> Shall we add a log line for the case when the task is running under a 
different user than its default executor?

Per your comment, nested container will not exercise this function. So not 
related.


- Gilbert Song


On Feb. 15, 2019, 12:54 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69986/
> ---
> 
> (Updated Feb. 15, 2019, 12:54 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a log line to isolator for simplified debugging.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 2a9ea448d7f963f86e8b2909d83e82b498e4104c 
> 
> 
> Diff: https://reviews.apache.org/r/69986/diff/1/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 69986: Added a log line to isolator for simplified debugging.

2019-02-15 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69986/
---

(Updated Feb. 15, 2019, 8:54 a.m.)


Review request for mesos, Andrei Budnik and Gilbert Song.


Summary (updated)
-

Added a log line to isolator for simplified debugging.


Repository: mesos


Description (updated)
---

Added a log line to isolator for simplified debugging.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
2a9ea448d7f963f86e8b2909d83e82b498e4104c 


Diff: https://reviews.apache.org/r/69986/diff/1/


Testing
---

None: not a functional change.


Thanks,

Alexander Rukletsov