Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-23 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71479/#review217920
---



Bad patch!

Reviews applied: [71515, 71516, 71476, 71479]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71479"]

Error:
..
6,profile)]:32; disk(allocated: 
role)[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; disk(allocated: 
role)[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32 to cpus(allocated: 
role)(reservations: [(DYNAMIC,role)]):4; mem(allocated: role)(reservations: 
[(DYNAMIC,role)]):128; disk(allocated: role)(reservations: 
[(STATIC,role)]):288; disk(allocated: 
role)[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32; disk(allocated: 
role)[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; disk(allocated: 
role)[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; disk(allocated: 
role)[RAW(,,profile)]:64; disk(allocated: role)(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; disk(allocated: 
role)(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64; cpus(allocated: 
role):10; mem(allocated: role):320; disk(allocated: role):64
I0923 22:18:37.979696 18655 hierarchical.cpp:1712] Allocation paused
I0923 22:18:37.980072 18655 hierarchical.cpp:1511] Recovered disk(allocated: 
role)(reservations: [(STATIC,role)]):128 (total: cpus:10; mem:320; disk:64; 
cpus(reservations: [(DYNAMIC,role)]):4; mem(reservations: 
[(DYNAMIC,role)]):128; disk(reservations: [(STATIC,role)]):288; 
disk[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32; 
disk[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; 
disk[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; 
disk[RAW(,,profile)]:64; disk(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; 
disk(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64, offered or 
allocated: cpus(allocated: role)(reservations: [(DYNAMIC,role)]):4; 
mem(allocated: role)(reservations: [(DYNAMIC,role)]):128; disk(allocated: 
role)(reservations: [(STATIC,role)]):160; disk(allocated: 
role)[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32; disk(allocated: 
role)[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profil
 e)]:32; disk(allocated: 
role)[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; disk(allocated: 
role)[RAW(,,profile)]:64; disk(allocated: role)(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; disk(allocated: 
role)(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64; cpus(allocated: 
role):10; mem(allocated: role):320; disk(allocated: role):64) on agent 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-S0 from framework 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-
I0923 22:18:37.981135 18655 hierarchical.cpp:1511] Recovered cpus(allocated: 
role)(reservations: [(DYNAMIC,role)]):4; mem(allocated: role)(reservations: 
[(DYNAMIC,role)]):128; disk(allocated: role)(reservations: 
[(STATIC,role)]):160; disk(allocated: 
role)[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32; disk(allocated: 
role)[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; disk(allocated: 
role)[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; disk(allocated: 
role)[RAW(,,profile)]:64; disk(allocated: role)(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; disk(allocated: 
role)(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64; cpus(allocated: 
role):10; mem(allocated: role):320; disk(allocated: role):64 (total: cpus:10; 
mem:320; disk:64; cpus(reservations: [(DYNAMIC,role)]):4; mem(reservations: 
[(DYNAMIC,role)]):128; disk(reservations: [(STATIC,role)]):288; 
disk[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,pro
 file)]:32; disk[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; 
disk[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; 
disk[RAW(,,profile)]:64; disk(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; 
disk(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64, offered or 
allocated: {}) on agent 203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-S0 from framework 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-
I0923 22:18:37.983225 18655 hierarchical.cpp:1560] Framework 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6- filtered agent 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-S0 for 5secs
I0923 22:18:37.983539 18655 hierarchical.cpp:1722] Allocation resumed
I0923 22:18:37.985363 18640 slave.cpp:924] Agent terminating
I0923 22:18:37.985481 18658 master.cpp:1411] Framework 

Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71479/#review217875
---



Patch looks great!

Reviews applied: [71515, 71516, 71476, 71479]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 12, 2019, 10:51 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71479/
> ---
> 
> (Updated Sept. 12, 2019, 10:51 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-621
> https://issues.apache.org/jira/browse/MESOS-621
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to ensure resources are recovered during agent removal.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f2e2b259af9920133dd22a5b03774d7035821dc 
> 
> 
> Diff: https://reviews.apache.org/r/71479/diff/1/
> 
> 
> Testing
> ---
> 
> Failed on master.
> Pass after r/71476
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-18 Thread Andrei Sekretenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71479/#review217827
---


Ship it!




Ship It!

- Andrei Sekretenko


On Sept. 12, 2019, 10:51 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71479/
> ---
> 
> (Updated Sept. 12, 2019, 10:51 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-621
> https://issues.apache.org/jira/browse/MESOS-621
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to ensure resources are recovered during agent removal.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f2e2b259af9920133dd22a5b03774d7035821dc 
> 
> 
> Diff: https://reviews.apache.org/r/71479/diff/1/
> 
> 
> Testing
> ---
> 
> Failed on master.
> Pass after r/71476
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71479/#review217715
---



Patch looks great!

Reviews applied: [71459, 71460, 71476, 71479]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 12, 2019, 10:51 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71479/
> ---
> 
> (Updated Sept. 12, 2019, 10:51 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-621
> https://issues.apache.org/jira/browse/MESOS-621
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to ensure resources are recovered during agent removal.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f2e2b259af9920133dd22a5b03774d7035821dc 
> 
> 
> Diff: https://reviews.apache.org/r/71479/diff/1/
> 
> 
> Testing
> ---
> 
> Failed on master.
> Pass after r/71476
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>