Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Qian Zhang]

> On March 19, 2020, 11:15 a.m., Greg Mann wrote:
> > src/tests/containerizer/cgroups_isolator_tests.cpp
> > Lines 1177 (patched)
> > 
> >
> > Could you move this to the end of the test so we're just paused for the 
> > entire test body?

I tried it, but this test will fail:
```
../../src/tests/containerizer/cgroups_isolator_tests.cpp:1263: Failure
Failed to wait 15secs for killedUpdate1
```

I think that is because default executor uses `delay()` to wait 3 seconds for 
task to terminate 
(https://github.com/apache/mesos/blob/1.9.0/src/launcher/default_executor.cpp#L1153:L1163
 ), if we do not call `Clock::resume()`, then that delay() may not work as we 
expect:
```
I0319 03:26:25.972328 41296 default_executor.cpp:1171] Scheduling escalation to 
SIGKILL in 3secs from now
I0319 03:26:25.974565 41219 http.cpp:1405] HTTP POST for /slave(1)/api/v1 from 
10.0.50.220:51150
I0319 03:26:25.974958 41219 http.cpp:3651] Processing KILL_NESTED_CONTAINER 
call for container 
'fd32e39c-f362-4d58-a364-c2f9a8e1fea2.6c77f255-cfb5-4c19-b37c-a7a6fd7d0eec'
I0319 03:26:25.975901 41220 containerizer.cpp:3027] Sending Terminated to 
container 
fd32e39c-f362-4d58-a364-c2f9a8e1fea2.6c77f255-cfb5-4c19-b37c-a7a6fd7d0eec in 
RUNNING state
I0319 03:26:28.973389 41338 default_executor.cpp:1249] Task 
'f3873537-a8ec-4328-874a-2fec0f5daffb' running in child container 
fd32e39c-f362-4d58-a364-c2f9a8e1fea2.6c77f255-cfb5-4c19-b37c-a7a6fd7d0eec did 
not terminate after 3secs, sending SIGKILL to the container
```


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/#review219993
---


On March 18, 2020, 10:54 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71983/
> ---
> 
> (Updated March 18, 2020, 10:54 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10050
> https://issues.apache.org/jira/browse/MESOS-10050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/71983/diff/7/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/#review219993
---


Fix it, then Ship it!





src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 1177 (patched)


Could you move this to the end of the test so we're just paused for the 
entire test body?


- Greg Mann


On March 18, 2020, 2:54 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71983/
> ---
> 
> (Updated March 18, 2020, 2:54 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10050
> https://issues.apache.org/jira/browse/MESOS-10050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/71983/diff/7/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/#review219992
---




src/tests/containerizer/cgroups_isolator_tests.cpp
Line 1173 (original), 1177 (patched)


Instead of resuming, can we advance the clock manually for the subsequent 
offers as well?


- Greg Mann


On March 18, 2020, 2:54 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71983/
> ---
> 
> (Updated March 18, 2020, 2:54 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10050
> https://issues.apache.org/jira/browse/MESOS-10050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/71983/diff/7/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/
---

(Updated March 18, 2020, 10:54 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71983/diff/7/

Changes: https://reviews.apache.org/r/71983/diff/6-7/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/#review219979
---




src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 900-902 (patched)


This could be racy; the expectation will be violated if we get another 
offer before the next `EXPECT_CALL(*scheduler, offers(_, _))`. We should either 
pause the clock and manually advance it to trigger offers (preferred), or add a 
`.WillRepeatedly(Return());` to this expectation.


- Greg Mann


On March 18, 2020, 2:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71983/
> ---
> 
> (Updated March 18, 2020, 2:01 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10050
> https://issues.apache.org/jira/browse/MESOS-10050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/71983/diff/6/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/
---

(Updated March 18, 2020, 10:01 a.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Checked task's resource limits.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71983/diff/6/

Changes: https://reviews.apache.org/r/71983/diff/5-6/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/
---

(Updated March 17, 2020, 3:02 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71983/diff/5/

Changes: https://reviews.apache.org/r/71983/diff/4-5/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/
---

(Updated March 16, 2020, 9:52 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Minor change.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71983/diff/4/

Changes: https://reviews.apache.org/r/71983/diff/3-4/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/
---

(Updated March 16, 2020, 5:15 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71983/diff/3/

Changes: https://reviews.apache.org/r/71983/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/
---

(Updated March 7, 2020, 5:02 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71983/diff/2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/#review219804
---




src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 716 (patched)


s/memory's/memory/



src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 961 (patched)


This looks racy; we shouldn't rely on the running wall clock to trigger 
offers in a test like this. Could you pause the clock and advance manually to 
trigger offers? There are some existing examples in the tests of this; you 
could check 
'SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability'.


- Greg Mann


On Jan. 13, 2020, 8:06 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71983/
> ---
> 
> (Updated Jan. 13, 2020, 8:06 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10050
> https://issues.apache.org/jira/browse/MESOS-10050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/71983/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/#review219276
---



Bad patch!

Reviews applied: [71855, 71931, 71856, 71858, 71884, 71885, 71886, 71943, 
71944, 71950, 71951, 71952, 71953, 71955, 71956, 71983]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71983"]

Error:
..
TDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" 
-DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 
-DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 
-DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 
-I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 
-I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 
-I../protobuf-3.5.0/src -I../rapidjson-1
 .1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security -fstack-protector 
-fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/grpc.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-grpc.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
 -I../boost-1.65.0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 
-I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 
-I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 
-I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include 
-I../../../3rdparty/libprocess/../stout/include -DLIBPROCESS_ALLOW_JEMALLOC 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -Wall 
-Wsign-compare -Wformat-security -fstack-protector -fPIC -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/authenticator.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-authenticator.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DENABLE_NVML=1 
-DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 
-DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 
-DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
 -I../boost-1.65.0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 
-I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 
-I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 
-I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include 

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/#review219238
---



Bad patch!

Reviews applied: [71855, 71931, 71856, 71858, 71884, 71885, 71886, 71943, 
71944, 71950, 71951, 71952, 71953, 71955, 71956, 71983]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71983"]

Error:
..
 for 5secs
I0113 14:42:50.135164 18746 slave.cpp:8649] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: fd3922bf-da98-42dc-9580-c844ec08d423) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0113 14:42:50.141620 18746 slave.cpp:9102] Updating the state of operation 
with no ID (uuid: fd3922bf-da98-42dc-9580-c844ec08d423) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I0113 14:42:50.141710 18746 slave.cpp:8856] Forwarding status update of 
operation with no ID (operation_uuid: fd3922bf-da98-42dc-9580-c844ec08d423) for 
an operator API call
I0113 14:42:50.142206 18740 master.cpp:11789] Updating the state of operation 
'' (uuid: fd3922bf-da98-42dc-9580-c844ec08d423) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I0113 14:42:50.143069 18746 slave.cpp:4504] Ignoring new checkpointed resources 
and operations identical to the current version
I0113 14:42:50.145885 18742 master.cpp:12137] Sending operation '' (uuid: 
610118ba-c9c5-4038-af95-618974e68148) to agent 
b00a682f-f28c-4094-b628-fc274d7f3dab-S0 at slave(1252)@172.17.0.2:38425 
(c27cf6ba285d)
I0113 14:42:50.146699 18750 slave.cpp:4504] Ignoring new checkpointed resources 
and operations identical to the current version
I0113 14:42:50.149614 18735 provider.cpp:498] Received 
ACKNOWLEDGE_OPERATION_STATUS event
I0113 14:42:50.150440 18735 status_update_manager_process.hpp:252] Received 
operation status update acknowledgement (UUID: 
84eb7230-1cb5-4427-be3e-4d06541a4c49) for stream 
fd3922bf-da98-42dc-9580-c844ec08d423
I0113 14:42:50.150903 18735 status_update_manager_process.hpp:929] 
Checkpointing ACK for operation status update OPERATION_FINISHED (Status UUID: 
84eb7230-1cb5-4427-be3e-4d06541a4c49) for operation UUID 
fd3922bf-da98-42dc-9580-c844ec08d423 on agent 
b00a682f-f28c-4094-b628-fc274d7f3dab-S0
I0113 14:42:50.151826 18751 provider.cpp:498] Received APPLY_OPERATION event
I0113 14:42:50.151877 18751 provider.cpp:1351] Received CREATE operation '' 
(uuid: 610118ba-c9c5-4038-af95-618974e68148)
I0113 14:42:50.152490 18734 master.cpp:5959] Processing REVIVE call for 
framework b00a682f-f28c-4094-b628-fc274d7f3dab- (default) at 
scheduler-f1e918fb-f3fd-4568-b807-112ca8f47205@172.17.0.2:38425
I0113 14:42:50.153231 18734 hierarchical.cpp:1721] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
b00a682f-f28c-4094-b628-fc274d7f3dab-
I0113 14:42:50.155328 18734 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.775707ms
I0113 14:42:50.156787 18734 master.cpp:9975] Sending offers [ 
b00a682f-f28c-4094-b628-fc274d7f3dab-O4 ] to framework 
b00a682f-f28c-4094-b628-fc274d7f3dab- (default) at 
scheduler-f1e918fb-f3fd-4568-b807-112ca8f47205@172.17.0.2:38425
I0113 14:42:50.158025 18734 sched.cpp:934] Scheduler::resourceOffers took 
123096ns
I0113 14:42:50.171032 18743 hierarchical.cpp:1853] Performed allocation for 1 
agents in 389864ns
I0113 14:42:50.235703 18735 status_update_manager_process.hpp:490] Cleaning up 
operation status update stream fd3922bf-da98-42dc-9580-c844ec08d423
I0113 14:42:50.295411 18739 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
4b993a71-5380-4d75-b388-1002ffdbfee5) for operation UUID 
610118ba-c9c5-4038-af95-618974e68148 on agent 
b00a682f-f28c-4094-b628-fc274d7f3dab-S0
I0113 14:42:50.296057 18739 status_update_manager_process.hpp:414] Creating 
operation status update stream 610118ba-c9c5-4038-af95-618974e68148 
checkpoint=true
I0113 14:42:50.296684 18739 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: 4b993a71-5380-4d75-b388-1002ffdbfee5) for operation UUID 
610118ba-c9c5-4038-af95-618974e68148 on agent 
b00a682f-f28c-4094-b628-fc274d7f3dab-S0
I0113 14:42:50.354960 18739 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
4b993a71-5380-4d75-b388-1002ffdbfee5) for operation UUID 
610118ba-c9c5-4038-af95-618974e68148 on agent 
b00a682f-f28c-4094-b628-fc274d7f3dab-S0
I0113 14:42:50.356869 18731 http_connection.hpp:131] Sending 

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/
---

(Updated Jan. 13, 2020, 4:06 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10050
https://issues.apache.org/jira/browse/MESOS-10050


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
f72e6cdab417368e63349915114aeed586e0ef0e 


Diff: https://reviews.apache.org/r/71983/diff/2/

Changes: https://reviews.apache.org/r/71983/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/#review219225
---



Patch looks great!

Reviews applied: [71855, 71931, 71856, 71858, 71884, 71885, 71886, 71943, 
71944, 71950, 71951, 71952, 71953, 71955, 71956, 71983]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Jan. 11, 2020, 2:59 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71983/
> ---
> 
> (Updated Jan. 11, 2020, 2:59 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10050
> https://issues.apache.org/jira/browse/MESOS-10050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> f72e6cdab417368e63349915114aeed586e0ef0e 
> 
> 
> Diff: https://reviews.apache.org/r/71983/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>