Re: Review Request 72410: Updated existing documentation for resource limits.

2020-05-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220669
---


Ship it!




Ship It!

- Qian Zhang


On May 7, 2020, 8:35 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated May 7, 2020, 8:35 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md a77a9df0b4f59a65b65fe4a53c737f89571f9fbd 
>   docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-05-06 Thread Greg Mann


> On April 28, 2020, 9:59 a.m., Qian Zhang wrote:
> > docs/task-state-reasons.md
> > Lines 126-133 (patched)
> > 
> >
> > If we revert the changes about 
> > `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in 
> > https://reviews.apache.org/r/72442 , then we do not need to update this doc.
> 
> Greg Mann wrote:
> I'm not yet convinced that we should remove the new reason, I'd like to 
> better understand why it's not being sent properly and hopefully fix it.

OK, removed!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220519
---


On May 7, 2020, 12:35 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated May 7, 2020, 12:35 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md a77a9df0b4f59a65b65fe4a53c737f89571f9fbd 
>   docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-05-06 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/
---

(Updated May 7, 2020, 12:35 a.m.)


Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
Harper.


Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115


Repository: mesos


Description
---

Updated existing documentation for resource limits.


Diffs (updated)
-

  docs/nested-container-and-task-group.md 
3325ff8e3a694ede82e22b24ab258742746c0bb7 
  docs/scheduler-http-api.md a77a9df0b4f59a65b65fe4a53c737f89571f9fbd 
  docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0 


Diff: https://reviews.apache.org/r/72410/diff/3/

Changes: https://reviews.apache.org/r/72410/diff/2-3/


Testing
---


Thanks,

Greg Mann



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-28 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220536
---



Patch looks great!

Reviews applied: [72408, 72409, 72410]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 28, 2020, 12:59 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated April 28, 2020, 12:59 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
>   docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347 
>   docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-28 Thread Greg Mann


> On April 28, 2020, 9:59 a.m., Qian Zhang wrote:
> > docs/task-state-reasons.md
> > Lines 126-133 (patched)
> > 
> >
> > If we revert the changes about 
> > `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in 
> > https://reviews.apache.org/r/72442 , then we do not need to update this doc.

I'm not yet convinced that we should remove the new reason, I'd like to better 
understand why it's not being sent properly and hopefully fix it.


> On April 28, 2020, 9:59 a.m., Qian Zhang wrote:
> > docs/upgrades.md
> > Lines 52 (patched)
> > 
> >
> > I think we'd better to have a general description about the task 
> > resource limits feature (like how [quota 
> > limits](https://github.com/apache/mesos/blob/master/docs/upgrades.md#1-9-x-quota-guarantees)
> >  feature was described) rather than just mention CPU limits here.

I think this document isn't intended to be a changelog, but rather a guide for 
operators who need to upgrade a cluster. So, I think we should only mention 
things here which an operator might run into when upgrading a cluster: changes 
in existing behavior, possible issues that could occur, etc.

Regarding the quota example, IMHO the passage on quota limits could be reduced 
to the following text:

```
* Quota guarantees, while still functional in Mesos 1.9, are now deprecated. In 
the future when optimistic offers are fully implemented, a combination of the 
newly-added quota limits and priority-based preemption will be simpler to use.
```


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220519
---


On April 28, 2020, 12:59 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated April 28, 2020, 12:59 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
>   docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347 
>   docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-28 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220519
---




docs/task-state-reasons.md
Lines 126-133 (patched)


If we revert the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` 
in https://reviews.apache.org/r/72442 , then we do not need to update this doc.



docs/upgrades.md
Lines 52 (patched)


I think we'd better to have a general description about the task resource 
limits feature (like how [quota 
limits](https://github.com/apache/mesos/blob/master/docs/upgrades.md#1-9-x-quota-guarantees)
 feature was described) rather than just mention CPU limits here.


- Qian Zhang


On April 28, 2020, 8:59 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated April 28, 2020, 8:59 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
>   docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347 
>   docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-27 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220511
---



Bad patch!

Reviews applied: [72408, 72409, 72410]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72410"]

Error:
ubuntu-16.04: Pulling from mesos/mesos-build
18d680d61657: Pulling fs layer
0addb6fece63: Pulling fs layer
78e58219b215: Pulling fs layer
eb6959a66df2: Pulling fs layer
1105027a5560: Pulling fs layer
c36946130a38: Pulling fs layer
6a6a5e68faab: Pulling fs layer
80e07249924c: Pulling fs layer
c4c63e2501db: Pulling fs layer
668b207c2829: Pulling fs layer
ed76dddad568: Pulling fs layer
c36946130a38: Waiting
6a6a5e68faab: Waiting
80e07249924c: Waiting
c4c63e2501db: Waiting
eb6959a66df2: Waiting
ed76dddad568: Waiting
668b207c2829: Waiting
0addb6fece63: Verifying Checksum
0addb6fece63: Download complete
78e58219b215: Download complete
eb6959a66df2: Verifying Checksum
eb6959a66df2: Download complete
18d680d61657: Download complete
c36946130a38: Verifying Checksum
c36946130a38: Download complete
80e07249924c: Verifying Checksum
80e07249924c: Download complete
c4c63e2501db: Verifying Checksum
c4c63e2501db: Download complete
6a6a5e68faab: Verifying Checksum
6a6a5e68faab: Download complete
668b207c2829: Verifying Checksum
668b207c2829: Download complete
ed76dddad568: Download complete
18d680d61657: Pull complete
0addb6fece63: Pull complete
78e58219b215: Pull complete
eb6959a66df2: Pull complete
1105027a5560: Verifying Checksum
1105027a5560: Download complete
1105027a5560: Pull complete
c36946130a38: Pull complete
6a6a5e68faab: Pull complete
80e07249924c: Pull complete
c4c63e2501db: Pull complete
668b207c2829: Pull complete
ed76dddad568: Pull complete
Digest: sha256:fa967cbcfb44f55708a3cbc87f245c6d29dd891464db558af56a03ee321526bb
Status: Downloaded newer image for mesos/mesos-build:ubuntu-16.04
docker.io/mesos/mesos-build:ubuntu-16.04
Cloning into '/tmp/SRC'...
Note: checking out '92d2732a0df2e86e65066346f81a25d85c36fa2d'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b 

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --warnings=all -I m4
autoreconf: configure.ac: tracing
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross 
compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: running: libtoolize --copy
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /usr/bin/autoconf --warnings=all
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross 
compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --no-force --warnings=all
configure.ac:50: installing './ar-lib'
configure.ac:34: installing './compile'
configure.ac:24: installing './config.guess'
configure.ac:24: installing './config.sub'
configure.ac:46: installing './install-sh'
configure.ac:46: installing './missing'
3rdparty/Makefile.am:307: warning: source file '$(HTTP_PARSER)/http_parser.c' 
is in a subdirectory,
3rdparty/Makefile.am:307: but option 'subdir-objects' is disabled

Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-27 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/
---

(Updated April 28, 2020, 12:59 a.m.)


Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
Harper.


Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115


Repository: mesos


Description
---

Updated existing documentation for resource limits.


Diffs (updated)
-

  docs/nested-container-and-task-group.md 
3325ff8e3a694ede82e22b24ab258742746c0bb7 
  docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
  docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347 
  docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0 


Diff: https://reviews.apache.org/r/72410/diff/2/

Changes: https://reviews.apache.org/r/72410/diff/1-2/


Testing
---


Thanks,

Greg Mann



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-27 Thread Greg Mann


> On April 22, 2020, 2:02 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md
> > Lines 74 (patched)
> > 
> >
> > I see https://reviews.apache.org/r/72409 already has the content of 
> > this section, so can we avoid duplicating them here?

I think that this information belongs in both sections, which is why I included 
it here. To be honest, I'm not convinced that the 
'nested-container-and-task-group.md' document is very useful as currently 
written, but I felt obligated to add this information here since it is relevant 
to task groups. I would suggest that we leave it as-is.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220423
---


On April 21, 2020, 8:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated April 21, 2020, 8:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-22 Thread Tim Harper

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220430
---


Ship it!




- Tim Harper


On April 21, 2020, 8:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated April 21, 2020, 8:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-22 Thread Tim Harper

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220429
---




docs/nested-container-and-task-group.md
Line 65 (original), 65 (patched)


(see container.linux_info.share_cgroups field)


- Tim Harper


On April 21, 2020, 8:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated April 21, 2020, 8:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-22 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220423
---




docs/nested-container-and-task-group.md
Lines 74 (patched)


I see https://reviews.apache.org/r/72409 already has the content of this 
section, so can we avoid duplicating them here?


- Qian Zhang


On April 22, 2020, 4:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated April 22, 2020, 4:01 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-21 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220407
---



Patch looks great!

Reviews applied: [72408, 72409, 72410]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 21, 2020, 8:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> ---
> 
> (Updated April 21, 2020, 8:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim 
> Harper.
> 
> 
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated existing documentation for resource limits.
> 
> 
> Diffs
> -
> 
>   docs/nested-container-and-task-group.md 
> 3325ff8e3a694ede82e22b24ab258742746c0bb7 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72410/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>