Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-05-14 Thread Niklas Nielsen


 On April 22, 2015, 1:53 a.m., Adam B wrote:
  docs/modules.md, lines 165-166
  https://reviews.apache.org/r/33372/diff/2/?file=938440#file938440line165
 
  I still think we need a note in upgrades.md since this is a hook API 
  change when upgrading.

Done :)


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33372/#review81133
---


On May 14, 2015, 10:06 a.m., Niklas Nielsen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/33372/
 ---
 
 (Updated May 14, 2015, 10:06 a.m.)
 
 
 Review request for mesos and Adam B.
 
 
 Bugs: MESOS-2622
 https://issues.apache.org/jira/browse/MESOS-2622
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   docs/modules.md d0391ced9eac35e7ed371dfbd981675139fabaa5 
   docs/upgrades.md 2a15694607c079ad95ef6cf7f1490872ab9a5976 
 
 Diff: https://reviews.apache.org/r/33372/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Niklas Nielsen
 




Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-05-14 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33372/#review83803
---


Patch looks great!

Reviews applied: [30961, 30962, 31016, 31028, 32948, 31017, 33372]

All tests passed.

- Mesos ReviewBot


On May 14, 2015, 5:06 p.m., Niklas Nielsen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/33372/
 ---
 
 (Updated May 14, 2015, 5:06 p.m.)
 
 
 Review request for mesos and Adam B.
 
 
 Bugs: MESOS-2622
 https://issues.apache.org/jira/browse/MESOS-2622
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   docs/modules.md d0391ced9eac35e7ed371dfbd981675139fabaa5 
   docs/upgrades.md 2a15694607c079ad95ef6cf7f1490872ab9a5976 
 
 Diff: https://reviews.apache.org/r/33372/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Niklas Nielsen