Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 6:04 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs (updated) - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/http.cpp a052e55 src/master/master.hpp 1dfc947 src/master/master.cpp 4b60e63 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 5:33 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs (updated) - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/http.cpp a052e55 src/master/master.hpp 1dfc947 src/master/master.cpp 4b60e63 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
> On Sept. 9, 2015, 10:46 p.m., Adam B wrote: > > Looks great! I'm not sure if we needed to change all the internal > > references to remove .json, since we're keeping that endpoint for > > compatibility, but it's good that we're testing the new endpoint. > > > > Did you test to verify that the `.json` endpoints still work? Yes I tried the .json endpoints - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review98275 --- On Sept. 10, 2015, 5:33 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36125/ > --- > > (Updated Sept. 10, 2015, 5:33 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-2719 > https://issues.apache.org/jira/browse/MESOS-2719 > > > Repository: mesos-incubating > > > Description > --- > > Removing json extension for HTTP endpoints in master > > > Diffs > - > > src/cli/mesos-cat 73dc63e > src/cli/mesos-ps ee14d51 > src/cli/mesos-scp 77b8557 > src/cli/mesos-tail 256a804 > src/master/constants.hpp c3fe140 > src/master/http.cpp a052e55 > src/master/master.hpp 1dfc947 > src/master/master.cpp 4b60e63 > src/tests/fault_tolerance_tests.cpp 89cb18b > src/tests/master_tests.cpp 8a6b98b > src/webui/master/static/js/controllers.js 3445028 > > Diff: https://reviews.apache.org/r/36125/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 9:23 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs (updated) - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/http.cpp 73e8857 src/master/master.hpp 1dfc947 src/master/master.cpp 4b60e63 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 9:27 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs (updated) - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/master.hpp 1dfc947 src/master/master.cpp 4b60e63 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review98335 --- Bad patch! Reviews applied: [36125] Failed command: ./support/apply-review.sh -n -r 36125 Error: 2015-09-10 02:47:43 URL:https://reviews.apache.org/r/36125/diff/raw/ [13754/13754] -> "36125.patch" [1] error: patch failed: src/master/master.hpp:807 error: src/master/master.hpp: patch does not apply error: patch failed: src/master/master.cpp:779 error: src/master/master.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Sept. 9, 2015, 7:58 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36125/ > --- > > (Updated Sept. 9, 2015, 7:58 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-2719 > https://issues.apache.org/jira/browse/MESOS-2719 > > > Repository: mesos-incubating > > > Description > --- > > Removing json extension for HTTP endpoints in master > > > Diffs > - > > src/cli/mesos-cat 73dc63e > src/cli/mesos-ps ee14d51 > src/cli/mesos-scp 77b8557 > src/cli/mesos-tail 256a804 > src/master/constants.hpp c3fe140 > src/master/http.cpp 37d76ee > src/master/master.hpp 0432842 > src/master/master.cpp 95207d2 > src/tests/fault_tolerance_tests.cpp 89cb18b > src/tests/master_tests.cpp 8a6b98b > src/webui/master/static/js/controllers.js 3445028 > > Diff: https://reviews.apache.org/r/36125/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Aug. 23, 2015, 5:49 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs (updated) - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/http.cpp 37d76ee src/master/master.hpp 0432842 src/master/master.cpp 95207d2 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make checl Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Aug. 23, 2015, 5:50 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp c3fe140 src/master/http.cpp 37d76ee src/master/master.hpp 0432842 src/master/master.cpp 95207d2 src/tests/fault_tolerance_tests.cpp 89cb18b src/tests/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing (updated) --- make check Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review95501 --- After @vinodkone (correct) comments, there has been no activity on this and other associated patches. Can you please update or discard, as appropriate? - Marco Massenzio On July 2, 2015, 7:42 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated July 2, 2015, 7:42 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp 7cec18b src/master/http.cpp 2be613b src/master/master.hpp af83d3e src/master/master.cpp a7486d8 src/tests/fault_tolerance_tests.cpp 1070ccf src/tests/master_tests.cpp 57721b7 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make checl Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review90381 --- Patch looks great! Reviews applied: [36125] All tests passed. - Mesos ReviewBot On July 2, 2015, 7:42 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated July 2, 2015, 7:42 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp 7cec18b src/master/http.cpp 2be613b src/master/master.hpp af83d3e src/master/master.cpp a7486d8 src/tests/fault_tolerance_tests.cpp 1070ccf src/tests/master_tests.cpp 57721b7 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make checl Thanks, Isabel Jimenez
Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp 7cec18b src/master/http.cpp 2be613b src/master/master.hpp af83d3e src/master/master.cpp a7486d8 src/tests/fault_tolerance_tests.cpp 1070ccf src/tests/master_tests.cpp 57721b7 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make checl Thanks, Isabel Jimenez
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review90245 --- We cannot just rename the endpoints. That's a breaking API change!! I would recommend adding new endpoints with the same name but without .json extension in one release, send a deprecation notice to the dev list and remove the .json endpoints in the next release. - Vinod Kone On July 2, 2015, 7:42 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated July 2, 2015, 7:42 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp 7cec18b src/master/http.cpp 2be613b src/master/master.hpp af83d3e src/master/master.cpp a7486d8 src/tests/fault_tolerance_tests.cpp 1070ccf src/tests/master_tests.cpp 57721b7 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make checl Thanks, Isabel Jimenez
