Re: Review Request 36181: Port CFS support to Docker Containerizer

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/#review145638
---




src/slave/containerizer/docker.cpp (lines 145 - 147)


Maybe just

```
return Error("Docker with CFS support requires docker 1.7+: " + 
validateResult.error());
```



src/slave/containerizer/docker.cpp (lines 293 - 296)


Do we want to handle `cpu-period` flag only in this location? 

In fact, I don't think this period handling is very consistent right now: 
There are other places using arithmetic calculation from `CPU_CFS_PERIOD`, and 
things will be badly off if it's different from system default.

I think we probably should either 1) perform valiation that 
`CPU_CFS_PERIOD` is consistent with local system default, or 2) simply detect 
local system default and use it for `CPU_CFS_PERIOD`.


- Zhitao Li


On Oct. 4, 2015, 6:40 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36181/
> ---
> 
> (Updated Oct. 4, 2015, 6:40 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2154
> https://issues.apache.org/jira/browse/MESOS-2154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Port CFS support to Docker Containerizer
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
> 
> Diff: https://reviews.apache.org/r/36181/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36181: Port CFS support to Docker Containerizer

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/#review101441
---


Patch looks great!

Reviews applied: [36181]

All tests passed.

- Mesos ReviewBot


On Oct. 4, 2015, 6:40 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36181/
> ---
> 
> (Updated Oct. 4, 2015, 6:40 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2154
> https://issues.apache.org/jira/browse/MESOS-2154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Port CFS support to Docker Containerizer
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
> 
> Diff: https://reviews.apache.org/r/36181/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36181: Port CFS support to Docker Containerizer

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/
---

(Updated Oct. 4, 2015, 6:40 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

Fix compile error.


Bugs: MESOS-2154
https://issues.apache.org/jira/browse/MESOS-2154


Repository: mesos


Description
---

Port CFS support to Docker Containerizer


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 

Diff: https://reviews.apache.org/r/36181/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 36181: Port CFS support to Docker Containerizer

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/
---

(Updated Oct. 3, 2015, 5:14 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Rebase


Bugs: MESOS-2154
https://issues.apache.org/jira/browse/MESOS-2154


Repository: mesos


Description
---

Port CFS support to Docker Containerizer


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 

Diff: https://reviews.apache.org/r/36181/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 36181: Port CFS support to Docker Containerizer

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/#review91391
---


Patch looks great!

Reviews applied: [36181]

All tests passed.

- Mesos ReviewBot


On July 11, 2015, 8:59 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36181/
 ---
 
 (Updated July 11, 2015, 8:59 a.m.)
 
 
 Review request for mesos and Timothy Chen.
 
 
 Bugs: MESOS-2154
 https://issues.apache.org/jira/browse/MESOS-2154
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Port CFS support to Docker Containerizer
 
 
 Diffs
 -
 
   src/slave/containerizer/docker.cpp cfb60177fe48ec0eeab12ff392c6c9f89634b92f 
 
 Diff: https://reviews.apache.org/r/36181/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 haosdent huang
 

Re: Review Request 36181: Port CFS support to Docker Containerizer

[haosdent huang]

 On July 4, 2015, 5:34 p.m., Timothy Chen wrote:
  src/slave/containerizer/docker.cpp, line 282
  https://reviews.apache.org/r/36181/diff/1/?file=999124#file999124line282
 
  These flags are supported only after a certain docker version right?
  
  I think we need to log and disable this when the user is using a older 
  version that doens't support these flags.

Is it possible to support cfs in older docker? Maybe we could change to that 
way.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/#review90392
---


On July 4, 2015, 4:55 p.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36181/
 ---
 
 (Updated July 4, 2015, 4:55 p.m.)
 
 
 Review request for mesos and Timothy Chen.
 
 
 Bugs: MESOS-2154
 https://issues.apache.org/jira/browse/MESOS-2154
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Port CFS support to Docker Containerizer
 
 
 Diffs
 -
 
   src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba 
 
 Diff: https://reviews.apache.org/r/36181/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 haosdent huang
 

Review Request 36181: Port CFS support to Docker Containerizer

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/
---

Review request for mesos and Timothy Chen.


Bugs: MESOS-2154
https://issues.apache.org/jira/browse/MESOS-2154


Repository: mesos


Description
---

Port CFS support to Docker Containerizer


Diffs
-

  src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba 

Diff: https://reviews.apache.org/r/36181/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 36181: Port CFS support to Docker Containerizer

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/#review90399
---


Patch looks great!

Reviews applied: [36181]

All tests passed.

- Mesos ReviewBot


On July 4, 2015, 4:55 p.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36181/
 ---
 
 (Updated July 4, 2015, 4:55 p.m.)
 
 
 Review request for mesos and Timothy Chen.
 
 
 Bugs: MESOS-2154
 https://issues.apache.org/jira/browse/MESOS-2154
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Port CFS support to Docker Containerizer
 
 
 Diffs
 -
 
   src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba 
 
 Diff: https://reviews.apache.org/r/36181/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 haosdent huang