Re: Review Request 36810: Don't check protobuf jar in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/#review94175 --- Ship it! Seems reasonable to me. I haven't run a build personally toto guarantee things keep working. - Cody Maloney On Aug. 4, 2015, 9:27 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- (Updated Aug. 4, 2015, 9:27 a.m.) Review request for mesos, Adam B, Cody Maloney, Michael Park, and Timothy St. Clair. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar in libprocess. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36810/diff/ Testing --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check -j4 GTEST_FILTER=-* Thanks, haosdent huang
Re: Review Request 36810: Don't check protobuf jar in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/#review93565 --- Ship it! LGTM. Any build experts want to take a look? @tstclair, @cmaloney - Adam B On July 28, 2015, 7:43 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- (Updated July 28, 2015, 7:43 p.m.) Review request for mesos, Adam B and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar in libprocess. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36810/diff/ Testing --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check -j4 GTEST_FILTER=-* Thanks, haosdent huang
Re: Review Request 36810: Don't check protobuf jar in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/#review93317 --- Patch looks great! Reviews applied: [36810] All tests passed. - Mesos ReviewBot On July 25, 2015, 8:22 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- (Updated July 25, 2015, 8:22 a.m.) Review request for mesos, Adam B and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar in libprocess. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36810/diff/ Testing --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check -j4 GTEST_FILTER=-* Thanks, haosdent huang
Re: Review Request 36810: Don't check protobuf jar in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/#review93239 --- Did you test this with java enabled as well? What about without `--with-protobuf=`? All four combinations still need to compile pass the unit tests. - Adam B On July 25, 2015, 1:22 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- (Updated July 25, 2015, 1:22 a.m.) Review request for mesos, Adam B and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar in libprocess. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36810/diff/ Testing --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check -j4 GTEST_FILTER=-* Thanks, haosdent huang
Review Request 36810: Don't check protobuf jar in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar in libprocess. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36810/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36810: Don't check protobuf jar in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- (Updated July 25, 2015, 8:21 a.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2480 https://issues.apache.org/jira/browse/MESOS-2480 Repository: mesos Description --- Don't check protobuf jar in libprocess. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36810/diff/ Testing (updated) --- ../configure --with-protobuf=/usr/local --disable-java make -j4 make check -j4 GTEST_FILTER=-* Thanks, haosdent huang