Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95303 --- Ship it! LGTM module the issue below. BTW, do we know if anyone is using the `mesos-cli` tool? I had a discussion with ThomasR a while ago and he suggested that the `mesos-cli` tool should be removed from mesos source repo entirely. src/cli/python/mesos/__init__.py (line 25) https://reviews.apache.org/r/36819/#comment150189 Don't we need a `mesos.cli` here as well? - Kapil Arya On Aug. 7, 2015, 11:08 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 11:08 a.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
On Aug. 13, 2015, 6:27 p.m., Kapil Arya wrote: src/cli/python/mesos/__init__.py, line 27 https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line27 Don't we need a `mesos.cli` here as well? Kartic Krish wrote: Looks like the module structure has been changed, so just 'packages': [ 'mesos' ] should be OK. Yes?not need mesos.cli here. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95303 --- On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
On Aug. 13, 2015, 4 p.m., Marco Massenzio wrote: Today we are cutting a 0.24 RC (according to @Vinod's recent email) - it would be great if we could have this fix in, which solves an issue with the Python installers. Can anyone please do anything about this one? Thanks! T_T? thank you very much @marco. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95262 --- On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 13, 2015, 6:46 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Changes --- Add shebang to all setup.py.in Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs (updated) - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac b9ecafd1813d87d604364d354994e4dba386f958 src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/setup.py.in 880e2a6fe4470e50bbfa805967fb983fb8a9987f src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/setup.py.in 9fc9ad2bdeaf1ad3f007e36f24bbe5b10dedc77b src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/setup.py.in 72cb770bda659957c03853c3c99ba6c53f606df8 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/setup.py.in 8ffde68e60e8c968f196e6e0790aeef47d0fb662 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
On Aug. 13, 2015, 6:27 p.m., Kapil Arya wrote: src/cli/python/mesos/__init__.py, line 27 https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line27 Don't we need a `mesos.cli` here as well? Looks like the module structure has been changed, so just 'packages': [ 'mesos' ] should be OK. - Kartic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95303 --- On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95305 --- Looks good. Please include the she-bang in setup.py (as per previous reviewers comment). - Kartic Krish On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95374 --- Ship it! Ship It! - Till Toenshoff On Aug. 13, 2015, 6:46 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 13, 2015, 6:46 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac b9ecafd1813d87d604364d354994e4dba386f958 src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/setup.py.in 880e2a6fe4470e50bbfa805967fb983fb8a9987f src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/setup.py.in 9fc9ad2bdeaf1ad3f007e36f24bbe5b10dedc77b src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/setup.py.in 72cb770bda659957c03853c3c99ba6c53f606df8 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/setup.py.in 8ffde68e60e8c968f196e6e0790aeef47d0fb662 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95262 --- Ship it! Today we are cutting a 0.24 RC (according to @Vinod's recent email) - it would be great if we could have this fix in, which solves an issue with the Python installers. Can anyone please do anything about this one? Thanks! - Marco Massenzio On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
On Aug. 12, 2015, 4:47 p.m., Alexander Rojas wrote: src/cli/python/mesos/__init__.py, line 1 https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line1 Why was the shebang line removed? The origin file is __init__.py. __init__.py need have shebang line. But this file become from __init__.py to setup.py. Other setup.py file also don't have shebang. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95112 --- On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95112 --- src/cli/python/mesos/__init__.py https://reviews.apache.org/r/36819/#comment149927 Why was the shebang line removed? - Alexander Rojas On Aug. 7, 2015, 5:08 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 5:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 2:31 p.m.) Review request for mesos, Benjamin Hindman, Marco Massenzio, and Sebastien Pahl. Changes --- rebase code Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs (updated) - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review94554 --- Patch looks great! Reviews applied: [36819] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 7, 2015, 3:08 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing (updated) --- make check # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04 ## test steps: 1. sudo make install 2. export PYTHONPATH 3. python -c 'import mesos; from mesos import cli, http, futures' Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93931 --- Ship it! This looks good to me. Provided that we test it on a couple of other platforms (CentOS 7.x and Ubuntu 14.04 would be good) I'm fine with it. You still need a shepher to commit this, though - I can't. - Marco Massenzio On Aug. 1, 2015, 10:09 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 1, 2015, 10:09 a.m.) Review request for mesos, Benjamin Hindman and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 1, 2015, 10:09 a.m.) Review request for mesos, Benjamin Hindman and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93552 --- Patch looks great! Reviews applied: [36819] All tests passed. - Mesos ReviewBot On July 30, 2015, 2:49 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 30, 2015, 2:49 a.m.) Review request for mesos, Benjamin Hindman and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 30, 2015, 2:49 a.m.) Review request for mesos, Benjamin Hindman and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs (updated) - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 29, 2015, 7:44 a.m.) Review request for mesos, Benjamin Hindman and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs (updated) - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 29, 2015, 7:43 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs (updated) - 3rdparty/libprocess/include/process/http.hpp b8d930058aa3ae9d21ae0f7b420d49f2448f84b1 3rdparty/libprocess/src/openssl.hpp efa40c4c73210eae87c3fc904334794ca80e097a 3rdparty/libprocess/src/openssl.cpp 1f68460a760403f88a00a32137969456ce1c2266 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 3rdparty/libprocess/src/tests/process_tests.cpp 95e3257b030128e9d03dde9aa048602c68c6a446 3rdparty/libprocess/src/tests/ssl_tests.cpp a7173dfbbf42065634762bfa7c89c0be0ea15079 Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 docs/home.md 3dff97ba35fafe8fca7e18866f0c7e8d526022e1 docs/mesos-ssl.md 9df34dbf3873fc2a074e6d864f3bdbc389517bf7 docs/operational-guide.md ef81db672bd5c8fab172336956ab03461ae35064 docs/oversubscription.md b1a6c9979025ce33190792a07b8e9618c518430e docs/reconciliation.md b50d692d415cf677d23051fdd8a2fddbd4c4d134 include/mesos/slave/isolator.hpp 22f1e3686f50c3b9290561aa7e5073e24a702824 include/mesos/slave/isolator.proto 3d9222be5e9bd9e9f665fb2e57db6b7e925c8fbd src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/common/http.hpp 9e4290f9e1f72730f63466d498a953cc5031a92b src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/slave/containerizer/isolator.hpp 710c584f95d60c1931b40ca041409aa819a06cba src/slave/containerizer/isolator.cpp ed610f9f8fe328fb3b73f620858dc632725e51f8 src/slave/containerizer/isolators/cgroups/cpushare.hpp 6b980f26fe8bb51dd989a0578337bc13dbd087ad src/slave/containerizer/isolators/cgroups/cpushare.cpp 907d7e78bfb591197e150ac053bb857d15a1e6dc src/slave/containerizer/isolators/cgroups/mem.hpp e831878ab47b8455a4831ebe305373130b194a40 src/slave/containerizer/isolators/cgroups/mem.cpp e343d0b9751b46bc5a4a8ccd32c0b2745e110e6b src/slave/containerizer/isolators/cgroups/perf_event.hpp 73f245bc9166e1f7550466ddd97113c63ce44e73 src/slave/containerizer/isolators/cgroups/perf_event.cpp 0e421cb6ad3e04b71746033ab15d0f1695fcd5e7 src/slave/containerizer/isolators/filesystem/posix.hpp 4c7a6f2b7530c88c34d533dba9593006ad5284b2 src/slave/containerizer/isolators/filesystem/posix.cpp 4861ee13fc34eef03d28f26d57a7d11aebed81a6 src/slave/containerizer/isolators/filesystem/shared.hpp 45e4ba09993e7b77f2df45a5c86bc00fa2d83977 src/slave/containerizer/isolators/filesystem/shared.cpp f3c2916b5c5bddbf3f7220ae75ef75fe8e7d7cae src/slave/containerizer/isolators/namespaces/pid.hpp 858e43683c88ac62abfc74ff28e8073895cf6f64 src/slave/containerizer/isolators/namespaces/pid.cpp 8e643f4afae8c24cd4d68aa349148b6f402b286b src/slave/containerizer/isolators/network/port_mapping.hpp 2599c9800e3edf12ec883b31c280324b24b195c5 src/slave/containerizer/isolators/network/port_mapping.cpp 3f6e9df8711995d0dd3903c6170fdd5ad61aac5a src/slave/containerizer/isolators/posix.hpp ef19749c0d5b795fee54d67cfc0d983b0f7084ec src/slave/containerizer/isolators/posix/disk.hpp 9fa584ff4a2f3c90c4d81aecefbcba57fa2294ad src/slave/containerizer/isolators/posix/disk.cpp 6dda77bad7ab135b6d339a80b98a291ea7120e95 src/slave/containerizer/launcher.hpp 8cc832e99838683c14d8158bdf52a267299508c7 src/slave/containerizer/launcher.cpp 5267eecbdf31c88cd3c7dc7172b5aff7bac534b0 src/slave/containerizer/linux_launcher.hpp bf6bf3f27dac007429c224d4f6798ac68316accb src/slave/containerizer/linux_launcher.cpp 12acf4d08cb7fb1161820cf4bb480fd1bc2c6858 src/slave/containerizer/mesos/containerizer.hpp
Re: Review Request 36819: Use setup.py in python cli package.
On July 27, 2015, 5:58 p.m., Marco Massenzio wrote: thanks for doing this! (this may also fix a long-standing issue of mine: https://issues.apache.org/jira/browse/MESOS-2337 - could you please take a look?) Only a few minor nits about formatting and stuff, then I think this is good. We'll need to find a committer to push this. Did you test it? on which platforms? Hi, @marco. Thank you for your review. I test it on CentOS 6.6. Could you review this again? Thank you very much. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93141 --- On July 29, 2015, 7:49 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 29, 2015, 7:49 a.m.) Review request for mesos, Benjamin Hindman and Marco Massenzio. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93141 --- thanks for doing this! (this may also fix a long-standing issue of mine: https://issues.apache.org/jira/browse/MESOS-2337 - could you please take a look?) Only a few minor nits about formatting and stuff, then I think this is good. We'll need to find a committer to push this. Did you test it? on which platforms? src/Makefile.am (lines 933 - 940) https://reviews.apache.org/r/36819/#comment147401 please don't just comment out a bunch of lines of code without explaining why you do this - is there a TODO there? why are you commenting out, instead of removing them? Also, isn't this patch about exactly that TODO(benh)? shouldn't you remove it? or comment? src/Makefile.am (lines 1192 - 1196) https://reviews.apache.org/r/36819/#comment147402 not sure if it's an RB artifact, or your tab spacings are all off: can you please verify the continuation \ are all lined up? not just here, too, but everywhere src/cli/python/mesos/__init__.py (line 20) https://reviews.apache.org/r/36819/#comment147403 s/utils/utilities src/python/cli/src/mesos/__init__.py (line 1) https://reviews.apache.org/r/36819/#comment147406 good job at adding the reference, but also please add a few lines to explain why this is being done here (in brief, then you have the URL ref for those who want to learn the gory details) I've been working on Python for the past five years, and yet these lines scare me :) - Marco Massenzio On July 26, 2015, 5:24 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 5:24 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- Review request for mesos. Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/36819/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 5:10 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/36819/diff/ Testing (updated) --- make check Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 5:24 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93047 --- Patch looks great! Reviews applied: [36819] All tests passed. - Mesos ReviewBot On July 26, 2015, 2:47 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 2:47 p.m.) Review request for mesos. Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/36819/diff/ Testing --- Thanks, haosdent huang
