Re: Review Request 36844: Libprocess: Used THREAD_LOCAL to replace ThreadLocal.

2015-07-30 Thread Benjamin Hindman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93659
---

Ship it!


Ship It!

- Benjamin Hindman


On July 27, 2015, 9:15 p.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36844/
 ---
 
 (Updated July 27, 2015, 9:15 p.m.)
 
 
 Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
 Park.
 
 
 Bugs: MESOS-3119
 https://issues.apache.org/jira/browse/MESOS-3119
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   3rdparty/libprocess/3rdparty/Makefile.am 
 bd95fe197532131255072a86aba83cd5e822419a 
   3rdparty/libprocess/include/process/executor.hpp 
 434d23ac8119e24454f8bc8324d7b26ec62a85c7 
   3rdparty/libprocess/include/process/process.hpp 
 8620547148f8a69d5b661eaf08063ca72347b6a4 
   3rdparty/libprocess/src/libev.hpp fd26728fe9c0688b82fd75f0bfc83b8d0a3b8581 
   3rdparty/libprocess/src/libev.cpp 55ed6efd47ac1864af828e68320c1929843cde57 
   3rdparty/libprocess/src/libevent.hpp 
 3a0a46ba95db95f4a007ec755012ac969d1c6cd9 
   3rdparty/libprocess/src/libevent.cpp 
 1f175a4ae83391152d064779c6ab69d31cbaf867 
   3rdparty/libprocess/src/process.cpp 
 6d3609d06d017d8e50d7935b335fda7ebecbd04c 
 
 Diff: https://reviews.apache.org/r/36844/diff/
 
 
 Testing
 ---
 
 make check with libev and libevent.
 Requires validation on OSX.
 
 
 Thanks,
 
 Joris Van Remoortere
 




Re: Review Request 36844: Libprocess: Used THREAD_LOCAL to replace ThreadLocal.

2015-07-28 Thread Artem Harutyunyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93339
---

Ship it!


make check with libev and libevent on OSX

- Artem Harutyunyan


On July 27, 2015, 2:15 p.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36844/
 ---
 
 (Updated July 27, 2015, 2:15 p.m.)
 
 
 Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
 Park.
 
 
 Bugs: MESOS-3119
 https://issues.apache.org/jira/browse/MESOS-3119
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   3rdparty/libprocess/3rdparty/Makefile.am 
 bd95fe197532131255072a86aba83cd5e822419a 
   3rdparty/libprocess/include/process/executor.hpp 
 434d23ac8119e24454f8bc8324d7b26ec62a85c7 
   3rdparty/libprocess/include/process/process.hpp 
 8620547148f8a69d5b661eaf08063ca72347b6a4 
   3rdparty/libprocess/src/libev.hpp fd26728fe9c0688b82fd75f0bfc83b8d0a3b8581 
   3rdparty/libprocess/src/libev.cpp 55ed6efd47ac1864af828e68320c1929843cde57 
   3rdparty/libprocess/src/libevent.hpp 
 3a0a46ba95db95f4a007ec755012ac969d1c6cd9 
   3rdparty/libprocess/src/libevent.cpp 
 1f175a4ae83391152d064779c6ab69d31cbaf867 
   3rdparty/libprocess/src/process.cpp 
 6d3609d06d017d8e50d7935b335fda7ebecbd04c 
 
 Diff: https://reviews.apache.org/r/36844/diff/
 
 
 Testing
 ---
 
 make check with libev and libevent.
 Requires validation on OSX.
 
 
 Thanks,
 
 Joris Van Remoortere
 




Re: Review Request 36844: Libprocess: Used THREAD_LOCAL to replace ThreadLocal.

2015-07-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93187
---

Ship it!


Ship It!

- Joseph Wu


On July 27, 2015, 2:15 p.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36844/
 ---
 
 (Updated July 27, 2015, 2:15 p.m.)
 
 
 Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
 Park.
 
 
 Bugs: MESOS-3119
 https://issues.apache.org/jira/browse/MESOS-3119
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   3rdparty/libprocess/3rdparty/Makefile.am 
 bd95fe197532131255072a86aba83cd5e822419a 
   3rdparty/libprocess/include/process/executor.hpp 
 434d23ac8119e24454f8bc8324d7b26ec62a85c7 
   3rdparty/libprocess/include/process/process.hpp 
 8620547148f8a69d5b661eaf08063ca72347b6a4 
   3rdparty/libprocess/src/libev.hpp fd26728fe9c0688b82fd75f0bfc83b8d0a3b8581 
   3rdparty/libprocess/src/libev.cpp 55ed6efd47ac1864af828e68320c1929843cde57 
   3rdparty/libprocess/src/libevent.hpp 
 3a0a46ba95db95f4a007ec755012ac969d1c6cd9 
   3rdparty/libprocess/src/libevent.cpp 
 1f175a4ae83391152d064779c6ab69d31cbaf867 
   3rdparty/libprocess/src/process.cpp 
 6d3609d06d017d8e50d7935b335fda7ebecbd04c 
 
 Diff: https://reviews.apache.org/r/36844/diff/
 
 
 Testing
 ---
 
 make check with libev and libevent.
 Requires validation on OSX.
 
 
 Thanks,
 
 Joris Van Remoortere
 




Re: Review Request 36844: Libprocess: Used THREAD_LOCAL to replace ThreadLocal.

2015-07-27 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/
---

(Updated July 27, 2015, 9:15 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.


Changes
---

rebased.


Summary (updated)
-

Libprocess: Used THREAD_LOCAL to replace ThreadLocal.


Bugs: MESOS-3119
https://issues.apache.org/jira/browse/MESOS-3119


Repository: mesos


Description (updated)
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
bd95fe197532131255072a86aba83cd5e822419a 
  3rdparty/libprocess/include/process/executor.hpp 
434d23ac8119e24454f8bc8324d7b26ec62a85c7 
  3rdparty/libprocess/include/process/process.hpp 
8620547148f8a69d5b661eaf08063ca72347b6a4 
  3rdparty/libprocess/src/libev.hpp fd26728fe9c0688b82fd75f0bfc83b8d0a3b8581 
  3rdparty/libprocess/src/libev.cpp 55ed6efd47ac1864af828e68320c1929843cde57 
  3rdparty/libprocess/src/libevent.hpp 3a0a46ba95db95f4a007ec755012ac969d1c6cd9 
  3rdparty/libprocess/src/libevent.cpp 1f175a4ae83391152d064779c6ab69d31cbaf867 
  3rdparty/libprocess/src/process.cpp 6d3609d06d017d8e50d7935b335fda7ebecbd04c 

Diff: https://reviews.apache.org/r/36844/diff/


Testing
---

make check with libev and libevent.
Requires validation on OSX.


Thanks,

Joris Van Remoortere



Re: Review Request 36844: Libprocess: Used THREAD_LOCAL to replace ThreadLocal.

2015-07-27 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93190
---


Patch looks great!

Reviews applied: [36822, 36823, 36824, 36825, 36826, 36827, 36828, 36829, 
36830, 36842, 36845, 36844]

All tests passed.

- Mesos ReviewBot


On July 27, 2015, 9:15 p.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36844/
 ---
 
 (Updated July 27, 2015, 9:15 p.m.)
 
 
 Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
 Park.
 
 
 Bugs: MESOS-3119
 https://issues.apache.org/jira/browse/MESOS-3119
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   3rdparty/libprocess/3rdparty/Makefile.am 
 bd95fe197532131255072a86aba83cd5e822419a 
   3rdparty/libprocess/include/process/executor.hpp 
 434d23ac8119e24454f8bc8324d7b26ec62a85c7 
   3rdparty/libprocess/include/process/process.hpp 
 8620547148f8a69d5b661eaf08063ca72347b6a4 
   3rdparty/libprocess/src/libev.hpp fd26728fe9c0688b82fd75f0bfc83b8d0a3b8581 
   3rdparty/libprocess/src/libev.cpp 55ed6efd47ac1864af828e68320c1929843cde57 
   3rdparty/libprocess/src/libevent.hpp 
 3a0a46ba95db95f4a007ec755012ac969d1c6cd9 
   3rdparty/libprocess/src/libevent.cpp 
 1f175a4ae83391152d064779c6ab69d31cbaf867 
   3rdparty/libprocess/src/process.cpp 
 6d3609d06d017d8e50d7935b335fda7ebecbd04c 
 
 Diff: https://reviews.apache.org/r/36844/diff/
 
 
 Testing
 ---
 
 make check with libev and libevent.
 Requires validation on OSX.
 
 
 Thanks,
 
 Joris Van Remoortere