Re: Review Request 37301: Scheduler tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- (Updated Aug. 10, 2015, 4:44 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes --- Depends change Bugs: MESOS-2552 https://issues.apache.org/jira/browse/MESOS-2552 Repository: mesos Description --- Disabled auth from tests Diffs - src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37301/diff/ Testing --- Thanks, Anand Mazumdar
Review Request 37301: Scheduler tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552 https://issues.apache.org/jira/browse/MESOS-2552 Repository: mesos Description --- Disabled auth from tests Diffs - src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37301/diff/ Testing --- Thanks, Anand Mazumdar
Re: Review Request 37301: Scheduler tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/#review94769 --- src/tests/scheduler_tests.cpp (lines 166 - 170) https://reviews.apache.org/r/37301/#comment149365 I'm confused. Just because we are not using authentication, we are getting a new event here? Why didn't we receive this before? - Vinod Kone On Aug. 10, 2015, 4:44 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- (Updated Aug. 10, 2015, 4:44 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552 https://issues.apache.org/jira/browse/MESOS-2552 Repository: mesos Description --- Disabled auth from tests Diffs - src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37301/diff/ Testing --- Thanks, Anand Mazumdar
Re: Review Request 37301: Scheduler tests
On Aug. 10, 2015, 6:17 p.m., Vinod Kone wrote: src/tests/scheduler_tests.cpp, lines 167-171 https://reviews.apache.org/r/37301/diff/1/?file=1036461#file1036461line167 I'm confused. Just because we are not using authentication, we are getting a new event here? Why didn't we receive this before? Correct. This also mixes changes from r37303 i.e. moving the scheduler to http. Ideally it should only have changes that remove the credential. My bad - Anand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/#review94769 --- On Aug. 10, 2015, 4:44 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- (Updated Aug. 10, 2015, 4:44 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552 https://issues.apache.org/jira/browse/MESOS-2552 Repository: mesos Description --- Disabled auth from tests Diffs - src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37301/diff/ Testing --- Thanks, Anand Mazumdar
Re: Review Request 37301: Scheduler tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/#review94865 --- Ship it! Ship It! - Vinod Kone On Aug. 11, 2015, 2:07 a.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- (Updated Aug. 11, 2015, 2:07 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552 https://issues.apache.org/jira/browse/MESOS-2552 Repository: mesos Description --- Disabled authentication from scheduler tests Diffs - src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37301/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37301: Scheduler tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- (Updated Aug. 11, 2015, 2:07 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes --- Vinod's review comment to remove scheduler http changes and put in a separate review Bugs: MESOS-2552 https://issues.apache.org/jira/browse/MESOS-2552 Repository: mesos Description (updated) --- Disabled authentication from scheduler tests Diffs (updated) - src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37301/diff/ Testing (updated) --- make check Thanks, Anand Mazumdar
