Re: Review Request 37370: Fix CMake build compile error; don't compile GMock with cxx11 flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37370/#review98506 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 10, 2015, 8:53 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37370/ > --- > > (Updated Sept. 10, 2015, 8:53 p.m.) > > > Review request for mesos, Benjamin Hindman, haosdent huang, Artem > Harutyunyan, Joris Van Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Right now if you try to compile GMock a non-Windows platform using the > CMake build system, it will error out. The problem seems to be the CXX11 > flag. > > This commit will solve this problem by removing that flag. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 997cc0d0e316e316136d4746e50e9e292a82b36b > > Diff: https://reviews.apache.org/r/37370/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 37370: Fix CMake build compile error; don't compile GMock with cxx11 flag.
> On Sept. 8, 2015, 11:12 p.m., Artem Harutyunyan wrote: > > This file has not been commited, so I suggest to drop this review and make > > this change in the original review that introduces the affected line. > > Alex Clemmer wrote: > It actually has been committed. haosdent broke the build, that's why it's > here. > > haosdent huang wrote: > Yes, my fix for this is https://reviews.apache.org/r/37502/ > > Alex Clemmer wrote: > No worries haosdent, it will just take me some time to apply your reviews > to test them on the platforms that are really important. :) I'll give it a > shot before I go to bed tonight. Never mind, you could review it at any time when you have time. Thanks a lot. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37370/#review98110 --- On Sept. 10, 2015, 8:53 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37370/ > --- > > (Updated Sept. 10, 2015, 8:53 p.m.) > > > Review request for mesos, Benjamin Hindman, haosdent huang, Artem > Harutyunyan, Joris Van Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Right now if you try to compile GMock a non-Windows platform using the > CMake build system, it will error out. The problem seems to be the CXX11 > flag. > > This commit will solve this problem by removing that flag. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 997cc0d0e316e316136d4746e50e9e292a82b36b > > Diff: https://reviews.apache.org/r/37370/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 37370: Fix CMake build compile error; don't compile GMock with cxx11 flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37370/ --- (Updated Sept. 10, 2015, 8:53 p.m.) Review request for mesos, Benjamin Hindman, haosdent huang, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- Right now if you try to compile GMock a non-Windows platform using the CMake build system, it will error out. The problem seems to be the CXX11 flag. This commit will solve this problem by removing that flag. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 997cc0d0e316e316136d4746e50e9e292a82b36b Diff: https://reviews.apache.org/r/37370/diff/ Testing --- Thanks, Alex Clemmer
