Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/#review96170 --- Ship it! LGTM, sorry for the long turn around time on this review - a few style nits in the make file, but otherwise good to go. src/Makefile.am (line 476) https://reviews.apache.org/r/37479/#comment151475 Is the indentation of the '\' right here? Set tabstop to 8 and use hard tabs. Also, is this sorted correctly? src/Makefile.am (line 754) https://reviews.apache.org/r/37479/#comment151476 Same comments as above - Niklas Nielsen On Aug. 14, 2015, 6:44 p.m., Guangya Liu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated Aug. 14, 2015, 6:44 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated Aug. 25, 2015, 1:28 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs (updated) - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37479/#review95435
---
Bad patch!
Reviews applied: [37479]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d mesos-0.24.0; then find mesos-0.24.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.24.0 || { sleep 5 rm -rf
mesos-0.24.0; }; else :; fi
test -d mesos-0.24.0 || mkdir mesos-0.24.0
(cd 3rdparty make top_distdir=../mesos-0.24.0
distdir=../mesos-0.24.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess make top_distdir=../../mesos-0.24.0
distdir=../../mesos-0.24.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d ../../mesos-0.24.0/3rdparty/libprocess || mkdir
../../mesos-0.24.0/3rdparty/libprocess
(cd 3rdparty make top_distdir=../../../mesos-0.24.0
distdir=../../../mesos-0.24.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout make top_distdir=../../../../mesos-0.24.0
distdir=../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d ../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout || mkdir
../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout
(cd include make top_distdir=../../../../../mesos-0.24.0
distdir=../../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[6]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
make[6]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
test -n : \
|| find ../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout
-type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r
../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout
make[5]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd include make top_distdir=../../../mesos-0.24.0
distdir=../../../mesos-0.24.0/3rdparty/libprocess/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
test -n : \
|| find ../../mesos-0.24.0/3rdparty/libprocess -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r ../../mesos-0.24.0/3rdparty/libprocess
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd src make top_distdir=../mesos-0.24.0 distdir=../mesos-0.24.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[2]: *** No rule to make target `slave/qos_controller.hpp', needed by
`distdir'. Stop.
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make: *** [dist] Error 2
-
Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/#review95508 --- Patch looks great! Reviews applied: [37479] All tests passed. - Mesos ReviewBot On Aug. 15, 2015, 1:44 a.m., Guangya Liu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated Aug. 15, 2015, 1:44 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated 八月 15, 2015, 1:44 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs (updated) - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
