Re: Review Request 38233: os: add swap information to memory().

2015-11-18 Thread Chi Zhang 


> On Nov. 17, 2015, 7:20 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, lines 708-759
> > 
> >
> > do these calculations work irrespective of whether swap is enabled or 
> > disabled?

if swap is disabled, xsu_total will be 0


- Chi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38233/#review106917
---


On Sept. 10, 2015, 5:57 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38233/
> ---
> 
> (Updated Sept. 10, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-2918
> https://issues.apache.org/jira/browse/mesos-2918
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> os: add swap information to memory().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp 
> 82ccd766bd22393f48be4554c7da46338dd92d1f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 
> 
> Diff: https://reviews.apache.org/r/38233/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38233: os: add swap information to memory().

2015-11-18 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38233/#review107062
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 10, 2015, 5:57 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38233/
> ---
> 
> (Updated Sept. 10, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-2918
> https://issues.apache.org/jira/browse/mesos-2918
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> os: add swap information to memory().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp 
> 82ccd766bd22393f48be4554c7da46338dd92d1f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 
> 
> Diff: https://reviews.apache.org/r/38233/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38233: os: add swap information to memory().

2015-11-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38233/#review106917
---



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (lines 708 - 759)


do these calculations work irrespective of whether swap is enabled or 
disabled?


- Vinod Kone


On Sept. 10, 2015, 5:57 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38233/
> ---
> 
> (Updated Sept. 10, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-2918
> https://issues.apache.org/jira/browse/mesos-2918
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> os: add swap information to memory().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp 
> 82ccd766bd22393f48be4554c7da46338dd92d1f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 
> 
> Diff: https://reviews.apache.org/r/38233/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38233: os: add swap information to memory().

2015-09-11 Thread Cong Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38233/#review98629
---

Ship it!


Ship It!

- Cong Wang


On Sept. 10, 2015, 5:57 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38233/
> ---
> 
> (Updated Sept. 10, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-2918
> https://issues.apache.org/jira/browse/mesos-2918
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> os: add swap information to memory().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp 
> 82ccd766bd22393f48be4554c7da46338dd92d1f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 
> 
> Diff: https://reviews.apache.org/r/38233/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38233: os: add swap information to memory().

2015-09-10 Thread Chi Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38233/
---

(Updated Sept. 10, 2015, 5:57 p.m.)


Review request for mesos and Jie Yu.


Bugs: mesos-2918
https://issues.apache.org/jira/browse/mesos-2918


Repository: mesos


Description
---

os: add swap information to memory().


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp 
82ccd766bd22393f48be4554c7da46338dd92d1f 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 

Diff: https://reviews.apache.org/r/38233/diff/


Testing
---


Thanks,

Chi Zhang

Re: Review Request 38233: os: add swap information to memory().

2015-09-09 Thread Cong Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38233/#review98307
---



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 757)


Bytes(usage.xsu_total * pageSize)?


- Cong Wang


On Sept. 9, 2015, 9:32 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38233/
> ---
> 
> (Updated Sept. 9, 2015, 9:32 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-2918
> https://issues.apache.org/jira/browse/mesos-2918
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> os: add swap information to memory().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp 
> 82ccd766bd22393f48be4554c7da46338dd92d1f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 
> 
> Diff: https://reviews.apache.org/r/38233/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>