Re: Review Request 38284: Layers from Appc store should be the rootfs dir, not the top level dir.

2015-09-11 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38284/#review98590
---


Patch looks great!

Reviews applied: [38284]

All tests passed.

- Mesos ReviewBot


On Sept. 11, 2015, 1:12 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38284/
> ---
> 
> (Updated Sept. 11, 2015, 1:12 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Layers from Appc store should be the rootfs dir, not the top level dir.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioners/appc/store.cpp 
> 04ab2add7613b28959ad2031c0cc60f188e97ba2 
>   src/tests/containerizer/appc_provisioner_tests.cpp 
> b1be2d81cbd08d2736dddbc22c163635758c2f59 
> 
> Diff: https://reviews.apache.org/r/38284/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 38284: Layers from Appc store should be the rootfs dir, not the top level dir.

2015-09-10 Thread Chi Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38284/#review98525
---

Ship it!


Ship It!

- Chi Zhang


On Sept. 11, 2015, 1:12 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38284/
> ---
> 
> (Updated Sept. 11, 2015, 1:12 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Layers from Appc store should be the rootfs dir, not the top level dir.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioners/appc/store.cpp 
> 04ab2add7613b28959ad2031c0cc60f188e97ba2 
>   src/tests/containerizer/appc_provisioner_tests.cpp 
> b1be2d81cbd08d2736dddbc22c163635758c2f59 
> 
> Diff: https://reviews.apache.org/r/38284/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Review Request 38284: Layers from Appc store should be the rootfs dir, not the top level dir.

2015-09-10 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38284/
---

Review request for mesos, Chi Zhang, Vinod Kone, and Jiang Yan Xu.


Repository: mesos


Description
---

Layers from Appc store should be the rootfs dir, not the top level dir.


Diffs
-

  src/slave/containerizer/provisioners/appc/store.cpp 
04ab2add7613b28959ad2031c0cc60f188e97ba2 
  src/tests/containerizer/appc_provisioner_tests.cpp 
b1be2d81cbd08d2736dddbc22c163635758c2f59 

Diff: https://reviews.apache.org/r/38284/diff/


Testing
---

make check


Thanks,

Jie Yu



Re: Review Request 38284: Layers from Appc store should be the rootfs dir, not the top level dir.

2015-09-10 Thread Jiang Yan Xu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38284/#review98527
---

Ship it!


Ship It!

- Jiang Yan Xu


On Sept. 10, 2015, 6:12 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38284/
> ---
> 
> (Updated Sept. 10, 2015, 6:12 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Layers from Appc store should be the rootfs dir, not the top level dir.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioners/appc/store.cpp 
> 04ab2add7613b28959ad2031c0cc60f188e97ba2 
>   src/tests/containerizer/appc_provisioner_tests.cpp 
> b1be2d81cbd08d2736dddbc22c163635758c2f59 
> 
> Diff: https://reviews.apache.org/r/38284/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>